Re: [PATCH 5/7] [media] omap3isp: remove unused var

2015-06-25 Thread Laurent Pinchart
Hi Mauro,

On Wednesday 24 June 2015 07:49:09 Mauro Carvalho Chehab wrote:
 drivers/media/platform/omap3isp/isppreview.c:932:6: warning: variable
 ‘features’ set but not used [-Wunused-but-set-variable]
 
 Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

On a side note, I'd appreciate if you could wait a couple of days for review 
before committing patches to the media_tree master branch.

Or maybe process pending pull requests for the same driver before fast-
tracking your own patches ;-)

 diff --git a/drivers/media/platform/omap3isp/isppreview.c
 b/drivers/media/platform/omap3isp/isppreview.c index
 15cb254ccc39..13803270d104 100644
 --- a/drivers/media/platform/omap3isp/isppreview.c
 +++ b/drivers/media/platform/omap3isp/isppreview.c
 @@ -929,14 +929,10 @@ static void preview_setup_hw(struct isp_prev_device
 *prev, u32 update, u32 active)
  {
   unsigned int i;
 - u32 features;
 
   if (update == 0)
   return;
 
 - features = (prev-params.params[0].features  active)
 -  | (prev-params.params[1].features  ~active);
 -
   for (i = 0; i  ARRAY_SIZE(update_attrs); i++) {
   const struct preview_update *attr = update_attrs[i];
   struct prev_params *params;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 5/7] [media] omap3isp: remove unused var

2015-06-24 Thread Mauro Carvalho Chehab
drivers/media/platform/omap3isp/isppreview.c:932:6: warning: variable 
‘features’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com

diff --git a/drivers/media/platform/omap3isp/isppreview.c 
b/drivers/media/platform/omap3isp/isppreview.c
index 15cb254ccc39..13803270d104 100644
--- a/drivers/media/platform/omap3isp/isppreview.c
+++ b/drivers/media/platform/omap3isp/isppreview.c
@@ -929,14 +929,10 @@ static void preview_setup_hw(struct isp_prev_device 
*prev, u32 update,
 u32 active)
 {
unsigned int i;
-   u32 features;
 
if (update == 0)
return;
 
-   features = (prev-params.params[0].features  active)
-| (prev-params.params[1].features  ~active);
-
for (i = 0; i  ARRAY_SIZE(update_attrs); i++) {
const struct preview_update *attr = update_attrs[i];
struct prev_params *params;
-- 
2.4.3

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html