Re: [PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function
On Sat, 15 Dec 2012 17:57:54 +0800 Albert Wang twan...@marvell.com wrote: From: Libin Yang lby...@marvell.com This patch refines mcam_set_contig_buffer() in mcam core It might be nice if the changelog said *why* this was being done - don't worry about insulting my ugly code :) But no biggie... Acked-by: Jonathan Corbet cor...@lwn.net jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function
Hi, Jonathan -Original Message- From: Jonathan Corbet [mailto:cor...@lwn.net] Sent: Monday, 17 December, 2012 00:07 To: Albert Wang Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function On Sat, 15 Dec 2012 17:57:54 +0800 Albert Wang twan...@marvell.com wrote: From: Libin Yang lby...@marvell.com This patch refines mcam_set_contig_buffer() in mcam core It might be nice if the changelog said *why* this was being done - [Albert Wang] We just want to reduce some redundancy code. :) don't worry about insulting my ugly code :) But no biggie... Acked-by: Jonathan Corbet cor...@lwn.net jon Thanks Albert Wang 86-21-61092656 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function
From: Libin Yang lby...@marvell.com
This patch refines mcam_set_contig_buffer() in mcam core
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/media/platform/marvell-ccic/mcam-core.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c
b/drivers/media/platform/marvell-ccic/mcam-core.c
index 19e91c5..3cc1d0c 100755
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -486,22 +486,21 @@ static void mcam_set_contig_buffer(struct mcam_camera
*cam, int frame)
*/
if (list_empty(cam-buffers)) {
buf = cam-vb_bufs[frame ^ 0x1];
- cam-vb_bufs[frame] = buf;
- mcam_reg_write(cam, frame == 0 ? REG_Y0BAR : REG_Y1BAR,
- vb2_dma_contig_plane_dma_addr(buf-vb_buf, 0));
set_bit(CF_SINGLE_BUFFER, cam-flags);
cam-frame_state.singles++;
- return;
+ } else {
+ /*
+* OK, we have a buffer we can use.
+*/
+ buf = list_first_entry(cam-buffers, struct mcam_vb_buffer,
+ queue);
+ list_del_init(buf-queue);
+ clear_bit(CF_SINGLE_BUFFER, cam-flags);
}
- /*
-* OK, we have a buffer we can use.
-*/
- buf = list_first_entry(cam-buffers, struct mcam_vb_buffer, queue);
- list_del_init(buf-queue);
+
+ cam-vb_bufs[frame] = buf;
mcam_reg_write(cam, frame == 0 ? REG_Y0BAR : REG_Y1BAR,
vb2_dma_contig_plane_dma_addr(buf-vb_buf, 0));
- cam-vb_bufs[frame] = buf;
- clear_bit(CF_SINGLE_BUFFER, cam-flags);
}
/*
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
