Re: [PATCH v10 00/18] Qualcomm video decoder/encoder driver
Hi Mauro, One note, I have sent pull request for the firmware but forgot to update the firmware path in the driver for the new location. It is not a big deal, but I have to send one more patch which changes the firmware path. About COMPILE_TEST, the patch for qcom_scm driver probably will be taken in 4.13 merge window through arm-soc. So I'm wondering could you postpone 18/18 until this patch is merged to avoid build breakage. regards, Stan On 06/12/2017 07:27 PM, Stanimir Varbanov wrote: > Hello, > > The changes since patchset v9 are the following: > * patches from 1/18 to 9/18 are the same. > * patches from 10/18 to 16/18 are fixes for warns/errors found by >Mauro when building with its gcc7. > * patch 17/18 adding support for minimum buffers for capture >get control. This fixes an issue with gstreamer and it will >be good to have it in the inital version of the venus driver. > * patch 18/18 enable COMPILE_TEST Kconfig option for the driver, >and this patch depends on the other one for qcom_scm driver. >The submited patch for qcom_scm driver can be found at [1]. > > Mauro, I failed to build gcc7 on my own machine and fallback to > a pre-built version of the gcc-7 for may Ubuntu distro. The version > which I tried was: gcc version 7.1.0 (Ubuntu 7.1.0-5ubuntu2~16.04). > Unfortunately I cannot reproduce the warns/errors (except two > warnings) from your compiler (even that the version looks > the same 7.1.0). So I fixed the warns/errors as per your response > to v9, and hope that the errors will disappear. > > [1] https://patchwork.kernel.org/patch/9775803/ > > Stanimir Varbanov (18): > media: v4l2-mem2mem: extend m2m APIs for more accurate buffer > management > doc: DT: venus: binding document for Qualcomm video driver > MAINTAINERS: Add Qualcomm Venus video accelerator driver > media: venus: adding core part and helper functions > media: venus: vdec: add video decoder files > media: venus: venc: add video encoder files > media: venus: hfi: add Host Firmware Interface (HFI) > media: venus: hfi: add Venus HFI files > media: venus: enable building of Venus video driver > media: venus: hfi: fix mutex unlock > media: venus: hfi_cmds: fix variable dereferenced before check > media: venus: helpers: fix variable dereferenced before check > media: venus: hfi_venus: fix variable dereferenced before check > media: venus: hfi_msgs: fix set but not used variables > media: venus: vdec: fix compile error in vdec_close > media: venus: venc: fix compile error in venc_close > media: venus: vdec: add support for min buffers for capture > media: venus: enable building with COMPILE_TEST > > .../devicetree/bindings/media/qcom,venus.txt | 107 ++ > MAINTAINERS|8 + > drivers/media/platform/Kconfig | 13 + > drivers/media/platform/Makefile|2 + > drivers/media/platform/qcom/venus/Makefile | 11 + > drivers/media/platform/qcom/venus/core.c | 388 + > drivers/media/platform/qcom/venus/core.h | 323 > drivers/media/platform/qcom/venus/firmware.c | 109 ++ > drivers/media/platform/qcom/venus/firmware.h | 22 + > drivers/media/platform/qcom/venus/helpers.c| 725 + > drivers/media/platform/qcom/venus/helpers.h| 45 + > drivers/media/platform/qcom/venus/hfi.c| 522 +++ > drivers/media/platform/qcom/venus/hfi.h| 175 +++ > drivers/media/platform/qcom/venus/hfi_cmds.c | 1259 > drivers/media/platform/qcom/venus/hfi_cmds.h | 304 > drivers/media/platform/qcom/venus/hfi_helper.h | 1050 + > drivers/media/platform/qcom/venus/hfi_msgs.c | 1052 + > drivers/media/platform/qcom/venus/hfi_msgs.h | 283 > drivers/media/platform/qcom/venus/hfi_venus.c | 1572 > > drivers/media/platform/qcom/venus/hfi_venus.h | 23 + > drivers/media/platform/qcom/venus/hfi_venus_io.h | 113 ++ > drivers/media/platform/qcom/venus/vdec.c | 1162 +++ > drivers/media/platform/qcom/venus/vdec.h | 23 + > drivers/media/platform/qcom/venus/vdec_ctrls.c | 158 ++ > drivers/media/platform/qcom/venus/venc.c | 1283 > drivers/media/platform/qcom/venus/venc.h | 23 + > drivers/media/platform/qcom/venus/venc_ctrls.c | 270 > drivers/media/v4l2-core/v4l2-mem2mem.c | 37 + > include/media/v4l2-mem2mem.h | 92 ++ > 29 files changed, 11154 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,venus.txt > create mode 100644 drivers/media/platform/qcom/venus/Makefile > create mode 100644 drivers/media/platform/qcom/venus/core.c > create mode 100644 drivers/media/platform/qcom/venus/core.h > create mode 100644
[PATCH v10 00/18] Qualcomm video decoder/encoder driver
Hello, The changes since patchset v9 are the following: * patches from 1/18 to 9/18 are the same. * patches from 10/18 to 16/18 are fixes for warns/errors found by Mauro when building with its gcc7. * patch 17/18 adding support for minimum buffers for capture get control. This fixes an issue with gstreamer and it will be good to have it in the inital version of the venus driver. * patch 18/18 enable COMPILE_TEST Kconfig option for the driver, and this patch depends on the other one for qcom_scm driver. The submited patch for qcom_scm driver can be found at [1]. Mauro, I failed to build gcc7 on my own machine and fallback to a pre-built version of the gcc-7 for may Ubuntu distro. The version which I tried was: gcc version 7.1.0 (Ubuntu 7.1.0-5ubuntu2~16.04). Unfortunately I cannot reproduce the warns/errors (except two warnings) from your compiler (even that the version looks the same 7.1.0). So I fixed the warns/errors as per your response to v9, and hope that the errors will disappear. [1] https://patchwork.kernel.org/patch/9775803/ Stanimir Varbanov (18): media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management doc: DT: venus: binding document for Qualcomm video driver MAINTAINERS: Add Qualcomm Venus video accelerator driver media: venus: adding core part and helper functions media: venus: vdec: add video decoder files media: venus: venc: add video encoder files media: venus: hfi: add Host Firmware Interface (HFI) media: venus: hfi: add Venus HFI files media: venus: enable building of Venus video driver media: venus: hfi: fix mutex unlock media: venus: hfi_cmds: fix variable dereferenced before check media: venus: helpers: fix variable dereferenced before check media: venus: hfi_venus: fix variable dereferenced before check media: venus: hfi_msgs: fix set but not used variables media: venus: vdec: fix compile error in vdec_close media: venus: venc: fix compile error in venc_close media: venus: vdec: add support for min buffers for capture media: venus: enable building with COMPILE_TEST .../devicetree/bindings/media/qcom,venus.txt | 107 ++ MAINTAINERS|8 + drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile|2 + drivers/media/platform/qcom/venus/Makefile | 11 + drivers/media/platform/qcom/venus/core.c | 388 + drivers/media/platform/qcom/venus/core.h | 323 drivers/media/platform/qcom/venus/firmware.c | 109 ++ drivers/media/platform/qcom/venus/firmware.h | 22 + drivers/media/platform/qcom/venus/helpers.c| 725 + drivers/media/platform/qcom/venus/helpers.h| 45 + drivers/media/platform/qcom/venus/hfi.c| 522 +++ drivers/media/platform/qcom/venus/hfi.h| 175 +++ drivers/media/platform/qcom/venus/hfi_cmds.c | 1259 drivers/media/platform/qcom/venus/hfi_cmds.h | 304 drivers/media/platform/qcom/venus/hfi_helper.h | 1050 + drivers/media/platform/qcom/venus/hfi_msgs.c | 1052 + drivers/media/platform/qcom/venus/hfi_msgs.h | 283 drivers/media/platform/qcom/venus/hfi_venus.c | 1572 drivers/media/platform/qcom/venus/hfi_venus.h | 23 + drivers/media/platform/qcom/venus/hfi_venus_io.h | 113 ++ drivers/media/platform/qcom/venus/vdec.c | 1162 +++ drivers/media/platform/qcom/venus/vdec.h | 23 + drivers/media/platform/qcom/venus/vdec_ctrls.c | 158 ++ drivers/media/platform/qcom/venus/venc.c | 1283 drivers/media/platform/qcom/venus/venc.h | 23 + drivers/media/platform/qcom/venus/venc_ctrls.c | 270 drivers/media/v4l2-core/v4l2-mem2mem.c | 37 + include/media/v4l2-mem2mem.h | 92 ++ 29 files changed, 11154 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,venus.txt create mode 100644 drivers/media/platform/qcom/venus/Makefile create mode 100644 drivers/media/platform/qcom/venus/core.c create mode 100644 drivers/media/platform/qcom/venus/core.h create mode 100644 drivers/media/platform/qcom/venus/firmware.c create mode 100644 drivers/media/platform/qcom/venus/firmware.h create mode 100644 drivers/media/platform/qcom/venus/helpers.c create mode 100644 drivers/media/platform/qcom/venus/helpers.h create mode 100644 drivers/media/platform/qcom/venus/hfi.c create mode 100644 drivers/media/platform/qcom/venus/hfi.h create mode 100644 drivers/media/platform/qcom/venus/hfi_cmds.c create mode 100644 drivers/media/platform/qcom/venus/hfi_cmds.h create mode 100644 drivers/media/platform/qcom/venus/hfi_helper.h create mode 100644 drivers/media/platform/qcom/venus/hfi_msgs.c create mode 100644
