[PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a..23e05ce 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -135,9 +135,9 @@
#clock-cells = <1>;
compatible = "renesas,r7s72100-mstp-clocks",
"renesas,cpg-mstp-clocks";
reg = <0xfcfe042c 4>;
- clocks = <&p0_clk>;
- clock-indices = ;
- clock-output-names = "rtc";
+ clocks = <&b_clk>, <&p0_clk>;
+ clock-indices = ;
+ clock-output-names = "ceu", "rtc";
};
mstp7_clks: mstp7_clks@fcfe0430 {
@@ -667,4 +667,13 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ ceu: camera@e821 {
+ reg = <0xe821 0x3000>;
+ compatible = "renesas,r7s72100-ceu";
+ interrupts = ;
+ clocks = <&mstp6_clks R7S72100_CLK_CEU>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.7.4
Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart > Acked-by: Hans Verkuil This patch depends on the binding for "renesas,r7s72100-ceu". Please repost or otherwise ping me once that dependency has been accepted.
Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
Hi Simon, On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > > Add Capture Engine Unit (CEU) node to device tree. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven > > Reviewed-by: Laurent Pinchart > > Acked-by: Hans Verkuil > > This patch depends on the binding for "renesas,r7s72100-ceu". > Please repost or otherwise ping me once that dependency has been accepted. Bindings for the CEU interface went in v4.17-rc1. Could you please resurect this patch? Thanks j signature.asc Description: PGP signature
Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
On Mon, Apr 23, 2018 at 05:21:43PM +0200, jacopo mondi wrote:
> Hi Simon,
>
> On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote:
> > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote:
> > > Add Capture Engine Unit (CEU) node to device tree.
> > >
> > > Signed-off-by: Jacopo Mondi
> > > Reviewed-by: Geert Uytterhoeven
> > > Reviewed-by: Laurent Pinchart
> > > Acked-by: Hans Verkuil
> >
> > This patch depends on the binding for "renesas,r7s72100-ceu".
> > Please repost or otherwise ping me once that dependency has been accepted.
>
> Bindings for the CEU interface went in v4.17-rc1.
>
> Could you please resurect this patch?
Sure, I took the liberty of "rebasing" it to preserve the new node-order
of r7s72100.dtsi. The result is as follows:
From: Jacopo Mondi
Subject: [PATCH] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
[simon: rebased]
Signed-off-by: Simon Horman
---
arch/arm/boot/dts/r7s72100.dtsi | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ecf9516bcda8..4a1aade0e751 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -375,6 +375,15 @@
status = "disabled";
};
+ ceu: camera@e821 {
+ reg = <0xe821 0x3000>;
+ compatible = "renesas,r7s72100-ceu";
+ interrupts = ;
+ clocks = <&mstp6_clks R7S72100_CLK_CEU>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
wdt: watchdog@fcfe {
compatible = "renesas,r7s72100-wdt", "renesas,rza-wdt";
reg = <0xfcfe 0x6>;
@@ -429,9 +438,9 @@
#clock-cells = <1>;
compatible = "renesas,r7s72100-mstp-clocks",
"renesas,cpg-mstp-clocks";
reg = <0xfcfe042c 4>;
- clocks = <&p0_clk>;
- clock-indices = ;
- clock-output-names = "rtc";
+ clocks = <&b_clk>, <&p0_clk>;
+ clock-indices = ;
+ clock-output-names = "ceu", "rtc";
};
mstp7_clks: mstp7_clks@fcfe0430 {
--
2.11.0
Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
Hi Simon,
On Tue, Apr 24, 2018 at 10:23:56AM +0200, Simon Horman wrote:
> On Mon, Apr 23, 2018 at 05:21:43PM +0200, jacopo mondi wrote:
> > Hi Simon,
> >
> > On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote:
> > > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote:
> > > > Add Capture Engine Unit (CEU) node to device tree.
> > > >
> > > > Signed-off-by: Jacopo Mondi
> > > > Reviewed-by: Geert Uytterhoeven
> > > > Reviewed-by: Laurent Pinchart
> > > > Acked-by: Hans Verkuil
> > >
> > > This patch depends on the binding for "renesas,r7s72100-ceu".
> > > Please repost or otherwise ping me once that dependency has been accepted.
> >
> > Bindings for the CEU interface went in v4.17-rc1.
> >
> > Could you please resurect this patch?
>
> Sure, I took the liberty of "rebasing" it to preserve the new node-order
> of r7s72100.dtsi. The result is as follows:
That's even better.
Thanks
j
>
> From: Jacopo Mondi
> Subject: [PATCH] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)
>
> Add Capture Engine Unit (CEU) node to device tree.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Geert Uytterhoeven
> Reviewed-by: Laurent Pinchart
> Acked-by: Hans Verkuil
> [simon: rebased]
> Signed-off-by: Simon Horman
> ---
> arch/arm/boot/dts/r7s72100.dtsi | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index ecf9516bcda8..4a1aade0e751 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -375,6 +375,15 @@
> status = "disabled";
> };
>
> + ceu: camera@e821 {
> + reg = <0xe821 0x3000>;
> + compatible = "renesas,r7s72100-ceu";
> + interrupts = ;
> + clocks = <&mstp6_clks R7S72100_CLK_CEU>;
> + power-domains = <&cpg_clocks>;
> + status = "disabled";
> + };
> +
> wdt: watchdog@fcfe {
> compatible = "renesas,r7s72100-wdt", "renesas,rza-wdt";
> reg = <0xfcfe 0x6>;
> @@ -429,9 +438,9 @@
> #clock-cells = <1>;
> compatible = "renesas,r7s72100-mstp-clocks",
> "renesas,cpg-mstp-clocks";
> reg = <0xfcfe042c 4>;
> - clocks = <&p0_clk>;
> - clock-indices = ;
> - clock-output-names = "rtc";
> + clocks = <&b_clk>, <&p0_clk>;
> + clock-indices = ;
> + clock-output-names = "ceu", "rtc";
> };
>
> mstp7_clks: mstp7_clks@fcfe0430 {
> --
> 2.11.0
>
>
signature.asc
Description: PGP signature
