Re: [PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop

2014-07-01 Thread Laurent Pinchart 
Hi Sergei,

On Tuesday 24 June 2014 16:00:45 Sergei Shtylyov wrote:
 Hello.
 
 On 06/24/2014 03:54 AM, Laurent Pinchart wrote:
  videobuf2 expects no buffer to be owned by the driver when the
  stop_stream queue operation returns. As the vsp1 driver fails to do so,
  a warning is generated at stream top time.
  
  Fix this by mark releasing all buffers queued on the IRQ queue in the
 
 Mark releasing?

I'll fix that, thank you.

  stop_stream operation handler and marking them as erroneous.
  
  Signed-off-by: Laurent Pinchart
  laurent.pinchart+rene...@ideasonboard.com

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop

2014-06-24 Thread Sergei Shtylyov 

Hello.

On 06/24/2014 03:54 AM, Laurent Pinchart wrote:


videobuf2 expects no buffer to be owned by the driver when the
stop_stream queue operation returns. As the vsp1 driver fails to do so,
a warning is generated at stream top time.



Fix this by mark releasing all buffers queued on the IRQ queue in the


   Mark releasing?


stop_stream operation handler and marking them as erroneous.



Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com


WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop

2014-06-23 Thread Laurent Pinchart 
videobuf2 expects no buffer to be owned by the driver when the
stop_stream queue operation returns. As the vsp1 driver fails to do so,
a warning is generated at stream top time.

Fix this by mark releasing all buffers queued on the IRQ queue in the
stop_stream operation handler and marking them as erroneous.

Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
 drivers/media/platform/vsp1/vsp1_video.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/platform/vsp1/vsp1_video.c 
b/drivers/media/platform/vsp1/vsp1_video.c
index c717e28..9bb156c 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -742,6 +742,7 @@ static void vsp1_video_stop_streaming(struct vb2_queue *vq)
 {
struct vsp1_video *video = vb2_get_drv_priv(vq);
struct vsp1_pipeline *pipe = to_vsp1_pipeline(video-video.entity);
+   struct vsp1_video_buffer *buffer;
unsigned long flags;
int ret;
 
@@ -759,6 +760,8 @@ static void vsp1_video_stop_streaming(struct vb2_queue *vq)
 
/* Remove all buffers from the IRQ queue. */
spin_lock_irqsave(video-irqlock, flags);
+   list_for_each_entry(buffer, video-irqqueue, queue)
+   vb2_buffer_done(buffer-buf, VB2_BUF_STATE_ERROR);
INIT_LIST_HEAD(video-irqqueue);
spin_unlock_irqrestore(video-irqlock, flags);
 }
-- 
1.8.5.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html