Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
On 02/06/2016 16:14, Nick Dyer wrote: > On 01/06/2016 19:17, Dmitry Torokhov wrote: >> On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >>> This is a series of patches to add diagnostic data support to the Atmel >>> maXTouch driver. It's a rewrite of the previous implementation which output >>> via >>> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. >> >> I do not have any objections other than some nits form the input side; >> majority of the review should come from V4L2 side here... > > Thanks for the review. I've hopefully fixed the issues you raised and > pushed it to > https://github.com/ndyer/linux/commits/diagnostic-v4l-20160602 > > I will wait for the V4L2 folks to comment before posting a [PATCH v4] Hi Hans- I've done a bit of further work on this now, so unless you have any conerns, I'm going to post an update to the patch set in the next couple of days. cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
Hi Dmitry- On 01/06/2016 19:17, Dmitry Torokhov wrote: > On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >> This is a series of patches to add diagnostic data support to the Atmel >> maXTouch driver. It's a rewrite of the previous implementation which output >> via >> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. > > I do not have any objections other than some nits form the input side; > majority of the review should come from V4L2 side here... Thanks for the review. I've hopefully fixed the issues you raised and pushed it to https://github.com/ndyer/linux/commits/diagnostic-v4l-20160602 I will wait for the V4L2 folks to comment before posting a [PATCH v4] cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: > This is a series of patches to add diagnostic data support to the Atmel > maXTouch driver. It's a rewrite of the previous implementation which output > via > debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. > > There are significant performance advantages to putting this code into the > driver. The algorithm for retrieving the data has been fairly consistent > across a range of chips, with the exception of the mXT1386 series (see patch). > > We have a utility which can read the data and display it in a useful format: > https://github.com/ndyer/heatmap/commits/heatmap-v4l > > These patches are also available from > https://github.com/ndyer/linux/commits/diagnostic-v4l > > Changes in v3: > - Address V4L2 review comments from Hans Verkuil > - Run v4l-compliance and fix all issues - needs minor patch here: > https://github.com/ndyer/v4l-utils/commit/cf50469773f > > Changes in v2: > - Split pixfmt changes into separate commit and add DocBook > - Introduce VFL_TYPE_TOUCH_SENSOR and /dev/v4l-touch > - Remove "single node" support for now, it may be better to treat it as > metadata later > - Explicitly set VFL_DIR_RX > - Fix Kconfig > I do not have any objections other than some nits form the input side; majority of the review should come from V4L2 side here... -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L
This is a series of patches to add diagnostic data support to the Atmel maXTouch driver. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. There are significant performance advantages to putting this code into the driver. The algorithm for retrieving the data has been fairly consistent across a range of chips, with the exception of the mXT1386 series (see patch). We have a utility which can read the data and display it in a useful format: https://github.com/ndyer/heatmap/commits/heatmap-v4l These patches are also available from https://github.com/ndyer/linux/commits/diagnostic-v4l Changes in v3: - Address V4L2 review comments from Hans Verkuil - Run v4l-compliance and fix all issues - needs minor patch here: https://github.com/ndyer/v4l-utils/commit/cf50469773f Changes in v2: - Split pixfmt changes into separate commit and add DocBook - Introduce VFL_TYPE_TOUCH_SENSOR and /dev/v4l-touch - Remove "single node" support for now, it may be better to treat it as metadata later - Explicitly set VFL_DIR_RX - Fix Kconfig -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
