Re: [PATCH v3 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-28 Thread Pavel Machek
Hi!

> +led-max-microamp: Maximum torch (assist) current in microamperes. The
> +   value must be in the range between [2, 16] and
> +   divisible by 2.
> +ams,input-max-microamp: Maximum flash controller input current. The

"in microamperes".

> + value must be in the range [125, 200]
> + and divisible by 5.

Is there any reason for "ams," prefix here?

Best regards,
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature


[PATCH v3 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-23 Thread Sakari Ailus
Document DT bindings for Analog Devices as3645a flash LED controller which
also supports an indicator LED.

Signed-off-by: Sakari Ailus 
Acked-by: Jacek Anaszewski 
Acked-by: Rob Herring 
---
 .../devicetree/bindings/leds/ams,as3645a.txt   | 71 ++
 1 file changed, 71 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/ams,as3645a.txt

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
new file mode 100644
index ..12c5ef26ec73
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -0,0 +1,71 @@
+Analog devices AS3645A device tree bindings
+
+The AS3645A flash LED controller can drive two LEDs, one high current
+flash LED and one indicator LED. The high current flash LED can be
+used in torch mode as well.
+
+Ranges below noted as [a, b] are closed ranges between a and b, i.e. a
+and b are included in the range.
+
+Please also see common.txt in the same directory.
+
+
+Required properties
+===
+
+compatible : Must be "ams,as3645a".
+reg: The I2C address of the device. Typically 0x30.
+
+
+Required properties of the "flash" child node
+=
+
+flash-timeout-us: Flash timeout in microseconds. The value must be in
+ the range [10, 85] and divisible by 5.
+flash-max-microamp: Maximum flash current in microamperes. Has to be
+   in the range between [20, 50] and
+   divisible by 2.
+led-max-microamp: Maximum torch (assist) current in microamperes. The
+ value must be in the range between [2, 16] and
+ divisible by 2.
+ams,input-max-microamp: Maximum flash controller input current. The
+   value must be in the range [125, 200]
+   and divisible by 5.
+
+
+Optional properties of the "flash" child node
+=
+
+label  : The label of the flash LED.
+
+
+Required properties of the "indicator" child node
+=
+
+led-max-microamp: Maximum indicator current. The allowed values are
+ 2500, 5000, 7500 and 1.
+
+Optional properties of the "indicator" child node
+=
+
+label  : The label of the indicator LED.
+
+
+Example
+===
+
+   as3645a@30 {
+   reg = <0x30>;
+   compatible = "ams,as3645a";
+   flash {
+   flash-timeout-us = <15>;
+   flash-max-microamp = <32>;
+   led-max-microamp = <6>;
+   ams,input-max-microamp = <175>;
+   label = "as3645a:flash";
+   };
+   indicator {
+   led-max-microamp = <1>;
+   label = "as3645a:indicator";
+   };
+   };
-- 
2.11.0