RE: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
Mauro, If you scan the patch, you would see the status of this patch series. --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) Not sure if there is a better way to include this information. The arch part of this series requires sign-off from Kevin who is copied on this. I have seen your procedure for submitting patches and would send you an official pull request as per your procedure once Kevin sign-off the arch part. I have following questions though.. Should we always add [RFC PATCH] in the subject? It makes sense for patches being reviewed. How to request sign-off? Do I only send patches to the person, not to the list? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Monday, February 01, 2010 6:12 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org Subject: Re: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver m-kariche...@ti.com wrote: From: Murali Karicheri m-kariche...@ti.com This is the header file for ISIF driver on DM365. ISIF driver is equivalent to CCDC driver on DM355 and DM644x. This driver is tested for YUV capture from TVP514x driver. This patch contains the header files required for this driver. The name of the file is changed to reflect the name of IP. Reviewed-by: Nori, Sekhar nsek...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) - Updated based on comments against v1 of the patch (v2) drivers/media/video/davinci/isif_regs.h | 269 include/media/davinci/isif.h| 531 +++ 2 files changed, 800 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/davinci/isif_regs.h create mode 100644 include/media/davinci/isif.h Hi Murali, As always, it is almost impossible for me to know if you're submitting yet another RFC version or a final version to be applied. So, I kindly ask you to send all those patches that are still under discussions with [RFC PATCH] at the subject, and, on the final version, send it to me via a git pull request. Unfortunately, I don't have enough time to go inside every RFC patch that are under discussion, so I prefer to optimize my time focusing on the patch versions that are considered ready for inclusion, and where there's no c/c to any members-only ML. -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
Karicheri, Muralidharan wrote: Mauro, If you scan the patch, you would see the status of this patch series. Ok, but it is not script-able. So, I need to have an easy way to know when a patch is still under discussion at the ML or if it is ready for merging. I need something that I can write an script on my machine to update Patchwork status and remove the stuff that are still under discussions from my pull queue. On most cases, the level of detail between two revisions of the omap drivers are due to some intrinsic details of the driver or the arch. So, it makes no sense for me to keep checking all reviews. I would love to, but unfortunately I have no spare time for it. That's why I prefer to review only the final revision, when the patch is submitted. --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) Not sure if there is a better way to include this information. The arch part of this series requires sign-off from Kevin who is copied on this. I have seen your procedure for submitting patches and would send you an official pull request as per your procedure once Kevin sign-off the arch part. The pull request is enough for me. I'll review when I receive it. I have following questions though.. Should we always add [RFC PATCH] in the subject? It makes sense for patches being reviewed. How to request sign-off? Do I only send patches to the person, not to the list? For the patches exchanged via the ML, I need some scriptable way to mark them as RFC at the Patchwork. So, adding [RFC PATCH] or [PATCH RFC] works. It also works if you add something like [PATCH OMAP] or [PATCH OMAP V4L], and provided that all other contributors to the patches you'll be sending me a pull request do exactly the same. I'll then write an specific script to mark those patches as RFC and remove from my queue, until I receive your [PULL] request. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
Karicheri, Muralidharan wrote: Mauro, How to request sign-off? Do I only send patches to the person, not to the list? I think you have not answered this. For the patches exchanged via the ML, I need some scriptable way to mark them as RFC at the Patchwork. So, adding [RFC PATCH] or [PATCH RFC] works. It also works if you add something like [PATCH OMAP] or [PATCH OMAP V4L], and provided that all other contributors to the patches you'll be sending me a pull request do exactly the same. Not sure what the last part of your statement (beginning with provided that) means. I mean: the better is if everybody sending such patches to do the same way. So, it would be really good if all traffic at the ML for those RFC patches to have the same tag. The patches always go through multiple iterations. In future I will add [RFC PATCH] for such patches. But this request was sent to Kevin to ack my patches so that I can send a pull request. How do I handle this? A direct email to Kevin without copying to linux-media ? You don't need to c/c the linux-media ML for it, but, of course you can do it. Anyway, at the pull requests that are touching on arch, please C/C the arch maintainer on it (even having their SOB). This will help them to track what's happening on the files under their responsibility. -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
From: Murali Karicheri m-kariche...@ti.com This is the header file for ISIF driver on DM365. ISIF driver is equivalent to CCDC driver on DM355 and DM644x. This driver is tested for YUV capture from TVP514x driver. This patch contains the header files required for this driver. The name of the file is changed to reflect the name of IP. Reviewed-by: Nori, Sekhar nsek...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) - Updated based on comments against v1 of the patch (v2) drivers/media/video/davinci/isif_regs.h | 269 include/media/davinci/isif.h| 531 +++ 2 files changed, 800 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/davinci/isif_regs.h create mode 100644 include/media/davinci/isif.h diff --git a/drivers/media/video/davinci/isif_regs.h b/drivers/media/video/davinci/isif_regs.h new file mode 100644 index 000..f7b8893 --- /dev/null +++ b/drivers/media/video/davinci/isif_regs.h @@ -0,0 +1,269 @@ +/* + * Copyright (C) 2008-2009 Texas Instruments Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ +#ifndef _ISIF_REGS_H +#define _ISIF_REGS_H + +/* ISIF registers relative offsets */ +#define SYNCEN 0x00 +#define MODESET0x04 +#define HDW0x08 +#define VDW0x0c +#define PPLN 0x10 +#define LPFR 0x14 +#define SPH0x18 +#define LNH0x1c +#define SLV0 0x20 +#define SLV1 0x24 +#define LNV0x28 +#define CULH 0x2c +#define CULV 0x30 +#define HSIZE 0x34 +#define SDOFST 0x38 +#define CADU 0x3c +#define CADL 0x40 +#define LINCFG00x44 +#define LINCFG10x48 +#define CCOLP 0x4c +#define CRGAIN 0x50 +#define CGRGAIN0x54 +#define CGBGAIN0x58 +#define CBGAIN 0x5c +#define COFSTA 0x60 +#define FLSHCFG0 0x64 +#define FLSHCFG1 0x68 +#define FLSHCFG2 0x6c +#define VDINT0 0x70 +#define VDINT1 0x74 +#define VDINT2 0x78 +#define MISC 0x7c +#define CGAMMAWD 0x80 +#define REC656IF 0x84 +#define CCDCFG 0x88 +/* +* Defect Correction registers +*/ +#define DFCCTL 0x8c +#define VDFSATLV 0x90 +#define DFCMEMCTL 0x94 +#define DFCMEM00x98 +#define DFCMEM10x9c +#define DFCMEM20xa0 +#define DFCMEM30xa4 +#define DFCMEM40xa8 +/ +* Black Clamp registers +/ +#define CLAMPCFG 0xac +#define CLDCOFST 0xb0 +#define CLSV 0xb4 +#define CLHWIN00xb8 +#define CLHWIN10xbc
RE: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
Hi Kevin, This patch is already approved by the V4L sub system. I need to get your approval for the arch part (patch #6). I have updated the clock handling based on your comments against the last patch (adding clock alias) I will request Mauro to merge the arch part via the v4l tree. I have a developer repository set up at linuxtv.org. Hereafter I will be sending pull request directly using the above repository. Thanks Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Karicheri, Muralidharan Sent: Monday, February 01, 2010 5:27 PM To: linux-media@vger.kernel.org; khil...@deeprootsystems.com Cc: hverk...@xs4all.nl; davinci-linux-open-sou...@linux.davincidsp.com; Karicheri, Muralidharan Subject: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver From: Murali Karicheri m-kariche...@ti.com This is the header file for ISIF driver on DM365. ISIF driver is equivalent to CCDC driver on DM355 and DM644x. This driver is tested for YUV capture from TVP514x driver. This patch contains the header files required for this driver. The name of the file is changed to reflect the name of IP. Reviewed-by: Nori, Sekhar nsek...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) - Updated based on comments against v1 of the patch (v2) drivers/media/video/davinci/isif_regs.h | 269 include/media/davinci/isif.h| 531 +++ 2 files changed, 800 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/davinci/isif_regs.h create mode 100644 include/media/davinci/isif.h diff --git a/drivers/media/video/davinci/isif_regs.h b/drivers/media/video/davinci/isif_regs.h new file mode 100644 index 000..f7b8893 --- /dev/null +++ b/drivers/media/video/davinci/isif_regs.h @@ -0,0 +1,269 @@ +/* + * Copyright (C) 2008-2009 Texas Instruments Inc + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ +#ifndef _ISIF_REGS_H +#define _ISIF_REGS_H + +/* ISIF registers relative offsets */ +#define SYNCEN0x00 +#define MODESET 0x04 +#define HDW 0x08 +#define VDW 0x0c +#define PPLN 0x10 +#define LPFR 0x14 +#define SPH 0x18 +#define LNH 0x1c +#define SLV0 0x20 +#define SLV1 0x24 +#define LNV 0x28 +#define CULH 0x2c +#define CULV 0x30 +#define HSIZE 0x34 +#define SDOFST0x38 +#define CADU 0x3c +#define CADL 0x40 +#define LINCFG0 0x44 +#define LINCFG1 0x48 +#define CCOLP 0x4c +#define CRGAIN0x50 +#define CGRGAIN 0x54 +#define CGBGAIN 0x58 +#define CBGAIN0x5c +#define COFSTA0x60 +#define FLSHCFG0 0x64 +#define FLSHCFG1 0x68 +#define FLSHCFG2 0x6c +#define VDINT00x70 +#define VDINT10x74 +#define VDINT20x78 +#define MISC 0x7c +#define CGAMMAWD 0x80 +#define REC656IF 0x84 +#define CCDCFG0x88 +/* +* Defect Correction registers
Re: [PATCH v3 1/6] V4L - vpfe capture - header files for ISIF driver
m-kariche...@ti.com wrote: From: Murali Karicheri m-kariche...@ti.com This is the header file for ISIF driver on DM365. ISIF driver is equivalent to CCDC driver on DM355 and DM644x. This driver is tested for YUV capture from TVP514x driver. This patch contains the header files required for this driver. The name of the file is changed to reflect the name of IP. Reviewed-by: Nori, Sekhar nsek...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to linux-next tree of v4l-dvb - rebasing to latest for merge (v3) - Updated based on comments against v1 of the patch (v2) drivers/media/video/davinci/isif_regs.h | 269 include/media/davinci/isif.h| 531 +++ 2 files changed, 800 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/davinci/isif_regs.h create mode 100644 include/media/davinci/isif.h Hi Murali, As always, it is almost impossible for me to know if you're submitting yet another RFC version or a final version to be applied. So, I kindly ask you to send all those patches that are still under discussions with [RFC PATCH] at the subject, and, on the final version, send it to me via a git pull request. Unfortunately, I don't have enough time to go inside every RFC patch that are under discussion, so I prefer to optimize my time focusing on the patch versions that are considered ready for inclusion, and where there's no c/c to any members-only ML. -- Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
