Em Thu, 30 Oct 2014 21:12:21 +0100
Matthias Schwarzott escreveu:
> Hi!
>
> This time the series got only small updates from Antti's review.
Oh, no! I just merged the v3 patch series. I manually fixed the
points that Antti has made.
I'm also testing it already.
Could you, instead, rebase it on the top of my merge?
I added it at:
ssh://linuxtv.org/git/mchehab/experimental.git cx231xx
While I'm still at the test phases.
>
> Additionally I added a patch to no longer directly modify
> the content of the port3 switch bit in PWR_CTL_EN (from function
> cx231xx_set_power_mode).
>
> Now there are two places where I wonder what happens:
> 1. cx231xx_set_Colibri_For_LowIF writes a fixed number into all 8bit parts of
> PWR_CTL_EN
>What is this for?
> 2. I guess, cx231xx_demod_reset should reset the digital demod. For this it
> should toggle the bits 0 and 1 of PWR_CTL_EN.
>But instead it touches but 8 and 9.
>Does someone know what this is?
>
> 3. Is remembering the last status of the port3 bit working good enough?
>Currently it is only used for the is_tuner hack function.
>
> Regards
> Matthias
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
