Re: [PATCH v4 05/16] media: coda: ignore coda busy status in coda_job_ready

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote:
 job_ready is supposed to signal whether a context is ready to be
 added to the job queue, not whether the CODA is ready to run it
 immediately.
 Calling v4l2_m2m_job_finish at the end of coda_irq_handler already
 guarantees that the coda is ready when v4l2-mem2mem eventually tries
 to run the next queued job.

 Signed-off-by: Philipp Zabel p.za...@pengutronix.de
 ---
  drivers/media/platform/coda.c |6 --
  1 file changed, 6 deletions(-)

 diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
 index f4b4a6f..d069787 100644
 --- a/drivers/media/platform/coda.c
 +++ b/drivers/media/platform/coda.c
 @@ -738,12 +738,6 @@ static int coda_job_ready(void *m2m_priv)
 return 0;
 }

 -   if (coda_isbusy(ctx-dev)) {
 -   v4l2_dbg(1, coda_debug, ctx-dev-v4l2_dev,
 -not ready: coda is still busy.\n);
 -   return 0;
 -   }
 -
 v4l2_dbg(1, coda_debug, ctx-dev-v4l2_dev,
 job ready\n);
 return 1;
 --
 1.7.10.4


Tested-by: Javier Martin javier.mar...@vista-silicon.com
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v4 05/16] media: coda: ignore coda busy status in coda_job_ready

2012-09-10 Thread Philipp Zabel
job_ready is supposed to signal whether a context is ready to be
added to the job queue, not whether the CODA is ready to run it
immediately.
Calling v4l2_m2m_job_finish at the end of coda_irq_handler already
guarantees that the coda is ready when v4l2-mem2mem eventually tries
to run the next queued job.

Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
 drivers/media/platform/coda.c |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index f4b4a6f..d069787 100644
--- a/drivers/media/platform/coda.c
+++ b/drivers/media/platform/coda.c
@@ -738,12 +738,6 @@ static int coda_job_ready(void *m2m_priv)
return 0;
}
 
-   if (coda_isbusy(ctx-dev)) {
-   v4l2_dbg(1, coda_debug, ctx-dev-v4l2_dev,
-not ready: coda is still busy.\n);
-   return 0;
-   }
-
v4l2_dbg(1, coda_debug, ctx-dev-v4l2_dev,
job ready\n);
return 1;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html