Re: [PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

2017-09-04 Thread Sakari Ailus 
On Mon, Sep 04, 2017 at 03:28:04PM +0200, Hans Verkuil wrote:
> On 09/03/2017 07:49 PM, Sakari Ailus wrote:
> > We only want to link sub-devices that were bound to the async notifier the
> > isp driver registered but there may be other sub-devices in the
> > v4l2_device as well. Check for the correct async notifier.
> 
> Just to be sure I understand this correctly: the original code wasn't wrong 
> as such,
> but this new test is just more precise.

Well, it would be wrong very soon. :-)

So yes. As long as there's just a single user of the async notifiers in for
a V4L2 device, what used to be there works. The other drivers don't seem to
be affected.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi

Re: [PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

2017-09-04 Thread Hans Verkuil 
On 09/03/2017 07:49 PM, Sakari Ailus wrote:
> We only want to link sub-devices that were bound to the async notifier the
> isp driver registered but there may be other sub-devices in the
> v4l2_device as well. Check for the correct async notifier.

Just to be sure I understand this correctly: the original code wasn't wrong as 
such,
but this new test is just more precise.

Right?

Hans

> Signed-off-by: Sakari Ailus 
> ---
>  drivers/media/platform/omap3isp/isp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c 
> b/drivers/media/platform/omap3isp/isp.c
> index a546cf774d40..3b1a9cd0e591 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct 
> v4l2_async_notifier *async)
>   return ret;
>  
>   list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
> - if (!sd->asd)
> + if (sd->notifier != &isp->notifier)
>   continue;
>  
>   ret = isp_link_entity(isp, &sd->entity,
>

[PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

2017-09-03 Thread Sakari Ailus 
We only want to link sub-devices that were bound to the async notifier the
isp driver registered but there may be other sub-devices in the
v4l2_device as well. Check for the correct async notifier.

Signed-off-by: Sakari Ailus 
---
 drivers/media/platform/omap3isp/isp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/omap3isp/isp.c 
b/drivers/media/platform/omap3isp/isp.c
index a546cf774d40..3b1a9cd0e591 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct 
v4l2_async_notifier *async)
return ret;
 
list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
-   if (!sd->asd)
+   if (sd->notifier != &isp->notifier)
continue;
 
ret = isp_link_entity(isp, &sd->entity,
-- 
2.11.0