Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors
Hi Hans, On Mon, Sep 04, 2017 at 04:37:29PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > The lens-focus property contains a phandle to the lens voice coil driver > > that is associated to the sensor; typically both are contained in the same > > camera module. > > Just to be certain: this lens-focus phandle should also work fine for a motor > driver, right? Yes; the commit message specifies what this is used right now but nothing prevents using this for different lens control technologies either. The property itself does not mention voice coil modules. > > We (Cisco) also have a camera that has an iris motor, but since nothing > upstream > uses that I'm not sure if we should bother adding that as well. Do you have one for focussing only or for zooming as well? -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi
Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > The lens-focus property contains a phandle to the lens voice coil driver > that is associated to the sensor; typically both are contained in the same > camera module. Just to be certain: this lens-focus phandle should also work fine for a motor driver, right? We (Cisco) also have a camera that has an iris motor, but since nothing upstream uses that I'm not sure if we should bother adding that as well. Regards, Hans > > Signed-off-by: Sakari Ailus > Acked-by: Pavel Machek > Reviewed-by: Sebastian Reichel > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/media/video-interfaces.txt > index fee73cf2a714..73d045127dcf 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -74,6 +74,8 @@ Optional properties > - flash: An array of phandles referring to the flash LED, a sub-node >of the LED driver device node. > > +- lens-focus: A phandle to the node of the focus lens controller. > + > > Optional endpoint properties > >
[PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors
The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel Acked-by: Rob Herring --- Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt index fee73cf2a714..73d045127dcf 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.txt +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt @@ -74,6 +74,8 @@ Optional properties - flash: An array of phandles referring to the flash LED, a sub-node of the LED driver device node. +- lens-focus: A phandle to the node of the focus lens controller. + Optional endpoint properties -- 2.11.0
