Re: [PULL] soc-camera, sh-vou, v4l2 for 2.6.36
Hi Mauro On Fri, 30 Jul 2010, Mauro Carvalho Chehab wrote: Em 29-07-2010 06:31, Guennadi Liakhovetski escreveu: Hi Mauro The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44: V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 19:47:16 -0300) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-2.6.36 Guennadi Liakhovetski (8): mediabus: fix ambiguous pixel code names V4L2: avoid name conflicts in macros This patch is incomplete, as other macros use sd without declaring it as an argument, like: #define v4l2_device_call_all(v4l2_dev, grpid, o, f, args...)\ __v4l2_device_call_subdevs(v4l2_dev,\ !(grpid) || sd-grp_id == (grpid), o, f , ##args) To make things even worse, some drivers have their own opinion about it, like: #define cx18_call_hw(cx, hw, o, f, args...) \ __v4l2_device_call_subdevs((cx)-v4l2_dev, \ !(hw) || (sd-grp_id (hw)), o, f , ##args) The result is that this patch breaks the compilation on several drivers. It is not your patch's fault. the problem is that those macros have something to hide. If sd is a parameter of the macro, they should have being declaring sd into their lists of arguments. nice... Please provide a version that will properly address those problems. As the other patches don't seem to need this change (at least, all compiled fine here), I'll drop this patch and apply the remaining ones. Thanks, that's a perfect solution for now! I'll think, if I can solve this probelm(s) properly. I'm on a holiday for the next 2 weeks, so, don't know when I'll be able to provide a new version. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] soc-camera, sh-vou, v4l2 for 2.6.36
Em 29-07-2010 06:31, Guennadi Liakhovetski escreveu: Hi Mauro The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44: V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 19:47:16 -0300) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-2.6.36 Guennadi Liakhovetski (8): mediabus: fix ambiguous pixel code names V4L2: avoid name conflicts in macros This patch is incomplete, as other macros use sd without declaring it as an argument, like: #define v4l2_device_call_all(v4l2_dev, grpid, o, f, args...)\ __v4l2_device_call_subdevs(v4l2_dev,\ !(grpid) || sd-grp_id == (grpid), o, f , ##args) To make things even worse, some drivers have their own opinion about it, like: #define cx18_call_hw(cx, hw, o, f, args...) \ __v4l2_device_call_subdevs((cx)-v4l2_dev, \ !(hw) || (sd-grp_id (hw)), o, f , ##args) The result is that this patch breaks the compilation on several drivers. It is not your patch's fault. the problem is that those macros have something to hide. If sd is a parameter of the macro, they should have being declaring sd into their lists of arguments. Please provide a version that will properly address those problems. As the other patches don't seem to need this change (at least, all compiled fine here), I'll drop this patch and apply the remaining ones. Cheers, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] soc-camera, sh-vou, v4l2 for 2.6.36
Hi Mauro The following changes since commit c57fd88318988f17731e446fe1d8498f506fdd44: V4L/DVB: uvcvideo: Add support for Manta MM-353 Plako (2010-07-05 19:47:16 -0300) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-2.6.36 Guennadi Liakhovetski (8): mediabus: fix ambiguous pixel code names V4L2: avoid name conflicts in macros V4L2: mediabus: add 12-bit Bayer and YUV420 pixel formats V4L2: soc-camera: export soc-camera bus type for notifications V4L2: soc-camera: add a MIPI CSI-2 driver for SH-Mobile platforms V4L2: sh_mobile_camera_ceu: add support for CSI2 V4L2: sh_vou: VOU does support the full PAL resolution too V4L: fix a comment in a driver arch/sh/boards/mach-ap325rxa/setup.c |2 +- drivers/media/video/Kconfig|6 + drivers/media/video/Makefile |1 + drivers/media/video/ak881x.c |6 +- drivers/media/video/mt9m111.c | 16 +- drivers/media/video/mt9t112.c | 12 +- drivers/media/video/ov772x.c |8 +- drivers/media/video/ov9640.c | 14 +- drivers/media/video/pxa_camera.c |8 +- drivers/media/video/rj54n1cb0c.c | 10 +- drivers/media/video/sh_mobile_ceu_camera.c | 147 ++-- drivers/media/video/sh_mobile_csi2.c | 354 drivers/media/video/sh_vou.c | 64 +++-- drivers/media/video/soc_camera.c |3 +- drivers/media/video/soc_mediabus.c |8 +- drivers/media/video/tw9910.c |8 +- include/media/sh_mobile_ceu.h |3 + include/media/sh_mobile_csi2.h | 46 include/media/soc_camera.h |3 + include/media/v4l2-device.h| 22 +- include/media/v4l2-mediabus.h | 13 +- 21 files changed, 643 insertions(+), 111 deletions(-) create mode 100644 drivers/media/video/sh_mobile_csi2.c create mode 100644 include/media/sh_mobile_csi2.h Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html