Hi Sakari,
Thanks for the patches. They look good to me.
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
On Wednesday 30 November 2011 18:38:21 Sakari Ailus wrote:
Hi all,
This patchset, which I'm sending as RFC since it has not been really tested
(including compiling the vivi patch), adds 64-bit integer menu controls.
The control items in the integer menu are just like in regular menus but
they are 64-bit integers instead of strings.
I'm also pondering whether to assign 1 to ctrl-step for menu type controls
as well but haven't checked what may have been the original reason to
implement it as it is now implemented.
The reason why I don't use a union for qmenu and qmenu_int in
v4l2_ctrl_config is that a lot of drivers use that field in the initialiser
and GCC 4.6 does not support initialisers with anonymous unions.
Similar union is created in v4l2_querymenu but I do not see this as a
problem since I do not expect initialisers to be used with this field in
the user space code.
Comments and questions are welcome.
---
Changes since RFC/PATCH v1:
- Fix documentation according to suggestions from Sylwester and Laurent.
- Don't allow creating new standard integer menu controls using
v4l2_ctrl_new_std_menu() since we don't have them yet.
Kind regards,
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
