Re: [RFC][PATCH 0/2] Sensor orientation reporting
Adam Baker wrote: On Monday 16 March 2009, Hans de Goede wrote: Both patches look good to me. A complaint about lack of documentation wouldn't have gone amiss. Er, good point. Regards, Hans Unfortunately having just remembered that I should have done that I'm struggling to get the current docbook to compile (So far I've suffered Ubuntu not packaging an old enough docbook, missing character set definition files and the Makefile depending on bash but not explicitly requesting it so getting dash). It looks like it now builds the docs so I'm ready to start updating them. Adam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH 0/2] Sensor orientation reporting
On Monday 16 March 2009, Hans de Goede wrote: Both patches look good to me. A complaint about lack of documentation wouldn't have gone amiss. Unfortunately having just remembered that I should have done that I'm struggling to get the current docbook to compile (So far I've suffered Ubuntu not packaging an old enough docbook, missing character set definition files and the Makefile depending on bash but not explicitly requesting it so getting dash). It looks like it now builds the docs so I'm ready to start updating them. Adam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC][PATCH 0/2] Sensor orientation reporting
Hi all, I've finally got round to writing a sample patch to support the proposed mechanism of reporting sensor orientation to user space. It is split into 2 parts, part 1 contains the kernel changes and part 2 the libv4l changes. In order to keep the patch simple I haven't attempted to add support to libv4l for HFLIP and VFLIP but just assumed for now that if a cam needs one then it needs both. If the basic idea gets accepted then fixing that is purely a user space change. I also haven't provided an implementation of VIDIOC_ENUMINPUT in libv4l that updates the flags to reflect what libv4l has done to the image. Hans Verkuil originally said he wanted to leave the orientation information available to the user app but I suspect that is actually undesirable. If an app is designed to work without libv4l and to re-orient an image as required then if someone runs it with the LD_PRELOAD capability of libv4l then correct operation depends upon reporting the corrected orientation to the app, not the original orientation. Adam -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
