Zhang, Xiaolin wrote:
> Hi linux-media,
>
> Current V4l2 only support 8 bit and 10 bit RAW Bayer Patten pixel format and
> this is a RFC to add 12 bit RAW Bay pixel format support by 4 more pixel
> format definition in videodev2.h.
> The 12 bit RAW Bayer Pattern pixel format is not a platform specific and is
> available in mainstream digital camera devices. It will be supported by the
> ISP on Intel Atom platform.
>
> The current 8 bit/10 bit RAW Bayer Pattern pixel format definitions are
> listed as in below,
>
> /* Bayer formats - see http://www.siliconimaging.com/RGB%20Bayer.htm */
> #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 BGBG..
> GRGR.. */
> #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 GBGB..
> RGRG.. */
> #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 GRGR..
> BGBG.. */
> #define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 RGRG..
> GBGB.. */
> #define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 BGBG..
> GRGR.. */
> #define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 GBGB..
> RGRG.. */
> #define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 GRGR..
> BGBG.. */
> #define V4L2_PIX_FMT_SRGGB10 v4l2_fourcc('R', 'G', '1', '0') /* 10 RGRG..
> GBGB.. */
>
> I am proposing to add 4 more pixel format definition in similar with existing
> ones listed as in below, welcome any comment and suggestion.
>
> #define V4L2_PIX_FMT_SBGGR12 v4l2_fourcc('B', 'G', '1', '2') /* 12 BGBG..
> GRGR.. */
> #define V4L2_PIX_FMT_SGBRG12 v4l2_fourcc('G', 'B', '1', '2') /* 12 GBGB..
> RGRG.. */
> #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12 GRGR..
> BGBG.. */
> #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12 RGRG..
> GBGB.. */
Seems ok to me. A few points to consider:
1) At the patch, you should also patch the V4L2 docbook files, to provide a
clean description
of those new formats;
2) Please submit this patch together with the patch series that adds a driver
using the new
formats;
3) Please send the patches to add support for those new formats also to
v4l-utils, in order to have
it properly supported on userspace.
>
> BRs
>
> BRs
> Xiaolin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
