[RFC 1/1] em28xx: fix configuration warning

2014-07-07 Thread Fabian Frederick
This patch tries to solve a problem detected with random configuration.
warning: (VIDEO_EM28XX_V4L2) selects VIDEO_MT9V011 which has unmet direct 
dependencies (MEDIA_SUPPORT  I2C  VIDEO_V4L2  MEDIA_CAMERA_SUPPORT)

Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/media/usb/em28xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig
index f5d7198..d42e1de 100644
--- a/drivers/media/usb/em28xx/Kconfig
+++ b/drivers/media/usb/em28xx/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_EM28XX
 config VIDEO_EM28XX_V4L2
tristate Empia EM28xx analog TV, video capture and/or webcam support
depends on VIDEO_EM28XX
+   depends on MEDIA_CAMERA_SUPPORT
select VIDEOBUF2_VMALLOC
select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT
-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC 1/1] em28xx: fix configuration warning

2014-07-07 Thread Mauro Carvalho Chehab
Hi Fabian,

Em Mon, 07 Jul 2014 20:51:55 +0200
Fabian Frederick f...@skynet.be escreveu:

 This patch tries to solve a problem detected with random configuration.
 warning: (VIDEO_EM28XX_V4L2) selects VIDEO_MT9V011 which has unmet direct 
 dependencies (MEDIA_SUPPORT  I2C  VIDEO_V4L2  MEDIA_CAMERA_SUPPORT)

The above warning is bogus. The thing is that em28xx driver can be
used by webcams, analog TV and/or digital TV.

No idea how to prevent Kbuild to complain about that.

Perhaps something like that will shut it up
depends on MEDIA_CAMERA_SUPPORT if MEDIA_CAMERA_SUPPORT

Regards,
Mauro

 
 Cc: Mauro Carvalho Chehab m.che...@samsung.com
 Cc: linux-media@vger.kernel.org
 Signed-off-by: Fabian Frederick f...@skynet.be
 ---
  drivers/media/usb/em28xx/Kconfig | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/media/usb/em28xx/Kconfig 
 b/drivers/media/usb/em28xx/Kconfig
 index f5d7198..d42e1de 100644
 --- a/drivers/media/usb/em28xx/Kconfig
 +++ b/drivers/media/usb/em28xx/Kconfig
 @@ -7,6 +7,7 @@ config VIDEO_EM28XX
  config VIDEO_EM28XX_V4L2
   tristate Empia EM28xx analog TV, video capture and/or webcam support
   depends on VIDEO_EM28XX
 + depends on MEDIA_CAMERA_SUPPORT
   select VIDEOBUF2_VMALLOC
   select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT
   select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html