Re: [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

[SF Markus Elfring]

> Could you make the commit summary shorter, to keep it
> below 70 characters [1]? With that changed feel free to add
> 
> Acked-by: Sylwester Nawrocki 
…
> [1] Documentation/process/submitting-patches.rst

Will it be sufficient that a patch committer will adjust
the summary phrase a bit?

Regards,
Markus

Re: [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

[Sylwester Nawrocki]

On 09/08/2017 10:51 PM, SF Markus Elfring wrote:

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring


Could you make the commit summary shorter, to keep it below 70
characters [1]? With that changed feel free to add

Acked-by: Sylwester Nawrocki 

--
Regards,
Sylwester

[1] Documentation/process/submitting-patches.rst

[PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

[SF Markus Elfring]

From: Markus Elfring 
Date: Fri, 8 Sep 2017 22:25:17 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c 
b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 1afde5021ca6..8af45d53846f 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1270,10 +1270,8 @@ static int s5p_mfc_probe(struct platform_device *pdev)
 
pr_debug("%s++\n", __func__);
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
-   if (!dev) {
-   dev_err(&pdev->dev, "Not enough memory for MFC device\n");
+   if (!dev)
return -ENOMEM;
-   }
 
spin_lock_init(&dev->irqlock);
spin_lock_init(&dev->condlock);
-- 
2.14.1