[patch] IR: ir-raw-event: null pointer dereference

2010-08-12 Thread Dan Carpenter
The original code dereferenced ir-raw after freeing it and setting it
to NULL.

Signed-off-by: Dan Carpenter erro...@gmail.com

diff --git a/drivers/media/IR/ir-raw-event.c b/drivers/media/IR/ir-raw-event.c
index 43094e7..8e0e1b1 100644
--- a/drivers/media/IR/ir-raw-event.c
+++ b/drivers/media/IR/ir-raw-event.c
@@ -279,9 +279,11 @@ int ir_raw_event_register(struct input_dev *input_dev)
rc%u,  (unsigned int)ir-devno);
 
if (IS_ERR(ir-raw-thread)) {
+   int ret = PTR_ERR(ir-raw-thread);
+
kfree(ir-raw);
ir-raw = NULL;
-   return PTR_ERR(ir-raw-thread);
+   return ret;
}
 
mutex_lock(ir_raw_handler_lock);
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [patch] IR: ir-raw-event: null pointer dereference

2010-08-12 Thread Jarod Wilson
- Dan Carpenter erro...@gmail.com wrote:
 The original code dereferenced ir-raw after freeing it and setting it
 to NULL.
 
 Signed-off-by: Dan Carpenter erro...@gmail.com


Acked-by: Jarod Wilson ja...@redhat.com


-- 
Jarod Wilson
ja...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html