Re: Add controls to query camera read only paramters

2014-11-10 Thread Guennadi Liakhovetski
Hi Bin,

On Sat, 8 Nov 2014, Bin Chen wrote:

 Hi Everyone,
 
 I need suggestions with regard to adding controls to query camera read
 only parameters (e.g maxZoom/maxExposureCompensation) as needed by
 Android Camera API[1].

I'm not sure all Android HAL metadata tags should be 1-to-1 implemented in 
V4L2. Some of them can be derived from existing information, some are even 
more relevant to the HAL, then to the camera (kernel driver). E.g. 
wouldn't it be possible and make sense to calculate 
android.scaler.availableMaxDigitalZoom camera cropping capabilities?

Thanks
Guennadi

 What is in my mind is to add a customized camera control ID for each
 parameter I want to query and return EACCES when being used wit
 VIDIOC_S_EXT_CTRLS.
 
 Or, I can port the compound controls [2] patch and then I only need to
 add one customized control ID.
 
 Comments? What is the better way to do this?
 
 [1] 
 http://developer.android.com/reference/android/hardware/Camera.Parameters.html
 [2]http://comments.gmane.org/gmane.comp.video.linuxtv.scm/19545
 
 -- 
 Regards,
 Bin
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Add controls to query camera read only paramters

2014-11-10 Thread Bin Chen
Hi Guennadi,

On 10 November 2014 19:46, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote:
 Hi Bin,

 On Sat, 8 Nov 2014, Bin Chen wrote:

 Hi Everyone,

 I need suggestions with regard to adding controls to query camera read
 only parameters (e.g maxZoom/maxExposureCompensation) as needed by
 Android Camera API[1].

 I'm not sure all Android HAL metadata tags should be 1-to-1 implemented in
 V4L2.

Yes, we won't need 1-1 mapping and I'm just trying to identify the
gaps and will add only those that are make sense.

 Some of them can be derived from existing information, some are even
 more relevant to the HAL, then to the camera (kernel driver).
We can do it in both places and the boundary is kind of blur, at least
for me:). Any guideline to follow? Putting them in driver maybe
reasonable in the sense that all hardware related information are put
together in one place - the driver. V4L2_CID_PIXEL_RATE is an example
in V4l2 to provide such read-only information.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Add controls to query camera read only paramters

2014-11-07 Thread Bin Chen
Hi Everyone,

I need suggestions with regard to adding controls to query camera read
only parameters (e.g maxZoom/maxExposureCompensation) as needed by
Android Camera API[1].

What is in my mind is to add a customized camera control ID for each
parameter I want to query and return EACCES when being used wit
VIDIOC_S_EXT_CTRLS.

Or, I can port the compound controls [2] patch and then I only need to
add one customized control ID.

Comments? What is the better way to do this?

[1] 
http://developer.android.com/reference/android/hardware/Camera.Parameters.html
[2]http://comments.gmane.org/gmane.comp.video.linuxtv.scm/19545

-- 
Regards,
Bin
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html