Re: Bug: media_build always compiles with '-DDEBUG'
Hi Mauro,
On Monday 20 June 2011 16:05:39 Mauro Carvalho Chehab wrote:
> Em 20-06-2011 10:38, Laurent Pinchart escreveu:
> > On Monday 20 June 2011 14:50:28 Mauro Carvalho Chehab wrote:
> >> Em 20-06-2011 09:35, Laurent Pinchart escreveu:
> >>> On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote:
> Em 19-06-2011 02:00, Helmut Auer escreveu:
> > Am 18.06.2011 23:38, schrieb Oliver Endriss:
> >> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote:
> >>> Hi
> >>>
> Replacing
>
> ifdef CONFIG_VIDEO_OMAP3_DEBUG
>
> by
>
> ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y)
>
> would do the trick.
> >>>
> >>> I guess that would not ive the intended result.
> >>> Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug
> >>> messages in all media modules,
> >>
> >> True, but it will happen only if you manually enable
> >> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig.
> >>
> >> You cannot avoid this without major changes of the
> >> media_build system - imho not worth the effort.
> >
> > Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG
> > variable completely, you can set CONFIG_DEBUG which would give the
> > same results.
>
> Good catch!
>
> Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG
> variable completely. If someone wants to build with -DDEBUG, he can
> just use CONFIG_DEBUG.
>
> Laurent,
>
> Any comments?
> >>>
> >>> CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug
> >>> mode, without having to compile the whole kernel with debugging
> >>> enabled. I'd like to keep that feature if possible.
> >>
> >> If you want that, build it using media_build. I don't care of having
> >> such hacks there, but having it upstream is not the right thing to do.
> >
> > It's not a hack. Lots of drivers have debugging Kconfig options.
> >
> > $ find linux-2.6 -type f -name Kconfig* -exec grep '^config.*DEBUG' {} \;
> > | wc
> >
> > 243 4865826
>
> Your query is wrong. The proper query is:
> $ find . -type f -name Makefile -exec grep -rH 'EXTRA_CFLAGS.*\-DDEBUG$' {}
> \; ./arch/x86/pci/Makefile:EXTRA_CFLAGS += -DDEBUG
> ./drivers/pps/generators/Makefile:EXTRA_CFLAGS += -DDEBUG
> ./drivers/media/video/omap3isp/Makefile:EXTRA_CFLAGS += -DDEBUG
>
> There's nothing wrong with a debug Kconfig option
> for omap3. What's wrong is:
>
> 1) It is badly implemented: it is just enabling -DDEBUG for the entire
> subsystem, as the test is wrong;
I'm fine with replacing 'ifdef CONFIG_VIDEO_OMAP3_DEBUG' with 'ifeq
($(CONFIG_VIDEO_OMAP3_DEBUG),y)'.
> 2) Even if you fix, you'll be enabling debug to the entire subsystem, if
> you keep adding things to EXTRA_CFLAGS.
That's the main issue. The Makefile has been designed for the kernel, where it
doesn't get merged in a single Makefile like media_build does. That's does a
media_build issue.
> It should be noticed that several places use a different syntax for
> enabling per-driver/per-subsystem -D flag:
>
> find . -type f -name Makefile -exec grep -rH '\-DDEBUG$' {} \;
> ...
> ./drivers/mmc/Makefile:subdir-ccflags-$(CONFIG_MMC_DEBUG) := -DDEBUG
> ...
> ./drivers/infiniband/hw/cxgb3/Makefile:ccflags-$(CONFIG_INFINIBAND_CXGB3_DE
> BUG) += -DDEBUG
>
> I _suspect_ that using ccflags-$(foo_DEBUG) may work.
I've seen that, but it doubt it will work better. v4l/Makefile.media will end
up containing
ccflags-$(CONFIG_VIDEO_OMAP3_DEBUG) += -DDEBUG
which will get expanded to
ccflags-y += -DDEBUG
All media_build drivers will thus be compiled with debugging enabled.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Em 20-06-2011 10:38, Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday 20 June 2011 14:50:28 Mauro Carvalho Chehab wrote:
>> Em 20-06-2011 09:35, Laurent Pinchart escreveu:
>>> On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote:
Em 19-06-2011 02:00, Helmut Auer escreveu:
> Am 18.06.2011 23:38, schrieb Oliver Endriss:
>> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote:
>>> Hi
>>>
Replacing
ifdef CONFIG_VIDEO_OMAP3_DEBUG
by
ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y)
would do the trick.
>>>
>>> I guess that would not ive the intended result.
>>> Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug
>>> messages in all media modules,
>>
>> True, but it will happen only if you manually enable
>> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig.
>>
>> You cannot avoid this without major changes of the
>> media_build system - imho not worth the effort.
>
> Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG
> variable completely, you can set CONFIG_DEBUG which would give the same
> results.
Good catch!
Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG
variable completely. If someone wants to build with -DDEBUG, he can just
use CONFIG_DEBUG.
Laurent,
Any comments?
>>>
>>> CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug
>>> mode, without having to compile the whole kernel with debugging enabled.
>>> I'd like to keep that feature if possible.
>>
>> If you want that, build it using media_build. I don't care of having such
>> hacks there, but having it upstream is not the right thing to do.
>
> It's not a hack. Lots of drivers have debugging Kconfig options.
>
> $ find linux-2.6 -type f -name Kconfig* -exec grep '^config.*DEBUG' {} \; | wc
> 243 4865826
Your query is wrong. The proper query is:
$ find . -type f -name Makefile -exec grep -rH 'EXTRA_CFLAGS.*\-DDEBUG$' {} \;
./arch/x86/pci/Makefile:EXTRA_CFLAGS += -DDEBUG
./drivers/pps/generators/Makefile:EXTRA_CFLAGS += -DDEBUG
./drivers/media/video/omap3isp/Makefile:EXTRA_CFLAGS += -DDEBUG
There's nothing wrong with a debug Kconfig option
for omap3. What's wrong is:
1) It is badly implemented: it is just enabling -DDEBUG for the entire
subsystem, as the test is wrong;
2) Even if you fix, you'll be enabling debug to the entire subsystem, if you
keep adding things to EXTRA_CFLAGS.
It should be noticed that several places use a different syntax for enabling
per-driver/per-subsystem -D flag:
find . -type f -name Makefile -exec grep -rH '\-DDEBUG$' {} \;
...
./drivers/mmc/Makefile:subdir-ccflags-$(CONFIG_MMC_DEBUG) := -DDEBUG
...
./drivers/infiniband/hw/cxgb3/Makefile:ccflags-$(CONFIG_INFINIBAND_CXGB3_DEBUG)
+= -DDEBUG
I _suspect_ that using ccflags-$(foo_DEBUG) may work.
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Hi Mauro,
On Monday 20 June 2011 14:50:28 Mauro Carvalho Chehab wrote:
> Em 20-06-2011 09:35, Laurent Pinchart escreveu:
> > On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote:
> >> Em 19-06-2011 02:00, Helmut Auer escreveu:
> >>> Am 18.06.2011 23:38, schrieb Oliver Endriss:
> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote:
> > Hi
> >
> >> Replacing
> >>
> >> ifdef CONFIG_VIDEO_OMAP3_DEBUG
> >>
> >> by
> >>
> >> ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y)
> >>
> >> would do the trick.
> >
> > I guess that would not ive the intended result.
> > Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug
> > messages in all media modules,
>
> True, but it will happen only if you manually enable
> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig.
>
> You cannot avoid this without major changes of the
> media_build system - imho not worth the effort.
> >>>
> >>> Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG
> >>> variable completely, you can set CONFIG_DEBUG which would give the same
> >>> results.
> >>
> >> Good catch!
> >>
> >> Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG
> >> variable completely. If someone wants to build with -DDEBUG, he can just
> >> use CONFIG_DEBUG.
> >>
> >> Laurent,
> >>
> >> Any comments?
> >
> > CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug
> > mode, without having to compile the whole kernel with debugging enabled.
> > I'd like to keep that feature if possible.
>
> If you want that, build it using media_build. I don't care of having such
> hacks there, but having it upstream is not the right thing to do.
It's not a hack. Lots of drivers have debugging Kconfig options.
$ find linux-2.6 -type f -name Kconfig* -exec grep '^config.*DEBUG' {} \; | wc
243 4865826
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Em 20-06-2011 09:35, Laurent Pinchart escreveu: > Hi Mauro, > > On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote: >> Em 19-06-2011 02:00, Helmut Auer escreveu: >>> Am 18.06.2011 23:38, schrieb Oliver Endriss: On Saturday 18 June 2011 23:11:21 Helmut Auer wrote: > Hi > >> Replacing >> >> ifdef CONFIG_VIDEO_OMAP3_DEBUG >> >> by >> >> ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) >> >> would do the trick. > > I guess that would not ive the intended result. > Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug > messages in all media modules, True, but it will happen only if you manually enable CONFIG_VIDEO_OMAP3_DEBUG in Kconfig. You cannot avoid this without major changes of the media_build system - imho not worth the effort. >>> >>> Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG >>> variable completely, you can set CONFIG_DEBUG which would give the same >>> results. >> >> Good catch! >> >> Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG >> variable completely. If someone wants to build with -DDEBUG, he can just >> use CONFIG_DEBUG. >> >> Laurent, >> >> Any comments? > > CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug mode, > without having to compile the whole kernel with debugging enabled. I'd like > to > keep that feature if possible. If you want that, build it using media_build. I don't care of having such hacks there, but having it upstream is not the right thing to do. Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Hi Mauro, On Sunday 19 June 2011 13:47:16 Mauro Carvalho Chehab wrote: > Em 19-06-2011 02:00, Helmut Auer escreveu: > > Am 18.06.2011 23:38, schrieb Oliver Endriss: > >> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote: > >>> Hi > >>> > Replacing > > ifdef CONFIG_VIDEO_OMAP3_DEBUG > > by > > ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) > > would do the trick. > >>> > >>> I guess that would not ive the intended result. > >>> Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug > >>> messages in all media modules, > >> > >> True, but it will happen only if you manually enable > >> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig. > >> > >> You cannot avoid this without major changes of the > >> media_build system - imho not worth the effort. > > > > Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG > > variable completely, you can set CONFIG_DEBUG which would give the same > > results. > > Good catch! > > Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG > variable completely. If someone wants to build with -DDEBUG, he can just > use CONFIG_DEBUG. > > Laurent, > > Any comments? CONFIG_VIDEO_OMAP3_DEBUG is used to build the OMAP3 ISP driver in debug mode, without having to compile the whole kernel with debugging enabled. I'd like to keep that feature if possible. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Em 19-06-2011 02:00, Helmut Auer escreveu: > Am 18.06.2011 23:38, schrieb Oliver Endriss: >> On Saturday 18 June 2011 23:11:21 Helmut Auer wrote: >>> Hi Replacing ifdef CONFIG_VIDEO_OMAP3_DEBUG by ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) would do the trick. >>> I guess that would not ive the intended result. >>> Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug messages >>> in all media modules, >> >> True, but it will happen only if you manually enable >> CONFIG_VIDEO_OMAP3_DEBUG in Kconfig. >> >> You cannot avoid this without major changes of the >> media_build system - imho not worth the effort. >> > Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG variable > completely, you can set CONFIG_DEBUG which would give the same results. Good catch! Yes, I agree that the better is to just drop CONFIG_VIDEO_OMAP3_DEBUG variable completely. If someone wants to build with -DDEBUG, he can just use CONFIG_DEBUG. Laurent, Any comments? Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Am 18.06.2011 23:38, schrieb Oliver Endriss: On Saturday 18 June 2011 23:11:21 Helmut Auer wrote: Hi Replacing ifdef CONFIG_VIDEO_OMAP3_DEBUG by ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) would do the trick. I guess that would not ive the intended result. Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug messages in all media modules, True, but it will happen only if you manually enable CONFIG_VIDEO_OMAP3_DEBUG in Kconfig. You cannot avoid this without major changes of the media_build system - imho not worth the effort. Then imho it would be better to drop the CONFIG_VIDEO_OMAP3_DEBUG variable completely, you can set CONFIG_DEBUG which would give the same results. Bye Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
On Saturday 18 June 2011 23:11:21 Helmut Auer wrote: > Hi > > > > Replacing > > ifdef CONFIG_VIDEO_OMAP3_DEBUG > > by > > ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) > > would do the trick. > > > I guess that would not ive the intended result. > Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug messages in > all media modules, True, but it will happen only if you manually enable CONFIG_VIDEO_OMAP3_DEBUG in Kconfig. You cannot avoid this without major changes of the media_build system - imho not worth the effort. CU Oliver -- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Bug: media_build always compiles with '-DDEBUG'
Hi Replacing ifdef CONFIG_VIDEO_OMAP3_DEBUG by ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) would do the trick. I guess that would not ive the intended result. Setting CONFIG_VIDEO_OMAP3_DEBUG to yes should not lead to debug messages in all media modules, Bye Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Bug: media_build always compiles with '-DDEBUG'
Hi Mauro, bug is triggered by the code block ifdef CONFIG_VIDEO_OMAP3_DEBUG EXTRA_CFLAGS += -DDEBUG endif from media/video/omap3isp/Makefile, which is part of Makefile.media. The expression above is always true, as make_myconfig.pl initialises boolean options to 'n', i.e. CONFIG_VIDEO_OMAP3_DEBUG := n As a result, EXTRA_CFLAGS contains -DDEBUG. So either make_myconfig.pl or omap3isp/Makefile must be fixed. Replacing ifdef CONFIG_VIDEO_OMAP3_DEBUG by ifeq ($(CONFIG_VIDEO_OMAP3_DEBUG),y) would do the trick. Thanks to Helmut Auer for reporting the bug. CU Oliver VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
