Can the patch adding support for the Tasco USB microscope be queued up?
Hi, as an owner of a Tasco/Aveo USB microscope detected but not working under Linux, I'd really like to see the patch adding this variant added to the kernel. I've copied the patch's author on the email. The people on the linux-uvc-devel list directed me over here. The patch here: http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself an update of an earlier patch: http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. The patch does make the USB microscope work where it didn't work at all before. Thank you! -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
This is now the 3rd or 4th email to this list requesting that this patch be merged in. If there is something wrong with the patch that needs fixing, please let me know and I will work on the fix. Otherwise I've lost interest in pushing to get it into upstream. Michael Hall mhall...@gmail.com On 02/16/2015 10:08 AM, Steven Zakulec wrote: > Hi, as an owner of a Tasco/Aveo USB microscope detected but not > working under Linux, I'd really like to see the patch adding this > variant added to the kernel. I've copied the patch's author on the > email. > The people on the linux-uvc-devel list directed me over here. > > The patch here: > http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself > an update of an earlier patch: > http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. > The patch does make the USB microscope work where it didn't work at all > before. > > Thank you! > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
On 02/16/2015 04:31 PM, Michael Hall wrote: > This is now the 3rd or 4th email to this list requesting that this patch > be merged in. If there is something wrong with the patch that needs > fixing, please let me know and I will work on the fix. Otherwise I've > lost interest in pushing to get it into upstream. I can't remember ever seeing a patch for that posted to the linux-media mailinglist. The best way is just to post the patch to this mailinglist, check that it appears in patchwork (https://patchwork.linuxtv.org/project/linux-media/list/), make sure you keep the author and correct Signed-off-by line and it's *guaranteed* that someone will look at it, and merge it or reply to it if there are problems. Mails like 'please pick up a patch from some other git repo' are very likely to be forgotten due to volume of other postings. Patchwork won't pick them up and that's what we all rely on. So if either of you can just post this as a properly formatted patch, then it will be taken care of. Regards, Hans > > Michael Hall > mhall...@gmail.com > > On 02/16/2015 10:08 AM, Steven Zakulec wrote: >> Hi, as an owner of a Tasco/Aveo USB microscope detected but not >> working under Linux, I'd really like to see the patch adding this >> variant added to the kernel. I've copied the patch's author on the >> email. >> The people on the linux-uvc-devel list directed me over here. >> >> The patch here: >> http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself >> an update of an earlier patch: >> http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. >> The patch does make the USB microscope work where it didn't work at all >> before. >> >> Thank you! >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
My apologies, the other emails were sent to linux-uvc-devel, not linux-media. Do you want an attached patch file, or simply a diff in the body of the email? I'm also not clear on what you mean by "correct Signed-off-by line", I have very little experience with git, I've mostly used bzr. Michael Hall mhall...@gmail.com On 02/16/2015 10:40 AM, Hans Verkuil wrote: > On 02/16/2015 04:31 PM, Michael Hall wrote: >> This is now the 3rd or 4th email to this list requesting that this patch >> be merged in. If there is something wrong with the patch that needs >> fixing, please let me know and I will work on the fix. Otherwise I've >> lost interest in pushing to get it into upstream. > > I can't remember ever seeing a patch for that posted to the linux-media > mailinglist. > > The best way is just to post the patch to this mailinglist, check that it > appears in patchwork > (https://patchwork.linuxtv.org/project/linux-media/list/), > make sure you keep the author and correct Signed-off-by line and it's > *guaranteed* that someone will look at it, and merge it or reply to it > if there are problems. > > Mails like 'please pick up a patch from some other git repo' are very > likely to be forgotten due to volume of other postings. Patchwork won't > pick them up and that's what we all rely on. > > So if either of you can just post this as a properly formatted patch, > then it will be taken care of. > > Regards, > > Hans > >> >> Michael Hall >> mhall...@gmail.com >> >> On 02/16/2015 10:08 AM, Steven Zakulec wrote: >>> Hi, as an owner of a Tasco/Aveo USB microscope detected but not >>> working under Linux, I'd really like to see the patch adding this >>> variant added to the kernel. I've copied the patch's author on the >>> email. >>> The people on the linux-uvc-devel list directed me over here. >>> >>> The patch here: >>> http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself >>> an update of an earlier patch: >>> http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. >>> The patch does make the USB microscope work where it didn't work at all >>> before. >>> >>> Thank you! >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
On 02/16/2015 05:01 PM, Michael Hall wrote: > My apologies, the other emails were sent to linux-uvc-devel, not > linux-media. > > Do you want an attached patch file, or simply a diff in the body of the > email? I'm also not clear on what you mean by "correct Signed-off-by > line", I have very little experience with git, I've mostly used bzr. This is a good link with the relevant information: http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches Anyway, I checked where the original patch came from, and Laurent Pinchart wrote it. Since he's kernel maintainer he knows all about well-formatted patches and it's best if he just posts and merges his own patch :-) Laurent, it's all yours! Regards, Hans > > Michael Hall > mhall...@gmail.com > > On 02/16/2015 10:40 AM, Hans Verkuil wrote: >> On 02/16/2015 04:31 PM, Michael Hall wrote: >>> This is now the 3rd or 4th email to this list requesting that this patch >>> be merged in. If there is something wrong with the patch that needs >>> fixing, please let me know and I will work on the fix. Otherwise I've >>> lost interest in pushing to get it into upstream. >> >> I can't remember ever seeing a patch for that posted to the linux-media >> mailinglist. >> >> The best way is just to post the patch to this mailinglist, check that it >> appears in patchwork >> (https://patchwork.linuxtv.org/project/linux-media/list/), >> make sure you keep the author and correct Signed-off-by line and it's >> *guaranteed* that someone will look at it, and merge it or reply to it >> if there are problems. >> >> Mails like 'please pick up a patch from some other git repo' are very >> likely to be forgotten due to volume of other postings. Patchwork won't >> pick them up and that's what we all rely on. >> >> So if either of you can just post this as a properly formatted patch, >> then it will be taken care of. >> >> Regards, >> >> Hans >> >>> >>> Michael Hall >>> mhall...@gmail.com >>> >>> On 02/16/2015 10:08 AM, Steven Zakulec wrote: Hi, as an owner of a Tasco/Aveo USB microscope detected but not working under Linux, I'd really like to see the patch adding this variant added to the kernel. I've copied the patch's author on the email. The people on the linux-uvc-devel list directed me over here. The patch here: http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself an update of an earlier patch: http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. The patch does make the USB microscope work where it didn't work at all before. Thank you! >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
Hi Hans, On Monday 16 February 2015 17:08:52 Hans Verkuil wrote: > On 02/16/2015 05:01 PM, Michael Hall wrote: > > My apologies, the other emails were sent to linux-uvc-devel, not > > linux-media. > > > > Do you want an attached patch file, or simply a diff in the body of the > > email? I'm also not clear on what you mean by "correct Signed-off-by > > line", I have very little experience with git, I've mostly used bzr. > > This is a good link with the relevant information: > > http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches > > Anyway, I checked where the original patch came from, and Laurent Pinchart > wrote it. Since he's kernel maintainer he knows all about well-formatted > patches and it's best if he just posts and merges his own patch :-) > > Laurent, it's all yours! I've sent the patch to linux-media and will include it in my next uvcvideo pull request. Steven, could you please send me the output of lsusb -v -d '1871:0516' (if possible running as root) on your system ? > > On 02/16/2015 10:40 AM, Hans Verkuil wrote: > >> On 02/16/2015 04:31 PM, Michael Hall wrote: > >>> This is now the 3rd or 4th email to this list requesting that this patch > >>> be merged in. If there is something wrong with the patch that needs > >>> fixing, please let me know and I will work on the fix. Otherwise I've > >>> lost interest in pushing to get it into upstream. > >> > >> I can't remember ever seeing a patch for that posted to the linux-media > >> mailinglist. > >> > >> The best way is just to post the patch to this mailinglist, check that it > >> appears in patchwork > >> (https://patchwork.linuxtv.org/project/linux-media/list/), make sure you > >> keep the author and correct Signed-off-by line and it's *guaranteed* > >> that someone will look at it, and merge it or reply to it if there are > >> problems. > >> > >> Mails like 'please pick up a patch from some other git repo' are very > >> likely to be forgotten due to volume of other postings. Patchwork won't > >> pick them up and that's what we all rely on. > >> > >> So if either of you can just post this as a properly formatted patch, > >> then it will be taken care of. > >> > >> Regards, > >> > >>Hans > >> > >>> Michael Hall > >>> mhall...@gmail.com > >>> > >>> On 02/16/2015 10:08 AM, Steven Zakulec wrote: > Hi, as an owner of a Tasco/Aveo USB microscope detected but not > working under Linux, I'd really like to see the patch adding this > variant added to the kernel. I've copied the patch's author on the > email. The people on the linux-uvc-devel list directed me over here. > > The patch here: > http://sourceforge.net/p/linux-uvc/mailman/message/32434617/ , itself > an update of an earlier patch: > http://sourceforge.net/p/linux-uvc/mailman/message/29835445/ works. > The patch does make the USB microscope work where it didn't work at all > before. > > Thank you! -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can the patch adding support for the Tasco USB microscope be queued up?
Here are the results of running lsusb -v -d '1871:0516' on my system
that has the patch applied:
Thanks for your help here!
Bus 001 Device 104: ID 1871:0516 Aveo Technology Corp.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize064
idVendor 0x1871 Aveo Technology Corp.
idProduct 0x0516
bcdDevice3.07
iManufacturer 1 AVEO Technology Corp.
iProduct2 USB2.0 Camera
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 411
bNumInterfaces 2
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 500mA
Interface Association:
bLength 8
bDescriptorType11
bFirstInterface 0
bInterfaceCount 2
bFunctionClass255 Vendor Specific Class
bFunctionSubClass 3
bFunctionProtocol 0
iFunction 2 USB2.0 Camera
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber0
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 1
bInterfaceProtocol 0
iInterface 2 USB2.0 Camera
** UNRECOGNIZED: 0d 24 01 00 01 4d 00 80 c3 c9 01 01 01
** UNRECOGNIZED: 12 24 02 01 01 02 00 00 00 00 00 00 00 00 03 00 00 00
** UNRECOGNIZED: 09 24 03 02 01 01 00 04 00
** UNRECOGNIZED: 0b 24 05 03 01 00 00 02 1b 04 00
** UNRECOGNIZED: 1a 24 06 04 52 f2 b8 aa d1 8e 72 49 8c ed 96
b1 7f 04 40 8b 01 01 03 01 03 00
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes3
Transfer TypeInterrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 7
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber1
bAlternateSetting 0
bNumEndpoints 0
bInterfaceClass14 Video
bInterfaceSubClass 2 Video Streaming
bInterfaceProtocol 0
iInterface 0
VideoStreaming Interface Descriptor:
bLength14
bDescriptorType36
bDescriptorSubtype 1 (INPUT_HEADER)
bNumFormats 1
wTotalLength 207
bEndPointAddress 131
bmInfo 0
bTerminalLink 2
bStillCaptureMethod 2
bTriggerSupport 1
bTriggerUsage 0
bControlSize1
bmaControls( 0)27
VideoStreaming Interface Descriptor:
bLength27
bDescriptorType36
bDescriptorSubtype 4 (FORMAT_UNCOMPRESSED)
bFormatIndex1
bNumFrameDescriptors5
guidFormat
{59555932--1000-8000-00aa00389b71}
bBitsPerPixel 16
bDefaultFrameIndex 1
bAspectRatioX 0
bAspectRatioY 0
bmInterlaceFlags 0x00
Interlaced stream or variable: No
Fields per frame: 2 fields
Field 1 first: No
Field pattern: Field 1 only
bCopyProtect 0
VideoStreaming Interface Descriptor:
bLength30
bDescriptorType36
bDescriptorSubtype 5 (FRAME_UNCOMPRESSED)
bFrameIndex 1
bmCapabilities 0x00
Still image unsupported
wWidth640
wHeight 480
dwMinBitRate147456000
dwMaxBitRate147456000
dwMaxVideoFrameBufferSize 614400
dwDefaultFrameInterval 33
bFrameIntervalType 1
dwFrameInterval( 0)33
VideoStreaming Interface Descriptor:
bLength30
bDescriptorType36
bDescript
Re: Can the patch adding support for the Tasco USB microscope be queued up?
Hi Steven, On Wednesday 18 February 2015 21:47:58 Steven Zakulec wrote: > Here are the results of running lsusb -v -d '1871:0516' on my system > that has the patch applied: Thank you. > Thanks for your help here! You're welcome. I'll include the device support patch in my v4.1 pull request. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
