Re: Firmware blob in vs6624 driver

[Scott Jiang]

Hi Ben,

 This doesn't touch any of the documented registers, so presumably it's a
 patch to the firmware loaded from non-volatile memory.  Unless you can
 provide source code for the patch, this should go in the linux-firmware
 repository and be loaded with request_firmware() instead of embedded in
 the GPL driver source.
Sounds reasonable.

 Also, shouldn't you check the loaded firmware version first to verify
 that it's safe to apply the patch?
The problem is you can't get version before power up device but you
should apply patch at that time.

Scott
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Firmware blob in vs6624 driver

[Ben Hutchings]

The array vs6624_p1 is a list of bytes to write to the VS6624's
microcontroller registers/memory, written before it starts running code:

vs6624_writeregs(sd, vs6624_p1);
vs6624_write(sd, VS6624_MICRO_EN, 0x2);
vs6624_write(sd, VS6624_DIO_EN, 0x1);
mdelay(10);

This doesn't touch any of the documented registers, so presumably it's a
patch to the firmware loaded from non-volatile memory.  Unless you can
provide source code for the patch, this should go in the linux-firmware
repository and be loaded with request_firmware() instead of embedded in
the GPL driver source.

Also, shouldn't you check the loaded firmware version first to verify
that it's safe to apply the patch?

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?


signature.asc
Description: This is a digitally signed message part