Re: HDMI and Composite capture on Lager, for kernel 4.1, version 3
On 06/22/2015 04:41 PM, William Towle wrote: Hi Hans, I'm not sure if I've asked this before, but shouldn't soc-camera be extended with support for the DV_TIMINGS ioctls in order to control the adv7604? It's peculiar that that is not included in this patch series... Rob tells me he did some work on this, but we don't have it passing muster with v4l2-compliance and since gstreamer tries a number of resolutions of its own accord and subsequently produces images and video without it we can make do without for our needs. I can include it in or alongside the next submission if you'd to see it. Another reason not to use soc-camera. It's really not a very suitable framework for this hardware. Regarding your other comments, in particular the specification of the following: .tdms_lock_mask = 0x43, .cable_det_mask = 0x01, ...when testing just the first input, these seem reasonable - in the case of tdms_lock_mask the two least significant bits represent V_LOCKED_RAW and DE_REGEN_LCK_RAW, and they are set in line with the value of TDMSPLL_LCK_A_RAW when queried. While an implementation suitable for testing both of the ADV7612's A and B inputs could just add TDMSPLL_LCK_B_RAW to tdms_lock mask, the cable detect function isn't so trivial: it would need to query two separate (and numerically non-adjacent) registers to do its job. For simplicity we would like to propose that our next iteration supports just the first input (which is sufficient for our current needs) and has commentary in appropriate places regarding its shortcomings, although we're open to alternative suggestions if there has already been discussion on the matter here. I think supporting just the first input and commenting accordingly is the best approach for now. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in
Re: HDMI and Composite capture on Lager, for kernel 4.1, version 3
Hi Hans, I'm not sure if I've asked this before, but shouldn't soc-camera be extended with support for the DV_TIMINGS ioctls in order to control the adv7604? It's peculiar that that is not included in this patch series... Rob tells me he did some work on this, but we don't have it passing muster with v4l2-compliance and since gstreamer tries a number of resolutions of its own accord and subsequently produces images and video without it we can make do without for our needs. I can include it in or alongside the next submission if you'd to see it. Regarding your other comments, in particular the specification of the following: .tdms_lock_mask = 0x43, .cable_det_mask = 0x01, ...when testing just the first input, these seem reasonable - in the case of tdms_lock_mask the two least significant bits represent V_LOCKED_RAW and DE_REGEN_LCK_RAW, and they are set in line with the value of TDMSPLL_LCK_A_RAW when queried. While an implementation suitable for testing both of the ADV7612's A and B inputs could just add TDMSPLL_LCK_B_RAW to tdms_lock mask, the cable detect function isn't so trivial: it would need to query two separate (and numerically non-adjacent) registers to do its job. For simplicity we would like to propose that our next iteration supports just the first input (which is sufficient for our current needs) and has commentary in appropriate places regarding its shortcomings, although we're open to alternative suggestions if there has already been discussion on the matter here. Cheers, Wills. -- To unsubscribe from this list: send the line unsubscribe linux-media in
Re: HDMI and Composite capture on Lager, for kernel 4.1, version 3
On 06/03/2015 03:59 PM, William Towle wrote: Version 3. Obsoletes version 2, as seen at: http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/91668 Key changes in this version: this has some reworking of the adv7604 driver probe and soc_camera initialisation functions. In addition, we give rcar_vin.c a dependency on CONFIG_MEDIA_CONTROLLER in line with the drivers used with it. I'm not sure if I've asked this before, but shouldn't soc-camera be extended with support for the DV_TIMINGS ioctls in order to control the adv7604? It's peculiar that that is not included in this patch series... Regards, Hans Cheers, Wills. To follow: [PATCH 01/15] ARM: shmobile: lager dts: Add entries for VIN HDMI [PATCH 02/15] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 [PATCH 03/15] media: adv7180: add of match table [PATCH 04/15] media: adv7604: chip info and formats for ADV7612 [PATCH 05/15] media: adv7604: document support for ADV7612 dual HDMI [PATCH 06/15] media: adv7604: ability to read default input port [PATCH 07/15] ARM: shmobile: lager dts: specify default-input for [PATCH 08/15] v4l: subdev: Add pad config allocator and init [PATCH 09/15] media: soc_camera pad-aware driver initialisation [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt [PATCH 11/15] media: soc_camera: soc_scale_crop: Use correct pad [PATCH 12/15] media: soc_camera: Fill std field in enum_input [PATCH 13/15] media: soc_camera: Fix error reporting in expbuf [PATCH 14/15] media: soc_camera: fill in bus_info field [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in
HDMI and Composite capture on Lager, for kernel 4.1, version 3
Version 3. Obsoletes version 2, as seen at: http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/91668 Key changes in this version: this has some reworking of the adv7604 driver probe and soc_camera initialisation functions. In addition, we give rcar_vin.c a dependency on CONFIG_MEDIA_CONTROLLER in line with the drivers used with it. Cheers, Wills. To follow: [PATCH 01/15] ARM: shmobile: lager dts: Add entries for VIN HDMI [PATCH 02/15] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 [PATCH 03/15] media: adv7180: add of match table [PATCH 04/15] media: adv7604: chip info and formats for ADV7612 [PATCH 05/15] media: adv7604: document support for ADV7612 dual HDMI [PATCH 06/15] media: adv7604: ability to read default input port [PATCH 07/15] ARM: shmobile: lager dts: specify default-input for [PATCH 08/15] v4l: subdev: Add pad config allocator and init [PATCH 09/15] media: soc_camera pad-aware driver initialisation [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt [PATCH 11/15] media: soc_camera: soc_scale_crop: Use correct pad [PATCH 12/15] media: soc_camera: Fill std field in enum_input [PATCH 13/15] media: soc_camera: Fix error reporting in expbuf [PATCH 14/15] media: soc_camera: fill in bus_info field [PATCH 15/15] media: rcar_vin: Reject videobufs that are too small -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
