RE: [PATCH] s5p-mfc: correct the formats info for encoder
I am very sorry to forget the Sign-off again and thank you for reviewing. ayaka (1): s5p-mfc: correct the formats info for encoder drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] s5p-mfc: correct the formats info for encoder
Hi Ayaka, Could you resend this patch with your sign-off? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: ayaka [mailto:ay...@soulik.info] > Sent: Wednesday, July 23, 2014 6:15 PM > To: linux-media@vger.kernel.org > Cc: kyungmin.p...@samsung.com; k.deb...@samsung.com; > jtp.p...@samsung.com; m.che...@samsung.com; ayaka > Subject: [PATCH] s5p-mfc: correct the formats info for encoder > > The NV12M is supported by all the version of MFC, so it is better to > use it as default OUTPUT format. > MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is > not supported either. > --- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > index d26b248..4ea3796 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > @@ -32,7 +32,7 @@ > #include "s5p_mfc_intr.h" > #include "s5p_mfc_opr.h" > > -#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT > +#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M > #define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264 > > static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static > struct s5p_mfc_fmt formats[] = { > .codec_mode = S5P_MFC_CODEC_NONE, > .type = MFC_FMT_RAW, > .num_planes = 2, > - .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT | > - MFC_V8_BIT, > + .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT, > }, > { > .name = "H264 Encoded Stream", > -- > 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] s5p-mfc: correct the formats info for encoder
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 2014/09/23 00:28, Kamil Debski wrote: > Hi Ayaka, > > Sorry for such a late reply - I just noticed this patch. > >> The NV12M is supported by all the version of MFC, so it is better >> to use it as default OUTPUT format. MFC v5 doesn't support NV21, >> I have tested it, for the SEC doc it is not supported either. > > A proper Sign-off is missing here. > Sorry to miss it again. > According to the documentation of MFC v5 I have non-tiled format > is supported. Which documentation were you looking at? > But the V4L2_PIX_FMT_NV12MT is only supported by MFC_V5_BIT from your code, V4L2_PIX_FMT_NV12M is supported by all the version. >> From my documentation: > ++ ENC_MAP_FOR_CUR0xC51C Memory structure setting > register of the current frame.R/W 0x > > Bits NameDescription Reset Value [31:2] RESERVED > Reserved0 [1:0] > ENC_MAP_FOR_CUR Memory structure of the current frame 0 : Linear > mode 3 : 64x32 tiled mode 0 ++ > In the page 2277. The same result. I think the V4L2_PIX_FMT_NV12MT is 64x32 Tiles mode, but what I remove for MFC v5 is V4L2_PIX_FMT_NV21M. > Best wishes, > - -- ayaka -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJUIFNLAAoJEPsGh4kgR4i5HcIP/2qwn7uIFq66qpSajXmtcLx3 3/wt8n26u6GhTMUnIJKZS07FGtv7qizUVqeY3WmfWQw3jLaUjZeVviVH08y3DrE8 +7Vjq2rxz57ou4bBtc4qIgTWB7z2yuVSpBOYUB94laItQ7KDap4EgLf89m4KaKTt 5nULR0byxXh+RuUOw80v0eP/TBz7SRfYZnulASV9QlGS6T3Xp6v4U6W8LbSbieR5 63PwPxYP7aDVb5R6qzaLIVXNuI53vn5VhrQ6JJUfKee5YSbkV/Ff6XK+7/P162Pn 5cVt06X+RUeZXHGqCroMNb9cdm+7JHOZL458NPn4NmTJnFcPNu6JzW9iLymHeHC8 iFmNhpDuHJBulKsW44lqKe1fHT22a5C/oJAI1ZS9c3yrH+TqHkfEkUJjglSRByzj ptTFFZVTCdiL5VwnDlfowR4ZzrkZuoWzHIn5cGeHogvbLbxCbtV67+IFpWlXfyJu rKnCI+DKYb5cjEiHm7kzGbAO04AfNMT79sNwrD+sPuvnaFyRiy2rjKv3ubnPFRVp 3agNRzAcCgmsW3K10P3ism4ceJUqeZtFvieCQrjiQdxj8EB7QAcgOhgn3K//zrQ1 mQP7xuVQcwpaRIOx/3jSlVWYFrkFs2+tmgS9oEn+v40gXOQXk8rML21gHvpDuCnf qJXx0UVYQRV7Bhgv8EFW =SNTL -END PGP SIGNATURE- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] s5p-mfc: correct the formats info for encoder
Hi Ayaka, Sorry for such a late reply - I just noticed this patch. > From: ayaka [mailto:ay...@soulik.info] > Sent: Wednesday, July 23, 2014 6:15 PM > To: linux-media@vger.kernel.org > Cc: kyungmin.p...@samsung.com; k.deb...@samsung.com; > jtp.p...@samsung.com; m.che...@samsung.com; ayaka > Subject: [PATCH] s5p-mfc: correct the formats info for encoder > > The NV12M is supported by all the version of MFC, so it is better to > use it as default OUTPUT format. > MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is > not supported either. A proper Sign-off is missing here. According to the documentation of MFC v5 I have non-tiled format is supported. Which documentation were you looking at? >From my documentation: ++ ENC_MAP_FOR_CUR 0xC51C Memory structure setting register of the current frame. R/W 0x BitsNameDescription Reset Value [31:2] RESERVEDReserved0 [1:0] ENC_MAP_FOR_CUR Memory structure of the current frame 0 : Linear mode 3 : 64x32 tiled mode0 ++ Best wishes, -- Kamil Debski Samsung R&D Institute Poland > --- > drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > index d26b248..4ea3796 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c > @@ -32,7 +32,7 @@ > #include "s5p_mfc_intr.h" > #include "s5p_mfc_opr.h" > > -#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT > +#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M > #define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264 > > static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static > struct s5p_mfc_fmt formats[] = { > .codec_mode = S5P_MFC_CODEC_NONE, > .type = MFC_FMT_RAW, > .num_planes = 2, > - .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT | > - MFC_V8_BIT, > + .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT, > }, > { > .name = "H264 Encoded Stream", > -- > 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html