Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
--- On Mon, 4/20/09, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab
> Subject: Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
> To: "Uri Shkolnik"
> Cc: "LinuxML"
> Date: Monday, April 20, 2009, 8:14 PM
> On Mon, 20 Apr 2009 09:56:26 -0700
> (PDT)
> Uri Shkolnik
> wrote:
>
> >
> >
> >
> > --- On Mon, 4/20/09, Mauro Carvalho Chehab
> wrote:
> >
> > > From: Mauro Carvalho Chehab
> > > Subject: Re: [PATCH] [0904_10] Siano: smsdvb -
> add events mechanism
> > > To: "Uri Shkolnik"
> > > Cc: "LinuxML"
> > > Date: Monday, April 20, 2009, 7:21 PM
> > > On Sun, 5 Apr 2009 03:18:01 -0700
> > > (PDT)
> > > Uri Shkolnik
> > > wrote:
> > >
> > > >
> > > > # HG changeset patch
> > > > # User Uri Shkolnik
> > > > # Date 1238742622 -10800
> > > > # Node ID
> ec7ee486fb86d51bdb48e6a637a6ddd52e9e08c2
> > > > # Parent
> > > 020ba7b31c963bd36d607848198e9e4258a6f80e
> > > > [PATCH] [0904_10] Siano: smsdvb - add
> events
> > > mechanism
> > > >
> > > > From: Uri Shkolnik
> > > >
> > > > Add events mechanism that will notify the
> "cards"
> > > component
> > > > (which represent the specific hardware
> target) for DVB
> > > related
> > > > events.
> > >
> > >
> > > This patch contains unrelated coding style fixes.
> Some of
> > > them seem to be
> > > related to previous changesets not applied.
> > >
> > > It is better to split coding style and real
> changes into
> > > separate patches.
> > >
> > > > +/* Events that may come from DVB v3 adapter
> */
> > > > +static void sms_board_dvb3_event(struct
> > > smscore_device_t *coredev,
> > > > + enum
> > > SMS_DVB3_EVENTS event) {
> > > > + switch (event) {
> > > > + case DVB3_EVENT_INIT:
> > > > +
> > > sms_debug("DVB3_EVENT_INIT");
> > > > + /*
> > > sms_board_event(coredev, BOARD_EVENT_BIND); */
> > > > + break;
> > > > + case DVB3_EVENT_SLEEP:
> > > > +
> > > sms_debug("DVB3_EVENT_SLEEP");
> > > > + /*
> > > sms_board_event(coredev,
> BOARD_EVENT_POWER_SUSPEND); */
> > > > + break;
> > > > + case DVB3_EVENT_HOTPLUG:
> > > > +
> > > sms_debug("DVB3_EVENT_HOTPLUG");
> > > > + /*
> > > sms_board_event(coredev, BOARD_EVENT_POWER_INIT);
> */
> > > > + break;
> > > > + case DVB3_EVENT_FE_LOCK:
> > > > +
> > > sms_debug("DVB3_EVENT_FE_LOCK");
> > > > + /*
> > > sms_board_event(coredev, BOARD_EVENT_FE_LOCK);
> */
> > > > + break;
> > > > + case DVB3_EVENT_FE_UNLOCK:
> > > > +
> > > sms_debug("DVB3_EVENT_FE_UNLOCK");
> > > > + /*
> > > sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK);
> */
> > > > + break;
> > > > + case DVB3_EVENT_UNC_OK:
> > > > +
> > > sms_debug("DVB3_EVENT_UNC_OK");
> > > > + /*
> > > sms_board_event(coredev,
> BOARD_EVENT_MULTIPLEX_OK); */
> > > > + break;
> > > > + case DVB3_EVENT_UNC_ERR:
> > > > +
> > > sms_debug("DVB3_EVENT_UNC_ERR");
> > > > + /*
> > > sms_board_event(coredev,
> BOARD_EVENT_MULTIPLEX_ERRORS); */
> > > > + break;
> > > > +
> > > > + default:
> > > > +
> > > sms_err("Unknown dvb3 api event");
> > > > + break;
> > > > + }
> > > > +}
> > >
> > > This seems to be the core of this changeset.
> However, it
> > > just prints debug
> > > messages, since the real call to the event
> notification
> > > mechanism is commented.
> > >
> > >
> > > Cheers,
> > > Mauro
> > >
> >
> > The Siano driver is composed from several
> components. The sms_board_event() is called from one
> component (dvb3 in this case) to the "cards" component.
> > The series of patches I submitted, came to bring the
> 'dvb3' component as close as possible to the current file
> used by Siano. Since the "cards" has not been patched (yet),
> those functions have been add, but commented out.
>
> This makes the above patch meaningless. If you first need
> to create this function, then add the function first, then
> add its call at the proper places, otherwise, it is
> impossible for someone that it is reviewing your patch
> series what are you doing with it.
> >
> > I did the same with the endian and IR calls in other
> patches (add 'place holders' e.g. a comment, to be
> un-comment later when those component will be patches and
> avaliable).
>
> The same applies to the parts: first add the function, then
> add the function calls (or do both on the same patch), not
> the reverse.
>
>
>
> Cheers,
> Mauro
>
got it. will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
On Mon, 20 Apr 2009 09:56:26 -0700 (PDT)
Uri Shkolnik wrote:
>
>
>
> --- On Mon, 4/20/09, Mauro Carvalho Chehab wrote:
>
> > From: Mauro Carvalho Chehab
> > Subject: Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
> > To: "Uri Shkolnik"
> > Cc: "LinuxML"
> > Date: Monday, April 20, 2009, 7:21 PM
> > On Sun, 5 Apr 2009 03:18:01 -0700
> > (PDT)
> > Uri Shkolnik
> > wrote:
> >
> > >
> > > # HG changeset patch
> > > # User Uri Shkolnik
> > > # Date 1238742622 -10800
> > > # Node ID ec7ee486fb86d51bdb48e6a637a6ddd52e9e08c2
> > > # Parent
> > 020ba7b31c963bd36d607848198e9e4258a6f80e
> > > [PATCH] [0904_10] Siano: smsdvb - add events
> > mechanism
> > >
> > > From: Uri Shkolnik
> > >
> > > Add events mechanism that will notify the "cards"
> > component
> > > (which represent the specific hardware target) for DVB
> > related
> > > events.
> >
> >
> > This patch contains unrelated coding style fixes. Some of
> > them seem to be
> > related to previous changesets not applied.
> >
> > It is better to split coding style and real changes into
> > separate patches.
> >
> > > +/* Events that may come from DVB v3 adapter */
> > > +static void sms_board_dvb3_event(struct
> > smscore_device_t *coredev,
> > > + enum
> > SMS_DVB3_EVENTS event) {
> > > + switch (event) {
> > > + case DVB3_EVENT_INIT:
> > > +
> > sms_debug("DVB3_EVENT_INIT");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_BIND); */
> > > + break;
> > > + case DVB3_EVENT_SLEEP:
> > > +
> > sms_debug("DVB3_EVENT_SLEEP");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_POWER_SUSPEND); */
> > > + break;
> > > + case DVB3_EVENT_HOTPLUG:
> > > +
> > sms_debug("DVB3_EVENT_HOTPLUG");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_POWER_INIT); */
> > > + break;
> > > + case DVB3_EVENT_FE_LOCK:
> > > +
> > sms_debug("DVB3_EVENT_FE_LOCK");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_FE_LOCK); */
> > > + break;
> > > + case DVB3_EVENT_FE_UNLOCK:
> > > +
> > sms_debug("DVB3_EVENT_FE_UNLOCK");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK); */
> > > + break;
> > > + case DVB3_EVENT_UNC_OK:
> > > +
> > sms_debug("DVB3_EVENT_UNC_OK");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK); */
> > > + break;
> > > + case DVB3_EVENT_UNC_ERR:
> > > +
> > sms_debug("DVB3_EVENT_UNC_ERR");
> > > + /*
> > sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS); */
> > > + break;
> > > +
> > > + default:
> > > +
> > sms_err("Unknown dvb3 api event");
> > > + break;
> > > + }
> > > +}
> >
> > This seems to be the core of this changeset. However, it
> > just prints debug
> > messages, since the real call to the event notification
> > mechanism is commented.
> >
> >
> > Cheers,
> > Mauro
> >
>
> The Siano driver is composed from several components. The sms_board_event()
> is called from one component (dvb3 in this case) to the "cards" component.
> The series of patches I submitted, came to bring the 'dvb3' component as
> close as possible to the current file used by Siano. Since the "cards" has
> not been patched (yet), those functions have been add, but commented out.
This makes the above patch meaningless. If you first need to create this
function, then add the function first, then add its call at the proper places,
otherwise, it is impossible for someone that it is reviewing your patch series
what are you doing with it.
>
> I did the same with the endian and IR calls in other patches (add 'place
> holders' e.g. a comment, to be un-comment later when those component will be
> patches and avaliable).
The same applies to the parts: first add the function, then add the function
calls (or do both on the same patch), not the reverse.
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
--- On Mon, 4/20/09, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab
> Subject: Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
> To: "Uri Shkolnik"
> Cc: "LinuxML"
> Date: Monday, April 20, 2009, 7:21 PM
> On Sun, 5 Apr 2009 03:18:01 -0700
> (PDT)
> Uri Shkolnik
> wrote:
>
> >
> > # HG changeset patch
> > # User Uri Shkolnik
> > # Date 1238742622 -10800
> > # Node ID ec7ee486fb86d51bdb48e6a637a6ddd52e9e08c2
> > # Parent
> 020ba7b31c963bd36d607848198e9e4258a6f80e
> > [PATCH] [0904_10] Siano: smsdvb - add events
> mechanism
> >
> > From: Uri Shkolnik
> >
> > Add events mechanism that will notify the "cards"
> component
> > (which represent the specific hardware target) for DVB
> related
> > events.
>
>
> This patch contains unrelated coding style fixes. Some of
> them seem to be
> related to previous changesets not applied.
>
> It is better to split coding style and real changes into
> separate patches.
>
> > +/* Events that may come from DVB v3 adapter */
> > +static void sms_board_dvb3_event(struct
> smscore_device_t *coredev,
> > + enum
> SMS_DVB3_EVENTS event) {
> > + switch (event) {
> > + case DVB3_EVENT_INIT:
> > +
> sms_debug("DVB3_EVENT_INIT");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_BIND); */
> > + break;
> > + case DVB3_EVENT_SLEEP:
> > +
> sms_debug("DVB3_EVENT_SLEEP");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_POWER_SUSPEND); */
> > + break;
> > + case DVB3_EVENT_HOTPLUG:
> > +
> sms_debug("DVB3_EVENT_HOTPLUG");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_POWER_INIT); */
> > + break;
> > + case DVB3_EVENT_FE_LOCK:
> > +
> sms_debug("DVB3_EVENT_FE_LOCK");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_FE_LOCK); */
> > + break;
> > + case DVB3_EVENT_FE_UNLOCK:
> > +
> sms_debug("DVB3_EVENT_FE_UNLOCK");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK); */
> > + break;
> > + case DVB3_EVENT_UNC_OK:
> > +
> sms_debug("DVB3_EVENT_UNC_OK");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK); */
> > + break;
> > + case DVB3_EVENT_UNC_ERR:
> > +
> sms_debug("DVB3_EVENT_UNC_ERR");
> > + /*
> sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS); */
> > + break;
> > +
> > + default:
> > +
> sms_err("Unknown dvb3 api event");
> > + break;
> > + }
> > +}
>
> This seems to be the core of this changeset. However, it
> just prints debug
> messages, since the real call to the event notification
> mechanism is commented.
>
>
> Cheers,
> Mauro
>
The Siano driver is composed from several components. The sms_board_event() is
called from one component (dvb3 in this case) to the "cards" component.
The series of patches I submitted, came to bring the 'dvb3' component as close
as possible to the current file used by Siano. Since the "cards" has not been
patched (yet), those functions have been add, but commented out.
I did the same with the endian and IR calls in other patches (add 'place
holders' e.g. a comment, to be un-comment later when those component will be
patches and avaliable).
Regards,
Uri
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [0904_10] Siano: smsdvb - add events mechanism
On Sun, 5 Apr 2009 03:18:01 -0700 (PDT)
Uri Shkolnik wrote:
>
> # HG changeset patch
> # User Uri Shkolnik
> # Date 1238742622 -10800
> # Node ID ec7ee486fb86d51bdb48e6a637a6ddd52e9e08c2
> # Parent 020ba7b31c963bd36d607848198e9e4258a6f80e
> [PATCH] [0904_10] Siano: smsdvb - add events mechanism
>
> From: Uri Shkolnik
>
> Add events mechanism that will notify the "cards" component
> (which represent the specific hardware target) for DVB related
> events.
This patch contains unrelated coding style fixes. Some of them seem to be
related to previous changesets not applied.
It is better to split coding style and real changes into separate patches.
> +/* Events that may come from DVB v3 adapter */
> +static void sms_board_dvb3_event(struct smscore_device_t *coredev,
> + enum SMS_DVB3_EVENTS event) {
> + switch (event) {
> + case DVB3_EVENT_INIT:
> + sms_debug("DVB3_EVENT_INIT");
> + /* sms_board_event(coredev, BOARD_EVENT_BIND); */
> + break;
> + case DVB3_EVENT_SLEEP:
> + sms_debug("DVB3_EVENT_SLEEP");
> + /* sms_board_event(coredev, BOARD_EVENT_POWER_SUSPEND); */
> + break;
> + case DVB3_EVENT_HOTPLUG:
> + sms_debug("DVB3_EVENT_HOTPLUG");
> + /* sms_board_event(coredev, BOARD_EVENT_POWER_INIT); */
> + break;
> + case DVB3_EVENT_FE_LOCK:
> + sms_debug("DVB3_EVENT_FE_LOCK");
> + /* sms_board_event(coredev, BOARD_EVENT_FE_LOCK); */
> + break;
> + case DVB3_EVENT_FE_UNLOCK:
> + sms_debug("DVB3_EVENT_FE_UNLOCK");
> + /* sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK); */
> + break;
> + case DVB3_EVENT_UNC_OK:
> + sms_debug("DVB3_EVENT_UNC_OK");
> + /* sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK); */
> + break;
> + case DVB3_EVENT_UNC_ERR:
> + sms_debug("DVB3_EVENT_UNC_ERR");
> + /* sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS); */
> + break;
> +
> + default:
> + sms_err("Unknown dvb3 api event");
> + break;
> + }
> +}
This seems to be the core of this changeset. However, it just prints debug
messages, since the real call to the event notification mechanism is commented.
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
