--- On Tue, 5/19/09, Michael Krufky mkru...@linuxtv.org wrote:
From: Michael Krufky mkru...@linuxtv.org
Subject: Re: [PATCH] [09051_40] Siano - kconfig update
To: Uri Shkolnik uri...@yahoo.com
Cc: LinuxML linux-media@vger.kernel.org, Mauro Carvalho Chehab
mche...@infradead.org
Date: Tuesday, May 19, 2009, 6:47 PM
On Tue, May 19, 2009 at 7:58 AM, Uri
Shkolnik uri...@yahoo.com
wrote:
# HG changeset patch
# User Uri Shkolnik u...@siano-ms.com
# Date 1242734522 -10800
# Node ID c74502f4c8e97bd9cec9656793bbabc11fb72ab4
# Parent 315bc4b65b4f527c4f9bc4fe3290e10f07975437
[09051_40] Siano - kconfig update
From: Uri Shkolnik u...@siano-ms.com
This patches comes to solve the comments on Siano's
patch
0905_10. It updates the kconfig to support
multi-modules build.
Note that the dependency on dvb_core is for the
(sms)dvb module
alone, since the drivers set may work with another
adapter.
Priority: normal
Signed-off-by: Uri Shkolnik u...@siano-ms.com
diff -r 315bc4b65b4f -r c74502f4c8e9
linux/drivers/media/dvb/siano/Kconfig
--- a/linux/drivers/media/dvb/siano/Kconfig Sun
May 17 12:28:55 2009 +
+++ b/linux/drivers/media/dvb/siano/Kconfig Tue
May 19 15:02:02 2009 +0300
@@ -2,25 +2,40 @@
# Siano Mobile Silicon Digital TV device
configuration
#
-config DVB_SIANO_SMS1XXX
- tristate Siano SMS1XXX USB dongle
support
- depends on DVB_CORE USB
+config SMS_SIANO_MDTV
+ tristate Siano SMS1xxx based MDTV
receiver
+ default m
---help---
- Choose Y here if you have a USB dongle
with a SMS1XXX chipset.
+ Choose Y or M here if you have MDTV
receiver with a Siano chipset.
- To compile this driver as a module,
choose M here: the
- module will be called sms1xxx.
+ To compile this driver as a module, choose
M here
+ (The modules will be called smsmdtv).
-config DVB_SIANO_SMS1XXX_SMS_IDS
- bool Enable support for Siano Mobile
Silicon default USB IDs
- depends on DVB_SIANO_SMS1XXX
- default y
+ Note: All dependents, if selected, will be
part of this module.
+
+ Further documentation on this driver can be
found on the WWW
+ at http://www.siano-ms.com/
+
+if SMS_SIANO_MDTV
+menu Siano module components
+
+# Kernel sub systems support
+config SMS_DVB3_SUBSYS
+ tristate DVB v.3 Subsystem support
+ depends on DVB_CORE
+ default m if DVB_CORE
---help---
- Choose Y here if you have a USB dongle
with a SMS1XXX chipset
- that uses Siano Mobile Silicon's default
usb vid:pid.
+ Choose if you would like to have DVB v.3
kernel sub-system support.
- Choose N here if you would prefer to use
Siano's external driver.
+# Hardware interfaces support
- Further documentation on this driver can
be found on the WWW at
- http://www.siano-ms.com/.
+config SMS_USB_DRV
+ tristate USB interface support
+ depends on USB
+ default m if USB
+ ---help---
+ Choose if you would like to have Siano's
support for USB interface
+
+endmenu
+endif # SMS_SIANO_MDTV
--
To unsubscribe from this list: send the line
unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I have two concerns with this patch...
Issue #1, I dont see why it's important to rename the
Kconfig symbol
from DVB_SIANO_SMS1XXX to SMS_SIANO_MDTV -- This will just
cause
breakage of make oldconfig in the kernel with no real
benefit.
Issue #2, a much bigger issue. This patch implies
that the Siano
driver can be built *with* DVB v3 support, or without
it. Why would
a linux user ever want to built this driver without support
for the
DVB API ? (that's a loaded question) ... Does
Siano intend to push
their proprietary API into the kernel?
-Mike
Regarding #1 - sms1xxx implies that is support only Siano devices from 1xxx
families, but actually it support all Siano's chip-sets and various MCPs (Which
have different numeration than 1xxx, I can't give details here, sorry). So 1xxx
is a misleading name.
MDTV - much better (you can read it as Mobile Digital TV, or something else)
Regarding #2 - DVB-API version 3 (dvb-core module) is one of the sub-systems
which are supported. The drivers set is also supports DVB-API version 5
(pre-alpha at this stage) and Siano's proprietary sub-system. So, actually you
don't have to have dvb-core in order to use Siano's USB interface driver...
Please note that there are DAB radio builds, using Siano chip-sets and
drivers... which means you don't need the dvb-core as well, you just need the
dab and the Siano's core and interface drivers...
Long time ago I asked you, why you chose to put the Siano sub-tree under
media/dvb
