Re: [PATCH] mmp-camera: specify XO-1.75 clock speed
On Tue, 15 May 2012 20:43:31 +0100 (BST) Daniel Drake wrote: > Jon, is it OK to assume that XO-1.75 is the only mmp-camera user? It's the only one I know of at the moment, certainly. Even so, I think it would be a lot better to put this parameter into the mmp_camera_platform_data structure instead of wiring it into the driver source; it could then be set in olpc-xo-1-75.c with the other relevant parameters. I won't oppose the inclusion of this patch, but...any chance it could be done that way? Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mmp-camera: specify XO-1.75 clock speed
On Wed, May 16, 2012 at 3:12 PM, Jonathan Corbet wrote: > On Tue, 15 May 2012 20:43:31 +0100 (BST) > Daniel Drake wrote: > >> Jon, is it OK to assume that XO-1.75 is the only mmp-camera user? > > It's the only one I know of at the moment, certainly. > > Even so, I think it would be a lot better to put this parameter into the > mmp_camera_platform_data structure instead of wiring it into the driver > source; it could then be set in olpc-xo-1-75.c with the other relevant > parameters. I won't oppose the inclusion of this patch, but...any chance > it could be done that way? I'll look into it. Please put this patch on pause for now. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mmp-camera: specify XO-1.75 clock speed
Em 16-05-2012 18:15, Daniel Drake escreveu: > On Wed, May 16, 2012 at 3:12 PM, Jonathan Corbet wrote: >> On Tue, 15 May 2012 20:43:31 +0100 (BST) >> Daniel Drake wrote: >> >>> Jon, is it OK to assume that XO-1.75 is the only mmp-camera user? >> >> It's the only one I know of at the moment, certainly. >> >> Even so, I think it would be a lot better to put this parameter into the >> mmp_camera_platform_data structure instead of wiring it into the driver >> source; it could then be set in olpc-xo-1-75.c with the other relevant >> parameters. I won't oppose the inclusion of this patch, but...any chance >> it could be done that way? > > I'll look into it. Please put this patch on pause for now. I've marked this patch as "changes requested" at patchwork: http://patchwork.linuxtv.org/patch/11270/ I agree with Jon: adding such config stuff at platform data is better. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
