Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
Hi Guennadi, On Thu, Oct 16, 2014 at 10:27:13PM +0200, Guennadi Liakhovetski wrote: Hello, Thanks for the patches. Could you please fold these two into one - they really don't deserve to be separated. Thanks. Kaneko-san could you squash these patches and repost? As for your other series - patches there look mostly good - from just a formal review. If you don't mind, I'll adjust a couple of cosmetic issues like missing curly braces in if (a) x(); else { y(); z(); } or multiline comments or similar minor things. Feel free to make any minor updates. Thanks Guennadi On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote: This series is against master branch of linuxtv.org/media_tree.git. Koji Matsuoka (2): media: soc_camera: rcar_vin: Add r8a7794 device support media: soc_camera: rcar_vin: Add r8a7793 device support drivers/media/platform/soc_camera/rcar_vin.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-sh in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
2014-10-17 15:02 GMT+09:00 Simon Horman ho...@verge.net.au: Hi Guennadi, On Thu, Oct 16, 2014 at 10:27:13PM +0200, Guennadi Liakhovetski wrote: Hello, Thanks for the patches. Could you please fold these two into one - they really don't deserve to be separated. Thanks. Kaneko-san could you squash these patches and repost? Sure, will do. As for your other series - patches there look mostly good - from just a formal review. If you don't mind, I'll adjust a couple of cosmetic issues like missing curly braces in if (a) x(); else { y(); z(); } or multiline comments or similar minor things. Feel free to make any minor updates. Thanks Guennadi On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote: This series is against master branch of linuxtv.org/media_tree.git. Koji Matsuoka (2): media: soc_camera: rcar_vin: Add r8a7794 device support media: soc_camera: rcar_vin: Add r8a7793 device support drivers/media/platform/soc_camera/rcar_vin.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-sh in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
Hello, Thanks for the patches. Could you please fold these two into one - they really don't deserve to be separated. As for your other series - patches there look mostly good - from just a formal review. If you don't mind, I'll adjust a couple of cosmetic issues like missing curly braces in if (a) x(); else { y(); z(); } or multiline comments or similar minor things. Thanks Guennadi On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote: This series is against master branch of linuxtv.org/media_tree.git. Koji Matsuoka (2): media: soc_camera: rcar_vin: Add r8a7794 device support media: soc_camera: rcar_vin: Add r8a7793 device support drivers/media/platform/soc_camera/rcar_vin.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
[CC Mauro Carvalho Chehab] On Tue, Oct 14, 2014 at 04:20:22PM +0900, Yoshihiro Kaneko wrote: This series is against master branch of linuxtv.org/media_tree.git. Koji Matsuoka (2): media: soc_camera: rcar_vin: Add r8a7794 device support media: soc_camera: rcar_vin: Add r8a7793 device support drivers/media/platform/soc_camera/rcar_vin.c | 2 ++ 1 file changed, 2 insertions(+) Acked-by: Simon Horman horms+rene...@verge.net.au If the series needs reposting to a different CC list - e.g. including Mauro - please let Kaneko-san or myself know. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html