Re: [PATCH 1/3] media: stkwebcam: Support for ASUS A6VM notebook added.

2018-11-30 Thread Andreas Pape
Hi Keiran,

thanks for the review.

On Mon, 26 Nov 2018 12:48:53 +
Kieran Bingham  wrote:

> 
> I guess these strings match the strings produced by dmi-decode on your
> laptop?
>

I didn't use dmidecode but I read the values from /sys/class/dmi/sys_vendor and
/sys/class/dmi/product_name accordingly.

Kind regards,
Andreas


Re: [PATCH 1/3] media: stkwebcam: Support for ASUS A6VM notebook added.

2018-11-26 Thread Kieran Bingham
Hi Andreas,

Thank you for the patch,

On 23/11/2018 16:14, Andreas Pape wrote:
> The ASUS A6VM notebook has a built in stk11xx webcam which is mounted
> in a way that the video is vertically and horizontally flipped.
> Therefore this notebook is added to the special handling in the driver
> to automatically flip the video into the correct orientation.
> 
> Signed-off-by: Andreas Pape 
> ---
>  drivers/media/usb/stkwebcam/stk-webcam.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c 
> b/drivers/media/usb/stkwebcam/stk-webcam.c
> index e11d5d5b7c26..e61427e50525 100644
> --- a/drivers/media/usb/stkwebcam/stk-webcam.c
> +++ b/drivers/media/usb/stkwebcam/stk-webcam.c
> @@ -116,6 +116,13 @@ static const struct dmi_system_id 
> stk_upside_down_dmi_table[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "T12Rg-H")
>   }
>   },
> + {
> + .ident = "ASUS A6VM",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "A6VM")
> + }

I guess these strings match the strings produced by dmi-decode on your
laptop?

Assuming so:

Reviewed-by: Kieran Bingham 


> + },
>   {}
>  };
>  
> 

-- 
Regards
--
Kieran