Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic
Em Mon, 18 Mar 2013 17:05:12 -0300 Fabio Estevam escreveu: > Hi Mauro, > > On Mon, Mar 18, 2013 at 4:25 PM, Mauro Carvalho Chehab > wrote: > > > -static int emulate_delivery_system(struct dvb_frontend *fe, > > - enum dvbv3_emulation_type type, > > - u32 delsys, u32 desired_system) > > +/** > > + * emulate_delivery_system - emulate a DVBv5 delivery system with a DVBv3 > > type > > + * @fe:struct frontend; > > + * @desired_system:DVBv5 type that will be used for emulation > > 'desired_system' parameter has been removed in this patch. 'delsys' > should be put in the description instead. Thanks for reviewing it! Yeah, internally I made several versions of this patch, in order to make each routine clear. On the very last minute, I ended by just removing desired_system, keeping just one parameter there after fe. I'm changing it at the version I'm committing. Thanks! Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic
Hi Mauro, On Mon, Mar 18, 2013 at 4:25 PM, Mauro Carvalho Chehab wrote: > -static int emulate_delivery_system(struct dvb_frontend *fe, > - enum dvbv3_emulation_type type, > - u32 delsys, u32 desired_system) > +/** > + * emulate_delivery_system - emulate a DVBv5 delivery system with a DVBv3 > type > + * @fe:struct frontend; > + * @desired_system:DVBv5 type that will be used for emulation 'desired_system' parameter has been removed in this patch. 'delsys' should be put in the description instead. > + * Provides emulation for delivery systems that are compatible with the old > + * DVBv3 call. Among its usages, it provices support for ISDB-T, and allows > + * using a DVB-S2 only frontend just like it were a DVB-S, if the frontent > + * parameters are compatible with DVB-S spec. > + */ > +static int emulate_delivery_system(struct dvb_frontend *fe, u32 delsys) Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
