Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
On Tue, Mar 01, 2011 at 03:44:45PM +0200, Matti J. Aaltonen wrote: > On Tue, 2011-03-01 at 13:23 +, ext Mark Brown wrote: > > On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote: > > > These changes are needed to keep up with the changes in the > > > MFD core and V4L2 parts of the wl1273 FM radio driver. > > > > > > Use function pointers instead of exported functions for I2C IO. > > > Also move all preprocessor constants from the wl1273.h to > > > include/linux/mfd/wl1273-core.h. > > > > > > Also update the year in the copyright statement. > > > > > > Signed-off-by: Matti J. Aaltonen > > > > Acked-by: Mark Brown > > > > *Please* keep acks unless you're making substantial changes to > > repostings. > > OK, I see, I should have added the ACKs to the relevant driver files > instead of copying them to the cover letter... Yes, it makes it easier for the maintainer taking your patches. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
On Tue, 2011-03-01 at 13:23 +, ext Mark Brown wrote: > On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote: > > These changes are needed to keep up with the changes in the > > MFD core and V4L2 parts of the wl1273 FM radio driver. > > > > Use function pointers instead of exported functions for I2C IO. > > Also move all preprocessor constants from the wl1273.h to > > include/linux/mfd/wl1273-core.h. > > > > Also update the year in the copyright statement. > > > > Signed-off-by: Matti J. Aaltonen > > Acked-by: Mark Brown > > *Please* keep acks unless you're making substantial changes to > repostings. OK, I see, I should have added the ACKs to the relevant driver files instead of copying them to the cover letter... Cheers, Matti > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote: > These changes are needed to keep up with the changes in the > MFD core and V4L2 parts of the wl1273 FM radio driver. > > Use function pointers instead of exported functions for I2C IO. > Also move all preprocessor constants from the wl1273.h to > include/linux/mfd/wl1273-core.h. > > Also update the year in the copyright statement. > > Signed-off-by: Matti J. Aaltonen Acked-by: Mark Brown *Please* keep acks unless you're making substantial changes to repostings. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html