Re: [PATCH v3 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint
Hi Laurent, On Tue, Apr 07, 2015 at 01:11:34PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tuesday 07 April 2015 01:57:29 Sakari Ailus wrote: > > The field is unused. Remove it. > > Do you know what the field was added for in the first place ? Frankly I have to admit I have no idea. It's part of the original patch which adds V4L2 OF support: --- commit 99fd133f907afdb430942d8d2ae53faa438adfe8 Author: Guennadi Liakhovetski Date: Wed Sep 26 05:24:03 2012 -0300 [media] Add a V4L2 OF parser Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. [s.nawro...@samsung.com: various corrections and improvements since the initial version] Signed-off-by: Guennadi Liakhovetski Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Signed-off-by: Mauro Carvalho Chehab --- It looks like the intent has been that the field is used in order to keep a list of structs of this kind, but no-one is using it for that purpose at the moment. -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint
Hi Sakari,
Thank you for the patch.
On Tuesday 07 April 2015 01:57:29 Sakari Ailus wrote:
> The field is unused. Remove it.
Do you know what the field was added for in the first place ?
> Signed-off-by: Sakari Ailus
> ---
> include/media/v4l2-of.h |2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h
> index f831c9c..f66b92c 100644
> --- a/include/media/v4l2-of.h
> +++ b/include/media/v4l2-of.h
> @@ -57,7 +57,6 @@ struct v4l2_of_bus_parallel {
> * @base: struct of_endpoint containing port, id, and local of_node
> * @bus_type: bus type
> * @bus: bus configuration data structure
> - * @head: list head for this structure
> */
> struct v4l2_of_endpoint {
> struct of_endpoint base;
> @@ -66,7 +65,6 @@ struct v4l2_of_endpoint {
> struct v4l2_of_bus_parallel parallel;
> struct v4l2_of_bus_mipi_csi2 mipi_csi2;
> } bus;
> - struct list_head head;
> };
>
> /**
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
