Re: [PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
On Fri, Jul 13, 2018 at 05:38:25PM +0300, Ivaylo Dimitrov wrote: > Hi, > > On 13.07.2018 15:22, Sean Young wrote: > > The ir-rx51 is a pwm-based TX driver specific to the N900. This can be > > handled entirely by the generic pwm-ir-tx driver. > > > > Note that the suspend code in the ir-rx51 driver is unnecessary, since > > during transmit, the process is not in interruptable sleep. The process > > is not put to sleep until the transmit completes. > > > > Compile tested only. > > > > I would like to see this being tested on a real HW, however I am on a > holiday for the next week so won't be able to test till I am back. > > @Pali - do you have n900 with fremantle, upstream kernel and pierogi to test > pwm-ir-tx on it? It would be nice to have this verified on real hardware, if possible. If not, I would like to merge this anyway. If there are any problems we can always later patch any problem in pwm-ir-tx for the n900. Sean
Re: [PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
On Friday 13 July 2018 17:38:25 Ivaylo Dimitrov wrote: > Hi, > > On 13.07.2018 15:22, Sean Young wrote: > > The ir-rx51 is a pwm-based TX driver specific to the N900. This can be > > handled entirely by the generic pwm-ir-tx driver. > > > > Note that the suspend code in the ir-rx51 driver is unnecessary, since > > during transmit, the process is not in interruptable sleep. The process > > is not put to sleep until the transmit completes. > > > > Compile tested only. > > > > I would like to see this being tested on a real HW, however I am on a > holiday for the next week so won't be able to test till I am back. > > @Pali - do you have n900 with fremantle, upstream kernel and pierogi to test > pwm-ir-tx on it? Hi! Currently on my N900 with Maemo Fremantle is 2.6.28 and 3.12 kernels. And 3.12 is a far away from current upstream kernel. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
Re: [PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
Hi, On 13.07.2018 15:22, Sean Young wrote: The ir-rx51 is a pwm-based TX driver specific to the N900. This can be handled entirely by the generic pwm-ir-tx driver. Note that the suspend code in the ir-rx51 driver is unnecessary, since during transmit, the process is not in interruptable sleep. The process is not put to sleep until the transmit completes. Compile tested only. I would like to see this being tested on a real HW, however I am on a holiday for the next week so won't be able to test till I am back. @Pali - do you have n900 with fremantle, upstream kernel and pierogi to test pwm-ir-tx on it? Ivo
