Re: [PULL] http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881

2009-07-15 Thread Alain Perrot
On Wed, Jul 15, 2009 at 5:41 AM, Devin
Heitmuellerdheitmuel...@kernellabs.com wrote:
 On Sun, Jul 12, 2009 at 11:23 PM, Devin
 Heitmuellerdheitmuel...@kernellabs.com wrote:
 Hello Mauro,

 Please pull from
 http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881 for the
 following:

 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)

 Thanks,

 Devin

 Mauro,

 Please note that the PULL has been updated with two additional
 patches, which were necessary for this board to work.  I had them in
 my working directory from when I did the initial work, but
 accidentally did not include them in the patch series.

 The final series is as follows:

 em28xx: set demod profile for Pinnacle Hybrid Pro 320e
 em28xx: Make sure the tuner is initialized if generic empia USB id was used
 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)

 Thanks,

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html


Hi,

I have just tested your repository with my Dazzle TV Hybrid Stick 320e, which
use the same hardware as the Pinnacle Hybrid Pro 320e.

Digital TV works great ! I have not tested analog TV. I use an x86_64 kernel
version 2.6.30 if it matters.

It is nice to see support for this USB stick go into the V4L tree, it was really
boring to fetch and build the drivers from mcentral.de to be able to watch TV.

So thanks for your work !


- Alain
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881

2009-07-14 Thread Devin Heitmueller
On Sun, Jul 12, 2009 at 11:23 PM, Devin
Heitmuellerdheitmuel...@kernellabs.com wrote:
 Hello Mauro,

 Please pull from
 http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881 for the
 following:

 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)

 Thanks,

 Devin

Mauro,

Please note that the PULL has been updated with two additional
patches, which were necessary for this board to work.  I had them in
my working directory from when I did the initial work, but
accidentally did not include them in the patch series.

The final series is as follows:

em28xx: set demod profile for Pinnacle Hybrid Pro 320e
em28xx: Make sure the tuner is initialized if generic empia USB id was used
em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881

2009-07-13 Thread Markus Rechberger
On Mon, Jul 13, 2009 at 5:23 AM, Devin
Heitmuellerdheitmuel...@kernellabs.com wrote:
 Hello Mauro,

 Please pull from
 http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881 for the
 following:

 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)


You might add a message to dmesg, that this setting can burn other
devices which use the eb1a:2881 vendor/productid. Especially Pinnacle
they didn't add Svideo/Composite to their device and it works slightly
different than the others.

Best Regards,
Markus
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881

2009-07-13 Thread Devin Heitmueller
On Mon, Jul 13, 2009 at 9:51 AM, Markus Rechbergermrechber...@gmail.com wrote:
 On Mon, Jul 13, 2009 at 5:23 AM, Devin
 Heitmuellerdheitmuel...@kernellabs.com wrote:
 Hello Mauro,

 Please pull from
 http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881 for the
 following:

 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)


 You might add a message to dmesg, that this setting can burn other
 devices which use the eb1a:2881 vendor/productid. Especially Pinnacle
 they didn't add Svideo/Composite to their device and it works slightly
 different than the others.

 Best Regards,
 Markus

Hello Markus,

Thank you for taking the time to review the patch and provide
feedback.  Two questions:

1.  Are you suggesting that a warning be shown if someone manually
uses card=52, or do you mean that we should show a warning if they
actually have the Pinnacle Hybrid Pro 320e?  I am using an eeprom
checksum to ensure that not all devices with eb1a:2881 use the device
profile, but rather only devices with the matching hash, so in theory
the profile should only be associated with that one card.

2.  Are there any additional details you can provide about the
differences in the Pinnacle device you know of which is wired up
differently than all the others?

Personally, I would like to get rid of the card= modprobe option
completely, as it presents a considerable risk of users who do not
know any better damaging their hardware.

I am obviously very concerned about any cases where devices could be
damaged, and any additional information you could provide to help
mitigate that risk is certainly welcome.

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881

2009-07-13 Thread Markus Rechberger
On Mon, Jul 13, 2009 at 4:08 PM, Devin
Heitmuellerdheitmuel...@kernellabs.com wrote:
 On Mon, Jul 13, 2009 at 9:51 AM, Markus Rechbergermrechber...@gmail.com 
 wrote:
 On Mon, Jul 13, 2009 at 5:23 AM, Devin
 Heitmuellerdheitmuel...@kernellabs.com wrote:
 Hello Mauro,

 Please pull from
 http://kernellabs.com/hg/~dheitmueller/pinnacle_hybrid_2881 for the
 following:

 em28xx: set GPIO properly for Pinnacle Hybrid Pro analog support
 em28xx: make support work for the Pinnacle Hybrid Pro (eb1a:2881)


 You might add a message to dmesg, that this setting can burn other
 devices which use the eb1a:2881 vendor/productid. Especially Pinnacle
 they didn't add Svideo/Composite to their device and it works slightly
 different than the others.

 Best Regards,
 Markus

 Hello Markus,

 Thank you for taking the time to review the patch and provide
 feedback.  Two questions:

 1.  Are you suggesting that a warning be shown if someone manually
 uses card=52, or do you mean that we should show a warning if they
 actually have the Pinnacle Hybrid Pro 320e?  I am using an eeprom
 checksum to ensure that not all devices with eb1a:2881 use the device
 profile, but rather only devices with the matching hash, so in theory
 the profile should only be associated with that one card.

 2.  Are there any additional details you can provide about the
 differences in the Pinnacle device you know of which is wired up
 differently than all the others?


I am not entirely sure about which device you have, but there's one
which does not support Svideo/Composite - there's no connector for it
and internally it's not routed properly (although the hardware would
be able to support it).
I will check those devices this week.

 Personally, I would like to get rid of the card= modprobe option
 completely, as it presents a considerable risk of users who do not
 know any better damaging their hardware.

 I am obviously very concerned about any cases where devices could be
 damaged, and any additional information you could provide to help
 mitigate that risk is certainly welcome.


I think there's no official way to solve this properly as this
information is disclosed, so it will be up to the user if he burns his
device or not when he uses a device with a generic ID. I still have
those 2 Terratec devices which have a slightly melted case from the
good old days where reverse engineered values have been used.

Best Regards,
Markus
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html