Re: [PATCH V2 00/16] omap_hsmmc patches
On Wed, Jul 13, 2011 at 6:36 PM, Chris Ball c...@laptop.org wrote: Hi, On Wed, Jul 13 2011, Grazvydas Ignotas wrote: it seems this series got lost in time, at least patches 01, 02, 03, 04, 05, 06, 07, 08, 12 look like valid standalone fixes and improvements to me, they don't touch other trees and still apply cleanly, so would be good to have. Yeah. I didn't merge them because Tony still has unanswered comments on the OMAP side of the patches, and they're submitted as a single patchset. I've applied {2, 3, 5, 6, 7, 8, 12} to mmc-next for 3.1 now. 1 doesn't apply because the function doesn't exist anymore. 4 doesn't apply because iclk doesn't exist anymore. If someone wants to look at rebasing the rest of these against mmc-next and resubmitting, I think that'd be useful. Thanks! 1 and 4 seem to be unneeded any more (I was trying them on linux-next, not noticing it was not updated for a while), and others have comments pending, so it's all done. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- Gražvydas -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] mxs-mmc: fix clock rate setting
Hi, On Mon, Jul 11, 2011 at 10:26 PM, Wolfram Sang w.s...@pengutronix.de wrote: Hi Koen, thanks for v2. On Mon, Jul 11, 2011 at 09:52:01PM +0200, Koen Beel wrote: (Sorry, patch in attachment as I still don't have a decent mail setup at my company) That's bad :( Fix clock rate setting on mxs-mmc driver. Previously, if div2 was zero the value for TIMING_CLOCK_RATE would have been 255 instead of 0. Also the limits for div1 (TIMING_CLOCK_DIVIDE) and div2 (TIMING_CLOCK_RATE + 1) where not correctly defined. Very minor nit: No paragraphs I'd say. Can easily be reproduced on mx23evk: default clock for high speed sdio cards is 50 MHz. With a SSP_CLK of 28.8 MHz default), this resulted in an actual clock rate of about 56 kHz. Tested on mx23evk. Changes in V2 patch: - use DIV_ROUND_UP to make sure the actual clock rate is not higher then the requested clock rate. - rename variables to reflect naming in datasheet and to make things more clear Changelogs are good, but should go below --- Signed-off-by: Koen Beel koen.b...@barco.com --- drivers/mmc/host/mxs-mmc.c | 30 ++ 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 99d39a6..d513d47 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -564,40 +564,38 @@ static void mxs_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq) static void mxs_mmc_set_clk_rate(struct mxs_mmc_host *host, unsigned int rate) { - unsigned int ssp_rate, bit_rate; - u32 div1, div2; + unsigned int ssp_clk, ssp_sck; ssp_sck is not really needed? Value could directly go to host-clk_rate. + u32 clock_divide, clock_rate; u32 val; - ssp_rate = clk_get_rate(host-clk); + ssp_clk = clk_get_rate(host-clk); - for (div1 = 2; div1 254; div1 += 2) { - div2 = ssp_rate / rate / div1; - if (div2 0x100) + for (clock_divide = 2; clock_divide = 254; clock_divide += 2) { + clock_rate = DIV_ROUND_UP(ssp_clk, rate * clock_divide); + clock_rate = (clock_rate 0) ? clock_rate - 1 : 0; + if (clock_rate = 255) break; } - if (div1 = 254) { + if (clock_divide 254) { dev_err(mmc_dev(host-mmc), %s: cannot set clock to %d\n, __func__, rate); Didn't you want to set some minimal values instead of just returning? Just wondering, could be a seperate patch in my book... return; } - if (div2 == 0) - bit_rate = ssp_rate / div1; - else - bit_rate = ssp_rate / div1 / div2; + ssp_sck = ssp_clk / clock_divide / (1 + clock_rate); val = readl(host-base + HW_SSP_TIMING); val = ~(BM_SSP_TIMING_CLOCK_DIVIDE | BM_SSP_TIMING_CLOCK_RATE); - val |= BF_SSP(div1, TIMING_CLOCK_DIVIDE); - val |= BF_SSP(div2 - 1, TIMING_CLOCK_RATE); + val |= BF_SSP(clock_divide, TIMING_CLOCK_DIVIDE); + val |= BF_SSP(clock_rate, TIMING_CLOCK_RATE); writel(val, host-base + HW_SSP_TIMING); - host-clk_rate = bit_rate; + host-clk_rate = ssp_sck; dev_dbg(mmc_dev(host-mmc), - %s: div1 %d, div2 %d, ssp %d, bit %d, rate %d\n, - __func__, div1, div2, ssp_rate, bit_rate, rate); + %s: clock_divide %d, clock_rate %d, ssp_clk %d, rate_actual %d, rate_requested %d\n, + __func__, clock_divide, clock_rate, ssp_clk, ssp_sck, rate); } Rest looks good to me, and test was also successful. Chris, if you want to take this version already: Still need me to do something on this or is it ok? Koen Reviewed-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] use both-edge GPIO interrupt for SDHI0 on mackerel
As correctly pointed out by Magnus, IRQ-capable GPIOs on sh7372 can produce interrupts on both edges. These patches extend the intc driver and use this for SDHI0 hotplug detection on mackerel. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] sh-mobile: enable both edges GPIO interrupts on sh7372
From: Magnus Damm d...@opensource.se IRQ-capable GPIOs on sh7372 can be configured to produce interrupts on both edges. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm d...@opensource.se --- drivers/sh/intc/chip.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/sh/intc/chip.c b/drivers/sh/intc/chip.c index f33e2dd..33b2ed4 100644 --- a/drivers/sh/intc/chip.c +++ b/drivers/sh/intc/chip.c @@ -186,6 +186,9 @@ static unsigned char intc_irq_sense_table[IRQ_TYPE_SENSE_MASK + 1] = { !defined(CONFIG_CPU_SUBTYPE_SH7709) [IRQ_TYPE_LEVEL_HIGH] = VALID(3), #endif +#if defined(CONFIG_ARCH_SH7372) + [IRQ_TYPE_EDGE_BOTH] = VALID(4), +#endif }; static int intc_set_type(struct irq_data *data, unsigned int type) -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2 v2] ARM: mach-shmobile: use GPIO interrupt also for card eject on SDHI0 on mackerel
When we switch to transaction-based runtime PM on SDHI / TMIO MMC, also card eject events will have to be detected by the platform. This patch prepares mackerel to this switch. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: reconfiguring the pin for card insertion and ejection is no longer needed. arch/arm/mach-shmobile/board-mackerel.c | 48 +- 1 files changed, 40 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c index 1b30195..9addaae 100644 --- a/arch/arm/mach-shmobile/board-mackerel.c +++ b/arch/arm/mach-shmobile/board-mackerel.c @@ -45,6 +45,7 @@ #include linux/tca6416_keypad.h #include linux/usb/r8a66597.h #include linux/usb/renesas_usbhs.h +#include linux/workqueue.h #include video/sh_mobile_hdmi.h #include video/sh_mobile_lcdc.h @@ -990,7 +991,7 @@ static struct platform_device fsi_ak4643_device = { /* * The card detect pin of the top SD/MMC slot (CN7) is active low and is - * connected to GPIO A22 of SH7372 (GPIO_PORT41). + * connected to GPIO A22 of SH7372 (GPIO_PORT41 / IRQ8). */ static int slot_cn7_get_cd(struct platform_device *pdev) { @@ -998,12 +999,30 @@ static int slot_cn7_get_cd(struct platform_device *pdev) } /* SDHI0 */ -static irqreturn_t mackerel_sdhi0_gpio_cd(int irq, void *arg) +struct sdhi_card_detect { + struct delayed_work work; + struct sh_mobile_sdhi_info *info; + int gpio_irq; +}; + +static void sdhi_cd_work(struct work_struct *work) +{ + struct sdhi_card_detect *cd = container_of(work, struct sdhi_card_detect, work.work); + irq_set_irq_type(cd-gpio_irq, IRQ_TYPE_EDGE_BOTH); +} + +static irqreturn_t mackerel_sdhi_gpio_cd(int irq, void *arg) { - struct device *dev = arg; - struct sh_mobile_sdhi_info *info = dev-platform_data; + struct sdhi_card_detect *cd = arg; + struct sh_mobile_sdhi_info *info = cd-info; struct tmio_mmc_data *pdata = info-pdata; + if (irq != cd-gpio_irq) + return IRQ_NONE; + + irq_set_irq_type(irq, IRQ_TYPE_NONE); + + schedule_delayed_work(cd-work, msecs_to_jiffies(200)); tmio_mmc_cd_wakeup(pdata); return IRQ_HANDLED; @@ -1015,6 +1034,12 @@ static struct sh_mobile_sdhi_info sdhi0_info = { .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ, }; +static struct sdhi_card_detect sdhi0_cd = { + .work = __DELAYED_WORK_INITIALIZER(sdhi0_cd.work, sdhi_cd_work), + .info = sdhi0_info, + .gpio_irq = evt2irq(0x3340), +}; + static struct resource sdhi0_resources[] = { [0] = { .name = SDHI0, @@ -1092,7 +1117,7 @@ static struct platform_device sdhi1_device = { /* * The card detect pin of the top SD/MMC slot (CN23) is active low and is - * connected to GPIO SCIFB_SCK of SH7372 (GPIO_PORT162). + * connected to GPIO SCIFB_SCK of SH7372 (GPIO_PORT162 / IRQ0). */ static int slot_cn23_get_cd(struct platform_device *pdev) { @@ -1500,12 +1525,19 @@ static void __init mackerel_init(void) gpio_request(GPIO_FN_SDHID0_1, NULL); gpio_request(GPIO_FN_SDHID0_0, NULL); - ret = request_irq(evt2irq(0x3340), mackerel_sdhi0_gpio_cd, - IRQF_TRIGGER_FALLING, sdhi0 cd, sdhi0_device.dev); + /* +* If the driver probes with a card plugged in, the native SDHICD0 IRQ +* will trigger, when the runtime PM brings the interface up, and the +* card will be detected. This interrupt is needed if there is no card +* during probing and runtime PM turns the interface power off. +*/ + ret = request_irq(sdhi0_cd.gpio_irq, mackerel_sdhi_gpio_cd, + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, + sdhi0 cd, sdhi0_cd); if (!ret) sdhi0_info.tmio_flags |= TMIO_MMC_HAS_COLD_CD; else - pr_err(Cannot get IRQ #%d: %d\n, evt2irq(0x3340), ret); + pr_err(Cannot get IRQ #%d: %d\n, sdhi0_cd.gpio_irq, ret); #if !defined(CONFIG_MMC_SH_MMCIF) !defined(CONFIG_MMC_SH_MMCIF_MODULE) /* enable SDHI1 */ -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] sh-mobile: enable both edges GPIO interrupts on sh7372
On Fri, Jul 15, 2011 at 7:58 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: From: Magnus Damm d...@opensource.se IRQ-capable GPIOs on sh7372 can be configured to produce interrupts on both edges. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm d...@opensource.se --- drivers/sh/intc/chip.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Acked-by: Magnus Damm d...@opensource.se -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] mmc: sdhci-s3c: Add support for device tree based probe
Add of_match_table to enable sdhci-s3c driver to be probed when a compatible sdhci device node is found in device tree. CC: linux-mmc@vger.kernel.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- .../devicetree/bindings/mmc/samsung-s3c-sdhci.txt | 10 ++ drivers/mmc/host/sdhci-s3c.c | 11 +++ 2 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt diff --git a/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt b/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt new file mode 100644 index 000..c2298f8 --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt @@ -0,0 +1,10 @@ +* Samsung's SDHCI controller + +The Samsung's SDHCI controller is used for interfacing with SD/MMC cards. + +Required properties: +- compatible : should be samsung,s3c-sdhci +- reg : base physical address of the controller and length of memory mapped + region. +- interrupts : interrupt number to the cpu. + diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 69e3ee3..5ccbee0 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -629,6 +629,16 @@ static int sdhci_s3c_resume(struct platform_device *dev) #define sdhci_s3c_resume NULL #endif +#ifdef CONFIG_OF +static const struct of_device_id s3c_sdhci_match[] = { + { .compatible = samsung,s3c-sdhci }, + {}, +}; +MODULE_DEVICE_TABLE(of, s3c_sdhci_match); +#else +#define s3c_sdhci_match NULL +#endif + static struct platform_driver sdhci_s3c_driver = { .probe = sdhci_s3c_probe, .remove = __devexit_p(sdhci_s3c_remove), @@ -637,6 +647,7 @@ static struct platform_driver sdhci_s3c_driver = { .driver = { .owner = THIS_MODULE, .name = s3c-sdhci, + .of_match_table = s3c_sdhci_match, }, }; -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2 v2] ARM: mach-shmobile: use GPIO interrupt also for card eject on SDHI0 on mackerel
On Fri, 15 Jul 2011, Magnus Damm wrote: On Fri, Jul 15, 2011 at 7:59 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: When we switch to transaction-based runtime PM on SDHI / TMIO MMC, also card eject events will have to be detected by the platform. This patch prepares mackerel to this switch. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: reconfiguring the pin for card insertion and ejection is no longer needed. Hi Guennadi, Thanks for your work on this. I may be reading the code wrong, or perhaps my stack of patches is not the same as yours, but I can't see any code dealing with hotplug for SDHI2? It looks to me that your patch is updating the comment about PORT162 and IRQ0 but does nothing about it on the software side. I sort of assume that we want to have hotplug support via IRQ on all SDHI channels if possible. But maybe that's not possible? Maybe;-) I've spent quite a bit of time trying to make SDHI2 work according to the same scheme, but so far I failed. With a kernel, patched to produce GPIO interrupts from SDHI2 card insertion, as soon as I insert a card the board locks up hard without a single character on any of the consoles... So, I'm afraid, we have to leave SDHI2 alone for now. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] mmc: sdhci-s3c: Add support for device tree based probe
On Fri, Jul 15, 2011 at 05:12:06PM +0530, Thomas Abraham wrote: Add of_match_table to enable sdhci-s3c driver to be probed when a compatible sdhci device node is found in device tree. CC: linux-mmc@vger.kernel.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- .../devicetree/bindings/mmc/samsung-s3c-sdhci.txt | 10 ++ drivers/mmc/host/sdhci-s3c.c | 11 +++ 2 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt diff --git a/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt b/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt new file mode 100644 index 000..c2298f8 --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/samsung-s3c-sdhci.txt @@ -0,0 +1,10 @@ +* Samsung's SDHCI controller + +The Samsung's SDHCI controller is used for interfacing with SD/MMC cards. + +Required properties: +- compatible : should be samsung,s3c-sdhci +- reg : base physical address of the controller and length of memory mapped + region. +- interrupts : interrupt number to the cpu. + diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 69e3ee3..5ccbee0 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -629,6 +629,16 @@ static int sdhci_s3c_resume(struct platform_device *dev) #define sdhci_s3c_resume NULL #endif +#ifdef CONFIG_OF +static const struct of_device_id s3c_sdhci_match[] = { + { .compatible = samsung,s3c-sdhci }, Be specific. samsung,exynos4210-sdhci. Newer chips can claim compatibility with the older one. Otherwise, Acked-by: Grant Likely grant.lik...@secretlab.ca + {}, +}; +MODULE_DEVICE_TABLE(of, s3c_sdhci_match); +#else +#define s3c_sdhci_match NULL +#endif + static struct platform_driver sdhci_s3c_driver = { .probe = sdhci_s3c_probe, .remove = __devexit_p(sdhci_s3c_remove), @@ -637,6 +647,7 @@ static struct platform_driver sdhci_s3c_driver = { .driver = { .owner = THIS_MODULE, .name = s3c-sdhci, + .of_match_table = s3c_sdhci_match, }, }; -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] maximum discard size
On 28/06/2011 5:16 p.m., Adrian Hunter wrote: Hi Here is a patch that sets a maximum discard size for host controllers that cannot manage large timeouts. And another patch putting it into use for shdci. Can this be applied? Adrian Hunter (2): mmc: queue: let host controllers specify maximum discard timeout mmc: sdhci: specify maximum discard timeout drivers/mmc/card/queue.c | 33 ++-- drivers/mmc/core/core.c | 76 ++ drivers/mmc/host/sdhci.c |5 +++ include/linux/mmc/core.h |1 + include/linux/mmc/host.h |1 + 5 files changed, 106 insertions(+), 10 deletions(-) Regards Adrian Hunter -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Bug 38922] Lenovo T420 (Sandy Bridge) Crashes on SD Card gpt partition writing and io errors on insert
Hi, moving to e-mail, On Fri, Jul 15 2011, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=38922 Andrei, please could you take a look at this bug? --- Comment #6 from Peter Vollmer vollmerpe...@googlemail.com 2011-07-15 19:06:22 --- Hi Chris, first of all thanks for your help. I'm finish with some of your tips: The tip of comment #4 doesen't work. I've got the error message that the config wasn't able to load. Also the cardreader doesn't work. The other thing I've done was the bisection thing. The result is this commit: a3c7778f8153b9e4eceea6738973280b9e63c618 is the first bad commit commit a3c7778f8153b9e4eceea6738973280b9e63c618 Author: Andrei Warkentin andr...@motorola.com Date: Mon Apr 11 16:13:42 2011 -0500 mmc: sdhci: R1B command handling + MMC_CAP_ERASE. ERASE command needs R1B response, so fix R1B-type command handling for SDHCI controller. For non-DAT commands using a busy response, the cmd-cmd_timeout_ms (in ms) field is used for timeout calculations. Based on patch by Chuanxiao Dong chuanxiao.d...@intel.com Signed-off-by: Andrei Warkentin andr...@motorola.com Signed-off-by: Chris Ball c...@laptop.org :04 04 900ad3058ed393172ff7e68a2240a5404c28bfbb bb4a8b4bd336b0a53b8f90ebc37d16929e5ccfd4 Mdrivers I hope I can help to resolve this problem. Thanks very much for the bisection, Peter. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] mxs-mmc: fix clock rate setting
Hi Koen, On Fri, Jul 15 2011, Koen Beel wrote: Still need me to do something on this or is it ok? Pushed to mmc-next for 3.1, thanks. Please consider Wolfram's last round of comments and send a follow-up patch if you agree with them. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] maximum discard size
Hi Adrian, On Fri, Jul 15 2011, Adrian Hunter wrote: Here is a patch that sets a maximum discard size for host controllers that cannot manage large timeouts. And another patch putting it into use for shdci. Can this be applied? Adrian Hunter (2): mmc: queue: let host controllers specify maximum discard timeout mmc: sdhci: specify maximum discard timeout These two are already in mmc-next for 3.1 -- looks like I forgot to send an e-mail letting you know I'd merged them, sorry. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html