Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Dne Pá 22. října 2010 16:09:03 zhangfei gao napsal(a):
On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball c...@laptop.org wrote:
Hi,
On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
[...]
+#ifdef CONFIG_PM
+static int sdhci_pxa_suspend(struct platform_device *dev)
+{
+ struct sdhci_host *host =
platform_get_drvdata(to_platform_device(dev)); +
+ return sdhci_suspend_host(host, state);
+}
+
+static int sdhci_pxa_resume(struct platform_device *dev)
+{
These prototypes are not correct, leading to:
CC [M] drivers/mmc/host/sdhci-pxa.o
drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_suspend’:
drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from
incompatible pointer type drivers/mmc/host/sdhci-pxa.c:207: error:
‘state’ undeclared (first use in this function)
drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is
reported only once drivers/mmc/host/sdhci-pxa.c:207: error: for each
function it appears in.) drivers/mmc/host/sdhci-pxa.c: In function
‘sdhci_pxa_resume’:
drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from
incompatible pointer type drivers/mmc/host/sdhci-pxa.c: At top level:
drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from
incompatible pointer type drivers/mmc/host/sdhci-pxa.c:223: warning:
initialization from incompatible pointer type
when compiled with CONFIG_PM=y.
--
Chris Ball c...@laptop.org http://printf.net/
One Laptop Per Child
Sorry, forgot open CONFIG_PM.
Updated patch, thanks
From 88e7f028433fe87b211bf3d75b54261979d0d176 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao zhangfei@marvell.com
Date: Mon, 20 Sep 2010 10:51:28 -0400
Subject: [PATCH] mmc: add support of sdhci-pxa driver
Support Marvell PXA168/PXA910/MMP2 SD Host Controller
Signed-off-by: Zhangfei Gao zhangfei@marvell.com
Acked-by: Haojian Zhuang haojian.zhu...@marvell.com
---
arch/arm/plat-pxa/include/plat/sdhci.h | 32
drivers/mmc/host/Kconfig | 12 ++
drivers/mmc/host/Makefile |1 +
drivers/mmc/host/sdhci-pxa.c | 254
4 files changed, 299 insertions(+), 0
deletions(-)
create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h
create mode 100644 drivers/mmc/host/sdhci-pxa.c
diff --git a/arch/arm/plat-pxa/include/plat/sdhci.h
b/arch/arm/plat-pxa/include/plat/sdhci.h
new file mode 100644
index 000..38e86ad
--- /dev/null
+++ b/arch/arm/plat-pxa/include/plat/sdhci.h
@@ -0,0 +1,32 @@
+/* linux/arch/arm/plat-pxa/include/plat/sdhci.h
+ *
+ * Copyright 2010 Marvell
+ * Zhangfei Gao zhangfei@marvell.com
+ *
+ * PXA Platform - SDHCI platform data definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __PLAT_PXA_SDHCI_H
+#define __PLAT_PXA_SDHCI_H
+
+/* pxa specific flag */
+/* Require clock free running */
+#define PXA_FLAG_DISABLE_CLOCK_GATING (10)
+
+/**
+ * struct pxa_sdhci_platdata() - Platform device data for PXA SDHCI
+ * @max_speed: The maximum speed supported.
+ * @quirks: quirks of specific device
+ * @flags: flags for platfrom requirement
+*/
+struct sdhci_pxa_platdata {
+ unsigned intmax_speed;
+ unsigned intquirks;
+ unsigned intflags;
+};
+
+#endif /* __PLAT_PXA_SDHCI_H */
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index c9c2520..c387402 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -155,6 +155,18 @@ config MMC_SDHCI_S3C
If unsure, say N.
+config MMC_SDHCI_PXA
+ tristate Marvell PXA168/PXA910/MMP2 SD Host Controller support
+ depends on ARCH_PXA || ARCH_MMP
+ select MMC_SDHCI
+ select MMC_SDHCI_IO_ACCESSORS
+ help
+ This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
+ If you have a PXA168/PXA910/MMP2 platform with SD Host Controller and
a
+ card slot,say Y or M here.
+
+ If unsure, say N.
+
config MMC_SDHCI_SPEAR
tristate SDHCI support on ST SPEAr platform
depends on MMC_SDHCI PLAT_SPEAR
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index 6c4ac67..7b645ff 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_MMC_IMX) += imxmmc.o
obj-$(CONFIG_MMC_MXC)+= mxcmmc.o
obj-$(CONFIG_MMC_SDHCI) += sdhci.o
obj-$(CONFIG_MMC_SDHCI_PCI) += sdhci-pci.o
+obj-$(CONFIG_MMC_SDHCI_PXA) += sdhci-pxa.o
obj-$(CONFIG_MMC_SDHCI_S3C) += sdhci-s3c.o
obj-$(CONFIG_MMC_SDHCI_SPEAR)+= sdhci-spear.o
obj-$(CONFIG_MMC_WBSD) += wbsd.o
diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c
new file mode 100644
index
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
On Thu, Oct 21, 2010 at 10:52 PM, Chris Ball c...@laptop.org wrote: Hi, On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: Update with comments from Matt and Eric. Test with sd and emmc. From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [PATCH] mmc: add support of sdhci-pxa driver Support Marvell PXA168/PXA910/MMP2 SD Host Controller Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h | 32 drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-pxa.c | 259 4 files changed, 304 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h create mode 100644 drivers/mmc/host/sdhci-pxa.c I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ patch through the ARM tree. Oh. If we do that then the driver won't compile until everything's together, because it #includes plat/sdhci.h. Haojian/Eric, what do you prefer here? Should I take the arch/arm/ hunk via the MMC tree? (If so, please provide ACKs.) Acked-by: Haojian Zhuang. I'm fine on this. Please merge it via the MMC tree. Thanks Haojian -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Hi Russell,
On Fri, Oct 22, 2010 at 04:44:07PM +0800, Haojian Zhuang wrote:
I'm fine on this. Please merge it via the MMC tree.
I'm planning on merging this patch via the MMC tree, please let me know
if you object. Thanks.
From: Zhangfei Gao zhangfei@marvell.com
Date: Mon, 20 Sep 2010 10:51:28 -0400
Subject: [PATCH] mmc: add new sdhci-pxa driver for Marvell SoCs
Support Marvell PXA168/PXA910/MMP2 SD Host Controller.
Signed-off-by: Zhangfei Gao zhangfei@marvell.com
Acked-by: Haojian Zhuang haojian.zhu...@marvell.com
Signed-off-by: Chris Ball c...@laptop.org
---
arch/arm/plat-pxa/include/plat/sdhci.h | 32
drivers/mmc/host/Kconfig | 12 ++
drivers/mmc/host/Makefile |1 +
drivers/mmc/host/sdhci-pxa.c | 258
4 files changed, 303 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h
create mode 100644 drivers/mmc/host/sdhci-pxa.c
diff --git a/arch/arm/plat-pxa/include/plat/sdhci.h
b/arch/arm/plat-pxa/include/plat/sdhci.h
new file mode 100644
index 000..3e3c728
--- /dev/null
+++ b/arch/arm/plat-pxa/include/plat/sdhci.h
@@ -0,0 +1,32 @@
+/* linux/arch/arm/plat-pxa/include/plat/sdhci.h
+ *
+ * Copyright 2010 Marvell
+ * Zhangfei Gao zhangfei@marvell.com
+ *
+ * PXA Platform - SDHCI platform data definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __PLAT_PXA_SDHCI_H
+#define __PLAT_PXA_SDHCI_H
+
+/* pxa specific flag */
+/* Require clock free running */
+#define PXA_FLAG_DISABLE_CLOCK_GATING (10)
+
+/**
+ * struct pxa_sdhci_platdata() - Platform device data for PXA SDHCI
+ * @max_speed: the maximum speed supported
+ * @quirks: quirks of specific device
+ * @flags: flags for platform requirement
+*/
+struct sdhci_pxa_platdata {
+ unsigned intmax_speed;
+ unsigned intquirks;
+ unsigned intflags;
+};
+
+#endif /* __PLAT_PXA_SDHCI_H */
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index c9c2520..40b0fb9 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -155,6 +155,18 @@ config MMC_SDHCI_S3C
If unsure, say N.
+config MMC_SDHCI_PXA
+ tristate Marvell PXA168/PXA910/MMP2 SD Host Controller support
+ depends on ARCH_PXA || ARCH_MMP
+ select MMC_SDHCI
+ select MMC_SDHCI_IO_ACCESSORS
+ help
+ This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
+ If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
+ and a card slot, say Y or M here.
+
+ If unsure, say N.
+
config MMC_SDHCI_SPEAR
tristate SDHCI support on ST SPEAr platform
depends on MMC_SDHCI PLAT_SPEAR
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index 6c4ac67..7b645ff 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_MMC_IMX) += imxmmc.o
obj-$(CONFIG_MMC_MXC) += mxcmmc.o
obj-$(CONFIG_MMC_SDHCI)+= sdhci.o
obj-$(CONFIG_MMC_SDHCI_PCI)+= sdhci-pci.o
+obj-$(CONFIG_MMC_SDHCI_PXA)+= sdhci-pxa.o
obj-$(CONFIG_MMC_SDHCI_S3C)+= sdhci-s3c.o
obj-$(CONFIG_MMC_SDHCI_SPEAR) += sdhci-spear.o
obj-$(CONFIG_MMC_WBSD) += wbsd.o
diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c
new file mode 100644
index 000..aeba3e3
--- /dev/null
+++ b/drivers/mmc/host/sdhci-pxa.c
@@ -0,0 +1,258 @@
+/* linux/drivers/mmc/host/sdhci-pxa.c
+ *
+ * Copyright (C) 2010 Marvell International Ltd.
+ * Zhangfei Gao zhangfei@marvell.com
+ * Kevin Wang dwa...@marvell.com
+ * Mingwei Wang mww...@marvell.com
+ * Philip Rakity prak...@marvell.com
+ * Mark Brown ma...@marvell.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/* Supports:
+ * SDHCI support for MMP2/PXA910/PXA168
+ *
+ * Refer to sdhci-s3c.c.
+ */
+
+#include linux/delay.h
+#include linux/platform_device.h
+#include linux/mmc/host.h
+#include linux/clk.h
+#include linux/io.h
+#include linux/err.h
+#include plat/sdhci.h
+#include sdhci.h
+
+#define DRIVER_NAMEsdhci-pxa
+
+#define SD_FIFO_PARAM 0x104
+#define DIS_PAD_SD_CLK_GATE0x400
+
+struct sdhci_pxa {
+ struct sdhci_host *host;
+ struct sdhci_pxa_platdata *pdata;
+ struct clk *clk;
+ struct resource *res;
+
+ u8 clk_enable;
+};
+
+/*\
+ * *
+ * SDHCI core callbacks
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Hi,
On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
[...]
+#ifdef CONFIG_PM
+static int sdhci_pxa_suspend(struct platform_device *dev)
+{
+ struct sdhci_host *host = platform_get_drvdata(to_platform_device(dev));
+
+ return sdhci_suspend_host(host, state);
+}
+
+static int sdhci_pxa_resume(struct platform_device *dev)
+{
These prototypes are not correct, leading to:
CC [M] drivers/mmc/host/sdhci-pxa.o
drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_suspend’:
drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c:207: error: ‘state’ undeclared (first use in this
function)
drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is
reported only once
drivers/mmc/host/sdhci-pxa.c:207: error: for each function it appears in.)
drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_resume’:
drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c: At top level:
drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c:223: warning: initialization from incompatible
pointer type
when compiled with CONFIG_PM=y.
--
Chris Ball c...@laptop.org http://printf.net/
One Laptop Per Child
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball c...@laptop.org wrote:
Hi,
On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
[...]
+#ifdef CONFIG_PM
+static int sdhci_pxa_suspend(struct platform_device *dev)
+{
+ struct sdhci_host *host =
platform_get_drvdata(to_platform_device(dev));
+
+ return sdhci_suspend_host(host, state);
+}
+
+static int sdhci_pxa_resume(struct platform_device *dev)
+{
These prototypes are not correct, leading to:
CC [M] drivers/mmc/host/sdhci-pxa.o
drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_suspend’:
drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c:207: error: ‘state’ undeclared (first use in
this function)
drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is
reported only once
drivers/mmc/host/sdhci-pxa.c:207: error: for each function it appears in.)
drivers/mmc/host/sdhci-pxa.c: In function ‘sdhci_pxa_resume’:
drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c: At top level:
drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from incompatible
pointer type
drivers/mmc/host/sdhci-pxa.c:223: warning: initialization from incompatible
pointer type
when compiled with CONFIG_PM=y.
--
Chris Ball c...@laptop.org http://printf.net/
One Laptop Per Child
Sorry, forgot open CONFIG_PM.
Updated patch, thanks
From 88e7f028433fe87b211bf3d75b54261979d0d176 Mon Sep 17 00:00:00 2001
From: Zhangfei Gao zhangfei@marvell.com
Date: Mon, 20 Sep 2010 10:51:28 -0400
Subject: [PATCH] mmc: add support of sdhci-pxa driver
Support Marvell PXA168/PXA910/MMP2 SD Host Controller
Signed-off-by: Zhangfei Gao zhangfei@marvell.com
Acked-by: Haojian Zhuang haojian.zhu...@marvell.com
---
arch/arm/plat-pxa/include/plat/sdhci.h | 32
drivers/mmc/host/Kconfig | 12 ++
drivers/mmc/host/Makefile |1 +
drivers/mmc/host/sdhci-pxa.c | 254
4 files changed, 299 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h
create mode 100644 drivers/mmc/host/sdhci-pxa.c
diff --git a/arch/arm/plat-pxa/include/plat/sdhci.h
b/arch/arm/plat-pxa/include/plat/sdhci.h
new file mode 100644
index 000..38e86ad
--- /dev/null
+++ b/arch/arm/plat-pxa/include/plat/sdhci.h
@@ -0,0 +1,32 @@
+/* linux/arch/arm/plat-pxa/include/plat/sdhci.h
+ *
+ * Copyright 2010 Marvell
+ * Zhangfei Gao zhangfei@marvell.com
+ *
+ * PXA Platform - SDHCI platform data definitions
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __PLAT_PXA_SDHCI_H
+#define __PLAT_PXA_SDHCI_H
+
+/* pxa specific flag */
+/* Require clock free running */
+#definePXA_FLAG_DISABLE_CLOCK_GATING (10)
+
+/**
+ * struct pxa_sdhci_platdata() - Platform device data for PXA SDHCI
+ * @max_speed: The maximum speed supported.
+ * @quirks: quirks of specific device
+ * @flags: flags for platfrom requirement
+*/
+struct sdhci_pxa_platdata {
+ unsigned intmax_speed;
+ unsigned intquirks;
+ unsigned intflags;
+};
+
+#endif /* __PLAT_PXA_SDHCI_H */
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index c9c2520..c387402 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -155,6 +155,18 @@ config MMC_SDHCI_S3C
If unsure, say N.
+config MMC_SDHCI_PXA
+ tristate Marvell PXA168/PXA910/MMP2 SD Host Controller support
+ depends on ARCH_PXA || ARCH_MMP
+ select MMC_SDHCI
+ select MMC_SDHCI_IO_ACCESSORS
+ help
+ This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
+ If you have a PXA168/PXA910/MMP2 platform with SD Host Controller and
a
+ card slot,say Y or M here.
+
+ If unsure, say N.
+
config MMC_SDHCI_SPEAR
tristate SDHCI support on ST SPEAr platform
depends on MMC_SDHCI PLAT_SPEAR
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index 6c4ac67..7b645ff 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_MMC_IMX) += imxmmc.o
obj-$(CONFIG_MMC_MXC) += mxcmmc.o
obj-$(CONFIG_MMC_SDHCI)+= sdhci.o
obj-$(CONFIG_MMC_SDHCI_PCI)+= sdhci-pci.o
+obj-$(CONFIG_MMC_SDHCI_PXA)+= sdhci-pxa.o
obj-$(CONFIG_MMC_SDHCI_S3C)+= sdhci-s3c.o
obj-$(CONFIG_MMC_SDHCI_SPEAR) += sdhci-spear.o
obj-$(CONFIG_MMC_WBSD) += wbsd.o
diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c
new file mode 100644
index 000..abf208c
--- /dev/null
+++ b/drivers/mmc/host/sdhci-pxa.c
@@ -0,0 +1,254 @@
+/* linux/drivers/mmc/host/sdhci-pxa.c
+ *
+ * Copyright (C) 2010 Marvell International Ltd.
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
On Thu, Oct 21, 2010 at 10:13 PM, Chris Ball c...@laptop.org wrote: Hi Zhangfei, On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: Update with comments from Matt and Eric. Test with sd and emmc. From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [PATCH] mmc: add support of sdhci-pxa driver Support Marvell PXA168/PXA910/MMP2 SD Host Controller Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h | 32 drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-pxa.c | 259 4 files changed, 304 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h create mode 100644 drivers/mmc/host/sdhci-pxa.c I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ patch through the ARM tree. Thanks a lot, what a relief :) Thanks, -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Hi, On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: Update with comments from Matt and Eric. Test with sd and emmc. From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [PATCH] mmc: add support of sdhci-pxa driver Support Marvell PXA168/PXA910/MMP2 SD Host Controller Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h | 32 drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-pxa.c | 259 4 files changed, 304 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h create mode 100644 drivers/mmc/host/sdhci-pxa.c I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ patch through the ARM tree. Oh. If we do that then the driver won't compile until everything's together, because it #includes plat/sdhci.h. Haojian/Eric, what do you prefer here? Should I take the arch/arm/ hunk via the MMC tree? (If so, please provide ACKs.) Thanks, -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Dne Čt 21. října 2010 16:52:49 Chris Ball napsal(a): Hi, On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: Update with comments from Matt and Eric. Test with sd and emmc. From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao zhangfei@marvell.com Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [PATCH] mmc: add support of sdhci-pxa driver Support Marvell PXA168/PXA910/MMP2 SD Host Controller Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h | 32 drivers/mmc/host/Kconfig | 12 ++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-pxa.c | 259 4 files changed, 304 insertions(+), 0 deletions(-) create mode 100644 arch/arm/plat-pxa/include/plat/sdhci.h create mode 100644 drivers/mmc/host/sdhci-pxa.c I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ patch through the ARM tree. Oh. If we do that then the driver won't compile until everything's together, because it #includes plat/sdhci.h. Haojian/Eric, what do you prefer here? Should I take the arch/arm/ hunk via the MMC tree? (If so, please provide ACKs.) Thanks, Hi, where can I find the whole driver so I can take a look? It didn't crash into linux-arm-kernel for some reason. Thanks -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Hi Marek, On Fri, Oct 22, 2010 at 02:20:10AM +0200, Marek Vasut wrote: I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ patch through the ARM tree. Oh. If we do that then the driver won't compile until everything's together, because it #includes plat/sdhci.h. Haojian/Eric, what do you prefer here? Should I take the arch/arm/ hunk via the MMC tree? (If so, please provide ACKs.) Hi, where can I find the whole driver so I can take a look? It didn't crash into linux-arm-kernel for some reason. Here it is: http://thread.gmane.org/gmane.linux.kernel.mmc/4190 -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: Update with comments from Matt and Eric. Test with sd and emmc. Sorry if I am blind, but why again can't you use the (updated) platform driver? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver
Currently platform driver can not support well of the requirement for several device sharing one driver, each one has different quirk, different max_speed, and each device need some specific vectors. We prefer using independent driver first. What about a custom init-call reading out the platform_data? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
