Re: [PATCH v3 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5
Shawn Guo shawn@freescale.com writes: Hi Arnaud, Hi, Would you please give a test on the series, as it fixed the issue you reported? TIA. I've tested it yesterday on my efika platforms and the issue is gone. Moreover, the differents card slot on theses platforms are using each card detect type (internally connected, gpio, no card detect) and they are all working as expected. I'm a little bit annoyed by the polling on the slot without card detect but this has nothing to do with this patchset. Side note: turns out that the driver is using dev_warn when failing to get cd gpio/irq. Given that in theses cases, it jumps to no_card_detect_pin and makes the probe fail, maybe a dev_err would be better ? Tested-by: Arnaud Patard arnaud.pat...@rtp-net.org Thanks, Arnaud -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5
On Tue, Jun 21, 2011 at 11:44:00AM +0200, Arnaud Patard wrote: Shawn Guo shawn@freescale.com writes: Hi Arnaud, Hi, Would you please give a test on the series, as it fixed the issue you reported? TIA. I've tested it yesterday on my efika platforms and the issue is gone. Moreover, the differents card slot on theses platforms are using each card detect type (internally connected, gpio, no card detect) and they are all working as expected. I'm a little bit annoyed by the polling on the slot without card detect but this has nothing to do with this patchset. That's great. Side note: turns out that the driver is using dev_warn when failing to get cd gpio/irq. Given that in theses cases, it jumps to no_card_detect_pin and makes the probe fail, maybe a dev_err would be better ? Though it's the existing code, I respect the comment and will make the change in the v4. Tested-by: Arnaud Patard arnaud.pat...@rtp-net.org Thanks for testing. -- Regards, Shawn -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5
Hi Arnaud, Would you please give a test on the series, as it fixed the issue you reported? TIA. -- Regards, Shawn On Mon, Jun 20, 2011 at 06:38:41PM +0800, Shawn Guo wrote: The card-present polling for sdhci based driver is very expensive in terms of the impact to system performance. We observe a few system performance issues from Freescale and Linaro on mx5 platforms, which have been proved card polling related. The patch set extends the current sdhci-esdhc-imx card_detect and write_protect support to cover mx5 platforms, and solves above performance issues. Changes since v2: * Fix the issue reported by Arnaud Patard: http://article.gmane.org/gmane.linux.ports.arm.kernel/120790 Changes since v1: * Rebase on today's linux-next * Take the suggestion from Arnaud Patard to add default pdata in imx_add_sdhci_esdhc_imx(), to avoid touching every single board file for the platform_data changes * Add comment for sdhci.c change * Change ESDHC_CD(WP)_SIGNAL to ESDHC_CD(WP)_CONTROLLER for a more descriptive name * Add missing NONE case handling in esdhc_pltfm_get_ro * Improve a couple comment wording per suggestion from Wolfram Sang Shawn Guo (4): mmc: sdhci: fix interrupt storm from card detection mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared mmc: sdhci-esdhc-imx: remove WP from flag ESDHC_FLAG_GPIO_FOR_CD_WP mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c |3 +- arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c |3 +- arch/arm/mach-imx/mach-mx25_3ds.c |2 + arch/arm/mach-imx/mach-pcm043.c|2 + arch/arm/mach-mx5/board-mx51_babbage.c | 14 +- arch/arm/mach-mx5/board-mx53_loco.c|4 + .../plat-mxc/devices/platform-sdhci-esdhc-imx.c| 12 ++ arch/arm/plat-mxc/include/mach/esdhc.h | 25 +++- drivers/mmc/host/sdhci-esdhc-imx.c | 136 drivers/mmc/host/sdhci.c | 27 - 10 files changed, 161 insertions(+), 67 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
