Re: [RFC PATCH 3.7.0-rc4 0/4] introduce of_simple_module_id_table macro

2012-11-20 Thread Grant Likely 
On Fri, 16 Nov 2012 13:21:08 +, Srinivas KANDAGATLA 
srinivas.kandaga...@st.com wrote:
 From: Srinivas Kandagatla srinivas.kandaga...@st.com
 
 This patch series introduces of_simple_module_id_table macro and as an example
 uses this macro in 3 files.
 
 Most of the device tree supported drivers have of_device_id table setup with 
 single compatible entry, this use-case is very simple and common.
 
 #ifdef CONFIG_OF
 static struct of_device_id xxx_of_match[] = {
   { .compatible = yyy,zzz },
   { },
 };
 MODULE_DEVICE_TABLE(of, xxx_of_match);
 #endif
 
 This patch adds a macro for this simple type of device table.
 Other subsystems like pm, platform, have similar macros in kernel for
 simplest cases.
 Now the user can just replace the above code with
 
 of_simple_module_id_table(xxx_of_match, yyy,zzz);
 
 There are more than 200+ hits for this type of pattern in the current kernel.

While I like the reduction in lines of source code, I'm not so fond of
the form. There is no easy way to extend the syntax for multiple
entries and it doesn't cover the frequently present .data field. Can you
think of a way to do this that can take a variable number of table
entries?

g.

--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC PATCH 3.7.0-rc4 0/4] introduce of_simple_module_id_table macro

2012-11-16 Thread Srinivas KANDAGATLA 
From: Srinivas Kandagatla srinivas.kandaga...@st.com

This patch series introduces of_simple_module_id_table macro and as an example
uses this macro in 3 files.

Most of the device tree supported drivers have of_device_id table setup with 
single compatible entry, this use-case is very simple and common.

#ifdef CONFIG_OF
static struct of_device_id xxx_of_match[] = {
{ .compatible = yyy,zzz },
{ },
};
MODULE_DEVICE_TABLE(of, xxx_of_match);
#endif

This patch adds a macro for this simple type of device table.
Other subsystems like pm, platform, have similar macros in kernel for
simplest cases.
Now the user can just replace the above code with

of_simple_module_id_table(xxx_of_match, yyy,zzz);

There are more than 200+ hits for this type of pattern in the current kernel.

Am happy to run a script to generate cleanup patches for the hits,
However I would like to know your overall opinion on this type of patch.

Thanks,
srini


Srinivas Kandagatla (4):
  of: introduce of_simple_module_id_table macro.
  mm:exynos: use of_simple_module_id_table macro.
  mm:sdhci-spear: use of_simple_module_id_table macro.
  mm:shmobile: use of_simple_module_id_table macro.

 drivers/mmc/host/dw_mmc-exynos.c  |7 +--
 drivers/mmc/host/sdhci-spear.c|8 +---
 drivers/mmc/host/sh_mobile_sdhi.c |6 +-
 include/linux/of.h|   10 ++
 4 files changed, 13 insertions(+), 18 deletions(-)

--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html