Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx
On Tue, Jul 19, 2011 at 10:10:27AM +0200, Sascha Hauer wrote: On Mon, Jul 18, 2011 at 09:51:28PM -0400, Chris Ball wrote: Hi Shawn, Sascha, On Sat, Jul 09 2011, Shawn Guo wrote: Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host mmc: sdhci-esdhc-imx: add device tree probe support These don't apply against mmc-next -- what is your tree based on? It's based on linux-next with following patch applied. [PATCH v4 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 http://permalink.gmane.org/gmane.linux.kernel.mmc/8748 You applied the 3 of 4 patches in that series, and expect Sascha to send this one through his tree after you send those 3. Shawn, please ping me once all dependencies have been merged. I have no influence when my patches get merged since my patches go via Arnd. Ok, will do. -- Regards, Shawn -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx
Hi Shawn, Sascha, On Sat, Jul 09 2011, Shawn Guo wrote: Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host mmc: sdhci-esdhc-imx: add device tree probe support These don't apply against mmc-next -- what is your tree based on? It's based on linux-next with following patch applied. [PATCH v4 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 http://permalink.gmane.org/gmane.linux.kernel.mmc/8748 You applied the 3 of 4 patches in that series, and expect Sascha to send this one through his tree after you send those 3. I see. In that case, either Sascha can send this new series with my: Acked-by: Chris Ball c...@laptop.org or I'll send it as a second pull request after Sascha sends [4/4]. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx
Hi Shawn, On Wed, Jul 06 2011, Shawn Guo wrote: The first patch copies platform data into driver private data, and do not reference platform data after probe. The second one removes the uses of cpu_is_mx(). The third one makes a dt related fix on sdhci-pltfm.c, and the last one adds actual device tree probe for sdhci-esdhc-imx driver. Changes since v2: * Add patch #1 * Do not use Linux details of cd-type and wp-type for binding Changes since v1: * Address review comments given by Grant Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host mmc: sdhci-esdhc-imx: add device tree probe support These don't apply against mmc-next -- what is your tree based on? Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx
Hi Chris, On Sat, Jul 09, 2011 at 06:14:43PM -0400, Chris Ball wrote: Hi Shawn, On Wed, Jul 06 2011, Shawn Guo wrote: The first patch copies platform data into driver private data, and do not reference platform data after probe. The second one removes the uses of cpu_is_mx(). The third one makes a dt related fix on sdhci-pltfm.c, and the last one adds actual device tree probe for sdhci-esdhc-imx driver. Changes since v2: * Add patch #1 * Do not use Linux details of cd-type and wp-type for binding Changes since v1: * Address review comments given by Grant Shawn Guo (4): mmc: sdhci-esdhc-imx: do not reference platform data after probe mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx() mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host mmc: sdhci-esdhc-imx: add device tree probe support These don't apply against mmc-next -- what is your tree based on? It's based on linux-next with following patch applied. [PATCH v4 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 http://permalink.gmane.org/gmane.linux.kernel.mmc/8748 You applied the 3 of 4 patches in that series, and expect Sascha to send this one through his tree after you send those 3. Now, we got another series pending in the line. I'm wondering if it works that I create a branch off your mmc-next, merge Sascha's next, apply my patches on top it, and then send a pull request for you (and Sascha) to pull the branch. -- Regards, Shawn -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
