Re: NILFS2: double uuid
On Tue, 9 Jun 2015 16:07:42 +0200, Karel Zak wrote: > On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote: >> $ sudo nilfs-resize -y /dev/sdb1 1G >> Partition size = 2146435072 bytes. >> Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes. >> 128 segments will be truncated from segnum 127. >> Moving 103 in-use segments. >> progress |***| >> Done. >> >> $ sudo umount /test >> $ sudo mount /dev/sdb1 /test >> $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f >> NAME FSTYPE LABEL UUID MOUNTPOINT >> [...] >> sdb >> `-sdb1 /test >> >> This blank state continued until I shrank the partition or >> re-extended the filesystem to the partition size. >> >> Could you consider confining the s_dev_size test only to the >> backup superblock ? > > Hmm... why nilfs-resize does not update the size in the superblock? > It seems like nilfs-resize bug. nilfs-resize (to be exact, RESIZE ioctl of nilfs2) updates s_dev_size in both superblocks. What nilfs-resize doesn't change is the partition size. (It needs help of a partitioning tool) > >> It seems that we don't have to drop the primary super block >> even if s_dev_size doesn't fit to the partition size. > > Yes, fixed. I have also enabled the s_dev_size check for whole-disk > devices only to minimize number of situations when we rely on the > s_dev_size. > > Karel Thanks again. The updated libblkid/lsblk works frawlessly. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: NILFS2: double uuid
On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote: > $ sudo nilfs-resize -y /dev/sdb1 1G > Partition size = 2146435072 bytes. > Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes. > 128 segments will be truncated from segnum 127. > Moving 103 in-use segments. > progress |***| > Done. > > $ sudo umount /test > $ sudo mount /dev/sdb1 /test > $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f > NAME FSTYPE LABEL UUID MOUNTPOINT > [...] > sdb > `-sdb1 /test > > This blank state continued until I shrank the partition or > re-extended the filesystem to the partition size. > > Could you consider confining the s_dev_size test only to the > backup superblock ? Hmm... why nilfs-resize does not update the size in the superblock? It seems like nilfs-resize bug. > It seems that we don't have to drop the primary super block > even if s_dev_size doesn't fit to the partition size. Yes, fixed. I have also enabled the s_dev_size check for whole-disk devices only to minimize number of situations when we rely on the s_dev_size. Karel -- Karel Zak http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: NILFS2: double uuid
Hi, On 2015/06/09 17:53, Karel Zak wrote: On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote: It looks like the backup super block should be dropped from candidates if its device size (sbp->s_dev_size) doesn't match the partition size. Yeah, fixed: http://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=00817742ce360119e079a33e12cf84118ff7c63e Note that workaround is to not use nilfs2 on the last partition or have a tiny gap (1 sector is enough) between last partition and the end of the whole-disk. Karel Thanks for your quick work! I tested the patch. It almost worked fine. One issue I found is a transient state after fs-resizing. After shrinking the file system, both superblocks dropped and lsblk failed to detect the filesystem: $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f NAME FSTYPE LABEL UUID MOUNTPOINT [...] sdb `-sdb1 nilfs2 2d7cd130-82a0-4a3c-b8a8-4ac5a26f5703 /test $ sudo nilfs-resize -y /dev/sdb1 1G Partition size = 2146435072 bytes. Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes. 128 segments will be truncated from segnum 127. Moving 103 in-use segments. progress |***| Done. $ sudo umount /test $ sudo mount /dev/sdb1 /test $ sudo LD_LIBRARY_PATH=/usr/local/lib lsblk -f NAME FSTYPE LABEL UUID MOUNTPOINT [...] sdb `-sdb1 /test This blank state continued until I shrank the partition or re-extended the filesystem to the partition size. Could you consider confining the s_dev_size test only to the backup superblock ? It seems that we don't have to drop the primary super block even if s_dev_size doesn't fit to the partition size. Regards, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: NILFS2: double uuid
On 09.06.2015, Karel Zak wrote: > Yeah, fixed: [] Thanks a lot to both of you! Tried both solutions and can confirm that they work both. -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: NILFS2: double uuid
On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote: > It looks like the backup super block should be dropped from candidates > if its device size (sbp->s_dev_size) doesn't match the partition size. Yeah, fixed: http://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=00817742ce360119e079a33e12cf84118ff7c63e Note that workaround is to not use nilfs2 on the last partition or have a tiny gap (1 sector is enough) between last partition and the end of the whole-disk. Karel -- Karel Zak http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
