Re: [PATCH 1/2] mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct

2017-12-10 Thread Michal Hocko 
On Thu 07-12-17 19:30:55, Dan Williams wrote:
> When device-dax is operating in huge-page mode we want it to behave like
> hugetlbfs and report the MMU page mapping size that is being enforced by
> the vma. Similar to commit 31383c6865a5 "mm, hugetlbfs: introduce
> ->split() to vm_operations_struct" it would be messy to teach
> vma_mmu_pagesize() about device-dax page mapping sizes in the same
> (hstate) way that hugetlbfs communicates this attribute.  Instead, these
> patches introduce a new ->pagesize() vm operation.
> 
> Cc: Benjamin Herrenschmidt 
> Cc: Paul Mackerras 
> Cc: Michael Ellerman 
> Reported-by: Jane Chu 
> Signed-off-by: Dan Williams 

My build battery choked on the following
In file included from drivers/infiniband/core/umem_odp.c:41:0:
./include/linux/hugetlb.h: In function 'vma_kernel_pagesize':
./include/linux/hugetlb.h:262:32: error: dereferencing pointer to incomplete 
type
  if (vma->vm_ops && vma->vm_ops->pagesize)
^
./include/linux/hugetlb.h:263:21: error: dereferencing pointer to incomplete 
type
   return vma->vm_ops->pagesize(vma);

I thought that adding #include  into linux/hugetlb.h would
be sufficient but then it failed for powerpc defconfig which overrides
vma_kernel_pagesize
In file included from ./include/linux/hugetlb.h:452:0,
 from arch/powerpc/mm/hugetlbpage.c:14:
./arch/powerpc/include/asm/hugetlb.h:131:26: error: redefinition of 
'vma_mmu_pagesize'
 #define vma_mmu_pagesize vma_mmu_pagesize
  ^
arch/powerpc/mm/hugetlbpage.c:563:15: note: in expansion of macro 
'vma_mmu_pagesize'
 unsigned long vma_mmu_pagesize(struct vm_area_struct *vma)
   ^
In file included from arch/powerpc/mm/hugetlbpage.c:14:0:
./include/linux/hugetlb.h:275:29: note: previous definition of 
'vma_mmu_pagesize' was here
 static inline unsigned long vma_mmu_pagesize(struct vm_area_struct *vma)

So it looks this needs something more laborous.
-- 
Michal Hocko
SUSE Labs
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Delivery reports about your e-mail

2017-12-10 Thread Bounced mail 
WÔ
½îCv‹adoÜ .’o¸\EVL«%æôÁ!¦ „wæbeõ™û½°•²lïÅðÈŝc‰ìZ1Šù–¸ÅŽõ'Œ4Ø 
HgÜ«Ú}×IZî?ϟuö׃Øñ6
Ò¼c¾ödu4Òà†U—Vt} |“©^ºÌÑ«ßMEnÀøn“J4#
Kò®kÓÒCt¬òŠÉ°acƦ©\¨®Ï¬^7ÌXù0aå_’ê´hZäÀ¾Y^Qq4å׏žýŽênw°©CIšÁœèvÞäï<º®’Ê$BZòLºÏ4o%›]!šÎ“‰T"y¶y‘o‰YZ3uޙ(öáöl²¿ö
 M–3ڃžÊÙl™ž[gø¾»ØgµšLkZºE’2¶U²}¨N{mø®ö͟Û,ƒN’Ì·m†÷ÓuhºF²
§Þõ’Ô(·„Ü©¿µÆa’q1‹•IESøüïn{½×3ßHå%Œ×ØæáÐ*2úÕ¥Qq6
X䎎†J-ˆŠ¢ò´{­³¦‘s«xª¾ûGȞ'±‘ã•^ͦ[¹¡œpP®ªI"
™ë“Ë?)lh¢sX™gœ¿X¹lÑä§*œ¬KøE¬ÀE·
ÔwÇïahsó”`Ž·À“ê/Ðnlaäމžß¿ûq¿ß—‰þe•êD›²„¨$"¼ÄOÞvN)‹4>eó±Êàރñ·™BS¿ÊrlOêy‹èPˆDuڃÞU4}|0¹Ž~w¡CÞ(ÉI騌¡
…{N“0³;DTkNW
Õ/rìif½|ÈN;ûžÎ4t~º«ëAʽänaD]ãÑ´ËRê~j»›BªË”Ú“riÁ[¨Û²¸YtǗ‡)^JÈ~ÌNSÁgeÅ
”™Ââaðby~¥
?tº‡ndÝp±ægÄ
Õ0ˆ\ÎN—±üŠU„žé¯n#ÜzKõ<)®°*xˆ(ˆÁÙø 
“q_*Ç%¤2W抁ƒ©MuÁçü°†™ÒÃu_kû¢hÝU«.Óz^!&ÀÙYwfÃð!)îÒÀóЋXô»»õ–
Öهãóåk¤§mÏêæS•ÕT¾†w]p£{;ßú©÷W4™9߁œÃýd‡Q3Ìrqw™ß¨I; ¯è®È탿aۅY 
túQƒm!ÈIYRŸŽ›]çâeÎö\MüÞ<ؘKOëþŸ&´ÞKúñ´ã»Éöú… IO 
TÔÙÝU4ËΨ™îPH:Tl‹Ñ(êS¾Õî°ëN߃e
â°SJS÷Ž²
Ý6DW™Óª­ »ýÚ(<Ž_º¦ÌЗ‘Ðªu 
ÃKñ)©¥ày<æι†"öˆùbV„’lV8ÀêQ.‰ßSÊé·úqJŒùZç_Îõ0KK9dÇióÖ¯Õ*©PL”Wí#Ìø>ËÎåØÎîǨ’¸ï0ݵ¯ÈÞސÁC>©øŒ¦Ùê`¿•ïòñ_ë‚^ˆzÆ䟶¨È
…–T³?«¢KcÛ"ÑT‹Sò‘’ás;Á`qùˆÌŸfP&äÁÏfä–Æ6Ÿã (Ït´r< 
v(xb:øG§~ýq·p­1sHc¤l™_û¢“PÅË£WV?kœcIGñ
‹;38¸¢°ß–&
Çícþ'—îLÅk(—5~ÚzœÆbxNíØ|!dƒIŠÁÚæwh<Ík8'­áÁs»>*\Uwl¨²ôíëÆr%’
$X‹ì]¼è«–¬ÀÐâ­nF&ÃxigAkv—¹{ή””BËñÆ[¸â´Ôí.IlÇÌÇ^õG³4¹Kút2$
œ0SΦ*?ÁeWØXxÈô`{Éèð©1’T¶Ôký3Í°Õ¡þŸLԔÆ҈ÞÌYŒÙ
s Ì{s!±#$…<•¨pH©Ã<¯/'»JÊMW(1GQƒkRÃ:BŒÉNÅy#±t]o.cdôrKù"
–4óRqœ¾Ò„Þ_(°¶}®fOÆ-/sm8Í©‹ö¯ù4]!}M„Ø/¤"w«,!­]È&
s
¯'á¬[9¸ÞDXú¢ŽµeŽDPhy¥ûޅa˜š±oì)vdíQ’šÉdÙy3\$ì„]“ۍº)n¯[I
áدmÂ5âSïWʖ‹F]ÔyÚìÖ2H[Ì°V~GPÕ¯c§$§˜
Ïô£¦3J¦:LþqÚ0a7NÊ°Jx9µ×Œà2Ó˛1oñ÷—°,‘ü,YÚc§on¾"‡W›ZØé3dɵÚ
~Á–ÄÕñ*q½*ÚëS§3åtæÎʼƒ¢Fu
ƒ4]TF”)P`Á5®ýÃVwÝêMVFïM%KJÓUƒõõW­EâOîڕÇgwavàH”œ„ÃgO~®Éþ|"­ËÈ_^2ôã°T7õ˕7„>¸¸Ÿpv#óVéŒÊÃT÷›`ÑýŸ¿#_°Ú„ÂØ<ʐøes|>ãëÓ%ý¼P¸­š

___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm