Re: [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs
On Thu, Sep 27, 2018 at 12:12 AM Johannes Thumshirn wrote: > > On Wed, Sep 26, 2018 at 09:24:20PM -0700, Dan Williams wrote: > > The Intel NVDIMM command specification publishes a dirty-shutdown-count > > in addition to the dirty-shutdown / flush-failed indication that comes > > from the ACPI NFIT. This is expected to be a common property of NVDIMMs > > and is a static hardware health detail to be cached / exported via > > sysfs. > > > > Add plumbing for retrieving this data at driver load time, publish the > > count, and use the dynamically retrieved dirty-shutdown indicator to > > augment the existing 'flush_failed' flag. > > Is this the same thing as the LSS Latch stuff that went into ndctl? It's a replacement. The latch mechanism is awkward especially when all that it needed is a rolling count of dirty-shutdown events. The expectation going forward is that the platform firmware will handle the latch, if it is present, and the OS need only consume the dirty-shutdown count. The ndctl implementation called libndctl apis from the udev queue which we discovered injects unnecessary udev queue drains / stalls into the boot path. Lastly, the userspace caching scheme for non-root users to consume the dirty-shutdown-count just isn't as efficient as teaching the kernel to cache this value and export it as a standard sysfs attribute. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs
On Thu, Sep 27, 2018 at 09:11:35AM +0200, Johannes Thumshirn wrote: > On Wed, Sep 26, 2018 at 09:24:20PM -0700, Dan Williams wrote: > > The Intel NVDIMM command specification publishes a dirty-shutdown-count > > in addition to the dirty-shutdown / flush-failed indication that comes > > from the ACPI NFIT. This is expected to be a common property of NVDIMMs > > and is a static hardware health detail to be cached / exported via > > sysfs. > > > > Add plumbing for retrieving this data at driver load time, publish the > > count, and use the dynamically retrieved dirty-shutdown indicator to > > augment the existing 'flush_failed' flag. > > Is this the same thing as the LSS Latch stuff that went into ndctl? On a related note, the ndctl latch implementation doesn't satisfy all the needs, so I expect it'll be reverted https://lists.01.org/pipermail/linux-nvdimm/2018-September/017892.html ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs
On Wed, Sep 26, 2018 at 09:24:20PM -0700, Dan Williams wrote: > The Intel NVDIMM command specification publishes a dirty-shutdown-count > in addition to the dirty-shutdown / flush-failed indication that comes > from the ACPI NFIT. This is expected to be a common property of NVDIMMs > and is a static hardware health detail to be cached / exported via > sysfs. > > Add plumbing for retrieving this data at driver load time, publish the > count, and use the dynamically retrieved dirty-shutdown indicator to > augment the existing 'flush_failed' flag. Is this the same thing as the LSS Latch stuff that went into ndctl? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
[PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs
The Intel NVDIMM command specification publishes a dirty-shutdown-count in addition to the dirty-shutdown / flush-failed indication that comes from the ACPI NFIT. This is expected to be a common property of NVDIMMs and is a static hardware health detail to be cached / exported via sysfs. Add plumbing for retrieving this data at driver load time, publish the count, and use the dynamically retrieved dirty-shutdown indicator to augment the existing 'flush_failed' flag. --- Dan Williams (3): acpi, nfit: Introduce nfit_mem flags acpi, nfit: Collect shutdown status tools/testing/nvdimm: Populate dirty shutdown data drivers/acpi/nfit/core.c | 115 - drivers/acpi/nfit/intel.h | 34 ++ drivers/acpi/nfit/nfit.h | 11 +++ tools/testing/nvdimm/Kbuild |1 tools/testing/nvdimm/acpi_nfit_test.c |8 ++ tools/testing/nvdimm/test/nfit.c |3 + tools/testing/nvdimm/test/nfit_test.h | 24 --- 7 files changed, 152 insertions(+), 44 deletions(-) ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
