Re: [PATCH 3/6] ext4: Remove clearing of BH_New bit for zeroed blocks

[Christoph Hellwig]

On Tue, Sep 27, 2016 at 06:43:32PM +0200, Jan Kara wrote:
> So far we did not return BH_New buffers from ext4_dax_get_block()
> because that would trigger racy zeroing in DAX code. This zeroing is
> gone these days so we can remove the workaround.
> 
> Signed-off-by: Jan Kara 

Looks fine,

Reviewed-by: Christoph Hellwig 
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

[PATCH 3/6] ext4: Remove clearing of BH_New bit for zeroed blocks

[Jan Kara]

So far we did not return BH_New buffers from ext4_dax_get_block()
because that would trigger racy zeroing in DAX code. This zeroing is
gone these days so we can remove the workaround.

Signed-off-by: Jan Kara 
---
 fs/ext4/inode.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 87150122d361..7ccd6fd7819d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3298,11 +3298,6 @@ int ext4_dax_get_block(struct inode *inode, sector_t 
iblock,
if (ret < 0)
return ret;
}
-   /*
-* At least for now we have to clear BH_New so that DAX code
-* doesn't attempt to zero blocks again in a racy way.
-*/
-   clear_buffer_new(bh_result);
return 0;
 }
 #else
-- 
2.6.6

___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm