Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
On Fri, May 03, 2019 at 08:57:09AM -0400, Pavel Tatashin wrote: > On Fri, May 3, 2019 at 6:35 AM Robin Murphy wrote: > > > > On 03/05/2019 01:41, Dan Williams wrote: > > > On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin > > > wrote: > > >> > > >> On Wed, Apr 17, 2019 at 2:52 PM Dan Williams > > >> wrote: > > >>> > > >>> Up-level the local section size and mask from kernel/memremap.c to > > >>> global definitions. These will be used by the new sub-section hotplug > > >>> support. > > >>> > > >>> Cc: Michal Hocko > > >>> Cc: Vlastimil Babka > > >>> Cc: Jérôme Glisse > > >>> Cc: Logan Gunthorpe > > >>> Signed-off-by: Dan Williams > > >> > > >> Should be dropped from this series as it has been replaced by a very > > >> similar patch in the mainline: > > >> > > >> 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > > >> mm/memremap: Rename and consolidate SECTION_SIZE > > > > > > I saw that patch fly by and acked it, but I have not seen it picked up > > > anywhere. I grabbed latest -linus and -next, but don't see that > > > commit. > > > > > > $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > > > fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > > > > Yeah, I don't recognise that ID either, nor have I had any notifications > > that Andrew's picked up anything of mine yet :/ > > Sorry for the confusion. I thought I checked in a master branch, but > turns out I checked in a branch where I applied arm hotremove patches > and Robin's patch as well. These two patches are essentially the same, > so which one goes first the other should be dropped. > > Reviewed-by: Pavel Tatashin Hey Pavel, just a friendly note :-) : you are reviewing v6, I think you might want to review v7 [1] instead ;-)? [1] https://patchwork.kernel.org/cover/10926035/ -- Oscar Salvador SUSE L3 ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
On Fri, May 3, 2019 at 6:35 AM Robin Murphy wrote: > > On 03/05/2019 01:41, Dan Williams wrote: > > On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin > > wrote: > >> > >> On Wed, Apr 17, 2019 at 2:52 PM Dan Williams > >> wrote: > >>> > >>> Up-level the local section size and mask from kernel/memremap.c to > >>> global definitions. These will be used by the new sub-section hotplug > >>> support. > >>> > >>> Cc: Michal Hocko > >>> Cc: Vlastimil Babka > >>> Cc: Jérôme Glisse > >>> Cc: Logan Gunthorpe > >>> Signed-off-by: Dan Williams > >> > >> Should be dropped from this series as it has been replaced by a very > >> similar patch in the mainline: > >> > >> 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > >> mm/memremap: Rename and consolidate SECTION_SIZE > > > > I saw that patch fly by and acked it, but I have not seen it picked up > > anywhere. I grabbed latest -linus and -next, but don't see that > > commit. > > > > $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > > fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > > Yeah, I don't recognise that ID either, nor have I had any notifications > that Andrew's picked up anything of mine yet :/ Sorry for the confusion. I thought I checked in a master branch, but turns out I checked in a branch where I applied arm hotremove patches and Robin's patch as well. These two patches are essentially the same, so which one goes first the other should be dropped. Reviewed-by: Pavel Tatashin Thank you, Pasha > > Robin. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
On 03/05/2019 01:41, Dan Williams wrote: On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin wrote: On Wed, Apr 17, 2019 at 2:52 PM Dan Williams wrote: Up-level the local section size and mask from kernel/memremap.c to global definitions. These will be used by the new sub-section hotplug support. Cc: Michal Hocko Cc: Vlastimil Babka Cc: Jérôme Glisse Cc: Logan Gunthorpe Signed-off-by: Dan Williams Should be dropped from this series as it has been replaced by a very similar patch in the mainline: 7c697d7fb5cb14ef60e2b687333ba3efb74f73da mm/memremap: Rename and consolidate SECTION_SIZE I saw that patch fly by and acked it, but I have not seen it picked up anywhere. I grabbed latest -linus and -next, but don't see that commit. $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da Yeah, I don't recognise that ID either, nor have I had any notifications that Andrew's picked up anything of mine yet :/ Robin. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
On Thu, May 2, 2019 at 7:53 AM Pavel Tatashin wrote: > > On Wed, Apr 17, 2019 at 2:52 PM Dan Williams wrote: > > > > Up-level the local section size and mask from kernel/memremap.c to > > global definitions. These will be used by the new sub-section hotplug > > support. > > > > Cc: Michal Hocko > > Cc: Vlastimil Babka > > Cc: Jérôme Glisse > > Cc: Logan Gunthorpe > > Signed-off-by: Dan Williams > > Should be dropped from this series as it has been replaced by a very > similar patch in the mainline: > > 7c697d7fb5cb14ef60e2b687333ba3efb74f73da > mm/memremap: Rename and consolidate SECTION_SIZE I saw that patch fly by and acked it, but I have not seen it picked up anywhere. I grabbed latest -linus and -next, but don't see that commit. $ git show 7c697d7fb5cb14ef60e2b687333ba3efb74f73da fatal: bad object 7c697d7fb5cb14ef60e2b687333ba3efb74f73da ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCH v6 02/12] mm/sparsemem: Introduce common definitions for the size and mask of a section
On Wed, Apr 17, 2019 at 2:52 PM Dan Williams wrote: > > Up-level the local section size and mask from kernel/memremap.c to > global definitions. These will be used by the new sub-section hotplug > support. > > Cc: Michal Hocko > Cc: Vlastimil Babka > Cc: Jérôme Glisse > Cc: Logan Gunthorpe > Signed-off-by: Dan Williams Should be dropped from this series as it has been replaced by a very similar patch in the mainline: 7c697d7fb5cb14ef60e2b687333ba3efb74f73da mm/memremap: Rename and consolidate SECTION_SIZE ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
