Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode
On Fri, Jul 10, 2015 at 07:39:35PM +0530, Lokesh Vutla wrote: > > If you don't mind can you elaborate more on the usage of rctx and ctx > in the driver? The ctx is a property of the tfm and it's shared by all users of that tfm. So it must not be written to unless you use locking. The reqeust context on the other hand is specific to a request so it can be used to store information. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] omap_hsmmc: Fix card enumeration failure on
On 6/16/2015 4:07 PM, Vignesh R wrote: > > Hi, > > When using omap_hsmmc driver, if sd-card repeatedly plug unplugged > multiple times quickly, card enumeration stops after few iterations. > This can be easily reproduced on DRA74X EVM which uses omap_hsmmc driver. > This patch series addresses the above problem. The first patch fixes irq > handler to report all DTOs to mmc-core. Second patch adds handling for > BADA, DEB and CEB interrupts. The last patch introduces driver specific > card detect irq handler to cleanup pending requests before card removal. > > Tested on DRA74X amd DRA72X and AM437X-GP EVMs, by repeated intense > plug/unplug iterations. > Gentle ping.. These patches fix bugs related to interrupt handling in omap_hsmmc. It also fixes bugs with unexpected card removal during data transfer. Can this go into 4.2-rc?? > > Kishon Vijay Abraham I (1): > mmc: host: omap_hsmmc: Fix DTO and DCRC handling > > Vignesh R (2): > mmc: host: omap_hsmmc: Handle BADA, DEB and CEB interrupts > mmc: host: omap_hsmmc: Add custom card detect irq handler > > drivers/mmc/host/omap_hsmmc.c | 84 --- > 1 file changed, 78 insertions(+), 6 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
linux 4.2-rc1 broken Nokia N900
Hello, now I tested 4.2-rc1 release on Nokia N900 and couple of drivers are broken and cause kernel oops... Basically wifi, touchscreen and rtc drivers not working... Here are some relevant snippets form dmesg: [ 13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c [ 13.940490] pgd = cfb38000 [ 13.946594] [fa09802c] *pgd=48011452(bad) [ 13.952758] Internal error: : 1028 [#1] PREEMPT ARM [ 13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363 [ 13.971801] Hardware name: Nokia RX-51 board [ 13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000 [ 13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c [ 13.991485] LR is at spi_set_cs+0x5c/0x60 [ 13.997985] pc : []lr : []psr: 2013 [ 13.997985] sp : cb1f3dd0 ip : 0001 fp : 0004 [ 14.011260] r10: cfce5be8 r9 : 0fff r8 : c0654f98 [ 14.017913] r7 : r6 : r5 : r4 : [ 14.024505] r3 : 200103dc r2 : fa098000 r1 : 0001 r0 : cf09bc00 [ 14.031036] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 14.037689] Control: 10c5387d Table: 8fb38019 DAC: 0015 [ 14.044403] Process modprobe (pid: 183, stack limit = 0xcb1f2210) [ 14.051300] Stack: (0xcb1f3dd0 to 0xcb1f4000) [ 14.058105] 3dc0: cf09bc00 c02bafa4 cf09bc00 cf09bc00 [ 14.065277] 3de0: bf013444 bf01254c cf0e2230 cf0e2230 0001 c0654f98 0fff 0fff [ 14.072570] 3e00: 0008 0002 0118 1f40 0031 cf09bc00 ffed bf013444 [ 14.080078] 3e20: 0031 c0654f98 cb1f2000 c02bb5c0 cf09bc00 [ 14.087738] 3e40: bf013454 c027a2f4 cf09bc00 bf013454 bf013454 c027a594 [ 14.095367] 3e60: cf09bc00 cf09bc34 c027a60c bf013454 cb1f3e80 c027a5ac c0278ec8 [ 14.102935] 3e80: cf972c4c cf09d630 bf013454 bf013454 cbb55300 c06848d8 c0279c84 [ 14.110473] 3ea0: bf01327c bf01327d bf013454 cb889180 c0654f98 c027b0c8 [ 14.117980] 3ec0: bf015000 cb889180 c00095b0 0040003e cfe6a080 0040003f [ 14.125457] 3ee0: 0008 cfcf9000 cb1f2000 6013 0040003e cbf1bbc0 0001 [ 14.132843] 3f00: bf0134cc cb1f2000 bf0134c0 cb1f3f58 c04352d0 cf801f00 00d0 [ 14.140136] 3f20: bf0134c0 bf0134c0 416c cb889040 0080 c000ebe4 cb1f2000 c0089f68 [ 14.147308] 3f40: bf0134c0 cbf1bc00 001a9193 416c 001f8d20 c008ab30 d0b1 416c [ 14.154571] 3f60: d0b1267c d0b1252b d0b13514 16c0 1ad0 [ 14.161865] 3f80: 001f 0020 0017 0014 0012 00201208 [ 14.169097] 3fa0: c000ea60 00201208 001f8d20 416c 001a9193 [ 14.176177] 3fc0: 00201208 0080 00208c20 001a9193 bee09e98 [ 14.183197] 3fe0: b6f742b4 bee09ae4 000153f0 93e4 6010 001f8d20 72757463 69665f65 [ 14.190277] [] (omap2_mcspi_set_cs) from [] (spi_set_cs+0x5c/0x60) [ 14.197479] [] (spi_set_cs) from [] (spi_setup+0xd4/0x10c) [ 14.204833] [] (spi_setup) from [] (tsc2005_probe+0x104/0x484 [tsc2005]) [ 14.212249] [] (tsc2005_probe [tsc2005]) from [] (spi_drv_probe+0x50/0x6c) [ 14.219818] [] (spi_drv_probe) from [] (really_probe+0xd4/0x230) [ 14.227478] [] (really_probe) from [] (driver_probe_device+0x30/0x48) [ 14.235290] [] (driver_probe_device) from [] (__driver_attach+0x60/0x84) [ 14.243286] [] (__driver_attach) from [] (bus_for_each_dev+0x50/0x84) [ 14.251281] [] (bus_for_each_dev) from [] (bus_add_driver+0xcc/0x1e0) [ 14.259246] [] (bus_add_driver) from [] (driver_register+0x9c/0xe0) [ 14.267272] [] (driver_register) from [] (do_one_initcall+0x100/0x1b0) [ 14.275421] [] (do_one_initcall) from [] (do_init_module+0x58/0x1bc) [ 14.283477] [] (do_init_module) from [] (SyS_init_module+0x54/0x64) [ 14.291412] [] (SyS_init_module) from [] (ret_fast_syscall+0x0/0x3c) [ 14.299407] Code: e5823018 e5902188 e5922000 e582302c (e592302c) [ 14.307403] ---[ end trace d21553dcaefcb5ac ]--- [ 14.315338] In-band Error seen by MPU at address 0 [ 14.323211] [ cut here ] [ 14.330993] WARNING: CPU: 0 PID: 183 at drivers/bus/omap_l3_smx.c:166 omap3_l3_app_irq+0xd4/0x118() [ 14.346893] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt [ 14.355316] CPU: 0 PID: 183 Comm: modprobe Tainted: G D 4.2.0-rc1+ #363 [ 14.363739] Hardware name: Nokia RX-51 board [ 14.372070] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 14.380676] [] (show_stack) from [] (warn_slowpath_common+0x84/0xac) [ 14.389404] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x18/0x1c) [ 14.398315] [] (warn_slowpath_null) from [] (omap3_l3_app_irq+0xd4/0x118) [ 14.407287] [] (omap3_l3_app_irq) from [] (handle_irq_event_p
[PATCH 1/2] ARM: OMAP2+: sparse: add missing static declaration
Add missing static declaration for file local variables.
This fixes sparse warnings of type:
arch/arm/mach-omap2/omap_hwmod_81xx_data.c:491:26: warning: symbol
'dm81xx_alwon_l3_slow__gpmc' was not declared. Should it be static?
Signed-off-by: Sekhar Nori
---
arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 2 +-
arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 34 +++---
arch/arm/mach-omap2/pdata-quirks.c | 6 ++--
5 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
index 79f49d904a06..65024af169d3 100644
--- a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
+++ b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
@@ -105,7 +105,7 @@ static void dummy_cpu_resume(void)
static void dummy_scu_prepare(unsigned int cpu_id, unsigned int cpu_state)
{}
-struct cpu_pm_ops omap_pm_ops = {
+static struct cpu_pm_ops omap_pm_ops = {
.finish_suspend = default_finish_suspend,
.resume = dummy_cpu_resume,
.scu_prepare= dummy_scu_prepare,
diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
index 6dcfd03ced8f..36bcd2e75422 100644
--- a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c
@@ -20,7 +20,7 @@
#include "prm-regbits-24xx.h"
#include "wd_timer.h"
-struct omap_hwmod_dma_info omap2xxx_dss_sdma_chs[] = {
+static struct omap_hwmod_dma_info omap2xxx_dss_sdma_chs[] = {
{ .name = "dispc", .dma_req = 5 },
{ .dma_req = -1, },
};
diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
index 215d5efa0dba..e97a894b5f88 100644
--- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
@@ -480,7 +480,7 @@ static struct omap_hwmod am43xx_dss_core_hwmod = {
/* dispc */
-struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
+static struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
.manager_count = 1,
.has_framedonetv_irq= 0
};
diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
index c92413769144..280789a04ff9 100644
--- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
@@ -488,7 +488,7 @@ static struct omap_hwmod dm81xx_gpmc_hwmod = {
},
};
-struct omap_hwmod_ocp_if dm81xx_alwon_l3_slow__gpmc = {
+static struct omap_hwmod_ocp_if dm81xx_alwon_l3_slow__gpmc = {
.master = &dm816x_alwon_l3_slow_hwmod,
.slave = &dm81xx_gpmc_hwmod,
.user = OCP_USER_MPU,
@@ -729,7 +729,7 @@ static struct omap_hwmod_class dm816x_mdio_hwmod_class = {
.sysc = &dm816x_emac_sysc,
};
-struct omap_hwmod dm816x_emac0_mdio_hwmod = {
+static struct omap_hwmod dm816x_emac0_mdio_hwmod = {
.name = "davinci_mdio",
.class = &dm816x_mdio_hwmod_class,
.clkdm_name = "alwon_ethernet_clkdm",
@@ -747,7 +747,7 @@ struct omap_hwmod dm816x_emac0_mdio_hwmod = {
},
};
-struct omap_hwmod_ocp_if dm816x_emac0__mdio = {
+static struct omap_hwmod_ocp_if dm816x_emac0__mdio = {
.master = &dm816x_l4_hs_hwmod,
.slave = &dm816x_emac0_mdio_hwmod,
.user = OCP_USER_MPU,
@@ -902,7 +902,7 @@ static struct omap_hwmod_class dm816x_tpcc_hwmod_class = {
.name = "tpcc",
};
-struct omap_hwmod dm816x_tpcc_hwmod = {
+static struct omap_hwmod dm816x_tpcc_hwmod = {
.name = "tpcc",
.class = &dm816x_tpcc_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
@@ -915,7 +915,7 @@ struct omap_hwmod dm816x_tpcc_hwmod = {
},
};
-struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tpcc = {
+static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tpcc = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tpcc_hwmod,
.clk= "sysclk4_ck",
@@ -935,7 +935,7 @@ static struct omap_hwmod_class dm816x_tptc0_hwmod_class = {
.name = "tptc0",
};
-struct omap_hwmod dm816x_tptc0_hwmod = {
+static struct omap_hwmod dm816x_tptc0_hwmod = {
.name = "tptc0",
.class = &dm816x_tptc0_hwmod_class,
.clkdm_name = "alwon_l3s_clkdm",
@@ -948,7 +948,7 @@ struct omap_hwmod dm816x_tptc0_hwmod = {
},
};
-struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc0 = {
+static struct omap_hwmod_ocp_if dm816x_alwon_l3_fast__tptc0 = {
.master = &dm816x_alwon_l3_fast_hwmod,
.slave = &dm816x_tptc0_hwmod,
.clk= "sysclk4_ck",
@@ -956,7 +956,7 @
[PATCH 0/2] ARM: OMAP2+: sparse fixes
Hi Tony, Here are some sparse fixes for mach-omap2. After this series mach-omap2 is sparse clean. Thanks, Sekhar Sekhar Nori (2): ARM: OMAP2+: sparse: add missing static declaration ARM: OMAP2+: sparse: add missing function declarations arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 +- arch/arm/mach-omap2/omap3-restart.c| 1 + arch/arm/mach-omap2/omap4-restart.c| 1 + arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 34 +++--- arch/arm/mach-omap2/pdata-quirks.c | 6 ++-- 7 files changed, 25 insertions(+), 23 deletions(-) -- 2.4.4.408.g16da57c -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] ARM: OMAP2+: sparse: add missing function declarations
omap3xxx_restart() and omap44xx_restart() are global functions declared in common.h. Include this file in omap3-restart.c and omap4-restart.c to prevent sparse warnings of type: arch/arm/mach-omap2/omap4-restart.c:22:6: warning: symbol 'omap44xx_restart' was not declared. Should it be static? Signed-off-by: Sekhar Nori --- arch/arm/mach-omap2/omap3-restart.c | 1 + arch/arm/mach-omap2/omap4-restart.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/omap3-restart.c b/arch/arm/mach-omap2/omap3-restart.c index 103a49f68bcb..4bdd22edb96b 100644 --- a/arch/arm/mach-omap2/omap3-restart.c +++ b/arch/arm/mach-omap2/omap3-restart.c @@ -14,6 +14,7 @@ #include #include +#include "common.h" #include "control.h" #include "prm.h" diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c index a99e7f7fb5be..e17136a50e27 100644 --- a/arch/arm/mach-omap2/omap4-restart.c +++ b/arch/arm/mach-omap2/omap4-restart.c @@ -9,6 +9,7 @@ #include #include +#include "common.h" #include "prm.h" /** -- 2.4.4.408.g16da57c -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
