[PATCH 1/1 linux-next] mmc: omap: use for_each_sg() for scatterlist parsing

[Fabian Frederick]

See Documentation/DMA-API.txt - Part Id

Signed-off-by: Fabian Frederick f...@skynet.be
---
This is untested.

 drivers/mmc/host/omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 68dd6c7..70dcf07 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -948,6 +948,7 @@ mmc_omap_prepare_data(struct mmc_omap_host *host, struct 
mmc_request *req)
 {
struct mmc_data *data = req-data;
int i, use_dma = 1, block_size;
+   struct scatterlist *sg;
unsigned sg_len;
 
host-data = data;
@@ -972,8 +973,8 @@ mmc_omap_prepare_data(struct mmc_omap_host *host, struct 
mmc_request *req)
sg_len = (data-blocks == 1) ? 1 : data-sg_len;
 
/* Only do DMA for entire blocks */
-   for (i = 0; i  sg_len; i++) {
-   if ((data-sg[i].length % block_size) != 0) {
+   for_each_sg(data-sg, sg, sg_len, i) {
+   if ((sg-length % block_size) != 0) {
use_dma = 0;
break;
}
-- 
2.4.2

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

 On 27 March 2015 at 08:19 Stephen Boyd sb...@codeaurora.org wrote:


 On 03/22, Fabian Frederick wrote:
 
 
   On 18 March 2015 at 15:15 Michael Turquette mturque...@linaro.org wrote:
  
  
   Quoting Fabian Frederick (2015-03-16 12:59:06)
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)
   
Signed-off-by: Fabian Frederick f...@skynet.be
  
   Acked-by: Michael Turquette mturque...@linaro.org
 
  Thanks :)
 
  btw, something I forgot to mention in changelog is the __initdata -
  __initconst
  for ti_clkdm_match_table[]
 
  I can send it again with a new changelog if necessary ...
 

 Did you want us to take this through clk-next? If so please
 resend with the new commit text.

Of course :) I hope V2 is ok.

Regards,
Fabian

 --
 Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
 a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V2 linux-next] clk: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

__initdata updated to __initconst for
static const struct of_device_id ti_clkdm_match_table[]

Signed-off-by: Fabian Frederick f...@skynet.be
---
V2:
add __initdata - __initconst in changelog

 drivers/clk/clk-palmas.c | 2 +-
 drivers/clk/st/clkgen-fsyn.c | 2 +-
 drivers/clk/st/clkgen-mux.c  | 8 
 drivers/clk/st/clkgen-pll.c  | 4 ++--
 drivers/clk/ti/clk-dra7-atl.c| 2 +-
 drivers/clk/ti/clockdomain.c | 2 +-
 drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
index 8d45992..45a535a 100644
--- a/drivers/clk/clk-palmas.c
+++ b/drivers/clk/clk-palmas.c
@@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data 
palmas_of_clk32kgaudio = {
},
 };
 
-static struct of_device_id palmas_clks_of_match[] = {
+static const struct of_device_id palmas_clks_of_match[] = {
{
.compatible = ti,palmas-clk32kg,
.data = palmas_of_clk32kg,
diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
index af94ed8..a917c4c 100644
--- a/drivers/clk/st/clkgen-fsyn.c
+++ b/drivers/clk/st/clkgen-fsyn.c
@@ -1057,7 +1057,7 @@ static struct clk * __init st_clk_register_quadfs_fsynth(
return clk;
 }
 
-static struct of_device_id quadfs_of_match[] = {
+static const struct of_device_id quadfs_of_match[] = {
{
.compatible = st,stih416-quadfs216,
.data = st_fs216c65_416
diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
index 9a15ec3..fdcff10 100644
--- a/drivers/clk/st/clkgen-mux.c
+++ b/drivers/clk/st/clkgen-mux.c
@@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
.fb_start_bit_idx = 24,
 };
 
-static struct of_device_id clkgena_divmux_of_match[] = {
+static const struct of_device_id clkgena_divmux_of_match[] = {
{
.compatible = st,clkgena-divmux-c65-hs,
.data = st_divmux_c65hs,
@@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
.table = prediv_table16,
 };
 
-static struct of_device_id clkgena_prediv_of_match[] = {
+static const struct of_device_id clkgena_prediv_of_match[] = {
{ .compatible = st,clkgena-prediv-c65, .data = prediv_c65_data },
{ .compatible = st,clkgena-prediv-c32, .data = prediv_c32_data },
{}
@@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
.width = 2,
 };
 
-static struct of_device_id mux_of_match[] = {
+static const struct of_device_id mux_of_match[] = {
{
.compatible = st,stih416-clkgenc-vcc-hd,
.data = clkgen_mux_c_vcc_hd_416,
@@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
.lock = clkgenf_lock,
 };
 
-static struct of_device_id vcc_of_match[] = {
+static const struct of_device_id vcc_of_match[] = {
{ .compatible = st,stih416-clkgenc, .data = st_clkgenc_vcc_416 },
{ .compatible = st,stih416-clkgenf, .data = st_clkgenf_vcc_416 },
{}
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 29769d7..d204ba8 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const char 
*parent_name,
return clk;
 }
 
-static struct of_device_id c32_pll_of_match[] = {
+static const struct of_device_id c32_pll_of_match[] = {
{
.compatible = st,plls-c32-a1x-0,
.data = st_pll3200c32_a1x_0,
@@ -708,7 +708,7 @@ err:
 }
 CLK_OF_DECLARE(clkgen_c32_pll, st,clkgen-plls-c32, clkgen_c32_pll_setup);
 
-static struct of_device_id c32_gpu_pll_of_match[] = {
+static const struct of_device_id c32_gpu_pll_of_match[] = {
{
.compatible = st,stih415-gpu-pll-c32,
.data = st_pll1200c32_gpu_415,
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 59bb4b3..d86bc46 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device 
*pdev)
return 0;
 }
 
-static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
+static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
{ .compatible = ti,dra7-atl, },
{},
 };
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
index b4c5fac..35fe108 100644
--- a/drivers/clk/ti/clockdomain.c
+++ b/drivers/clk/ti/clockdomain.c
@@ -52,7 +52,7 @@ static void __init of_ti_clockdomain_setup(struct device_node 
*node)
}
 }
 
-static struct of_device_id ti_clkdm_match_table[] __initdata = {
+static const struct of_device_id ti_clkdm_match_table[] __initconst = {
{ .compatible = ti

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

 On 18 March 2015 at 15:15 Michael Turquette mturque...@linaro.org wrote:


 Quoting Fabian Frederick (2015-03-16 12:59:06)
  of_device_id is always used as const.
  (See driver.of_match_table and open firmware functions)
 
  Signed-off-by: Fabian Frederick f...@skynet.be

 Acked-by: Michael Turquette mturque...@linaro.org

Thanks :)

btw, something I forgot to mention in changelog is the __initdata - __initconst
for ti_clkdm_match_table[]

I can send it again with a new changelog if necessary ...

Regards,
Fabian


  ---
   drivers/clk/clk-palmas.c                 | 2 +-
   drivers/clk/st/clkgen-fsyn.c             | 2 +-
   drivers/clk/st/clkgen-mux.c              | 8 
   drivers/clk/st/clkgen-pll.c              | 4 ++--
   drivers/clk/ti/clk-dra7-atl.c            | 2 +-
   drivers/clk/ti/clockdomain.c             | 2 +-
   drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
   7 files changed, 11 insertions(+), 11 deletions(-)
 
  diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
  index 8d45992..45a535a 100644
  --- a/drivers/clk/clk-palmas.c
  +++ b/drivers/clk/clk-palmas.c
  @@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data
  palmas_of_clk32kgaudio = {
          },
   };
  
  -static struct of_device_id palmas_clks_of_match[] = {
  +static const struct of_device_id palmas_clks_of_match[] = {
          {
                  .compatible = ti,palmas-clk32kg,
                  .data = palmas_of_clk32kg,
  diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
  index af94ed8..a917c4c 100644
  --- a/drivers/clk/st/clkgen-fsyn.c
  +++ b/drivers/clk/st/clkgen-fsyn.c
  @@ -1057,7 +1057,7 @@ static struct clk * __init
  st_clk_register_quadfs_fsynth(
          return clk;
   }
  
  -static struct of_device_id quadfs_of_match[] = {
  +static const struct of_device_id quadfs_of_match[] = {
          {
                  .compatible = st,stih416-quadfs216,
                  .data = st_fs216c65_416
  diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
  index 9a15ec3..fdcff10 100644
  --- a/drivers/clk/st/clkgen-mux.c
  +++ b/drivers/clk/st/clkgen-mux.c
  @@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
          .fb_start_bit_idx = 24,
   };
  
  -static struct of_device_id clkgena_divmux_of_match[] = {
  +static const struct of_device_id clkgena_divmux_of_match[] = {
          {
                  .compatible = st,clkgena-divmux-c65-hs,
                  .data = st_divmux_c65hs,
  @@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
          .table = prediv_table16,
   };
  
  -static struct of_device_id clkgena_prediv_of_match[] = {
  +static const struct of_device_id clkgena_prediv_of_match[] = {
          { .compatible = st,clkgena-prediv-c65, .data = prediv_c65_data },
          { .compatible = st,clkgena-prediv-c32, .data = prediv_c32_data },
          {}
  @@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
          .width = 2,
   };
  
  -static struct of_device_id mux_of_match[] = {
  +static const struct of_device_id mux_of_match[] = {
          {
                  .compatible = st,stih416-clkgenc-vcc-hd,
                  .data = clkgen_mux_c_vcc_hd_416,
  @@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
          .lock = clkgenf_lock,
   };
  
  -static struct of_device_id vcc_of_match[] = {
  +static const struct of_device_id vcc_of_match[] = {
          { .compatible = st,stih416-clkgenc, .data = st_clkgenc_vcc_416 },
          { .compatible = st,stih416-clkgenf, .data = st_clkgenf_vcc_416 },
          {}
  diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
  index 29769d7..d204ba8 100644
  --- a/drivers/clk/st/clkgen-pll.c
  +++ b/drivers/clk/st/clkgen-pll.c
  @@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const
  char *parent_name,
          return clk;
   }
  
  -static struct of_device_id c32_pll_of_match[] = {
  +static const struct of_device_id c32_pll_of_match[] = {
          {
                  .compatible = st,plls-c32-a1x-0,
                  .data = st_pll3200c32_a1x_0,
  @@ -708,7 +708,7 @@ err:
   }
   CLK_OF_DECLARE(clkgen_c32_pll, st,clkgen-plls-c32, clkgen_c32_pll_setup);
  
  -static struct of_device_id c32_gpu_pll_of_match[] = {
  +static const struct of_device_id c32_gpu_pll_of_match[] = {
          {
                  .compatible = st,stih415-gpu-pll-c32,
                  .data = st_pll1200c32_gpu_415,
  diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
  index 59bb4b3..d86bc46 100644
  --- a/drivers/clk/ti/clk-dra7-atl.c
  +++ b/drivers/clk/ti/clk-dra7-atl.c
  @@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device
  *pdev)
          return 0;
   }
  
  -static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
  +static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
          { .compatible = ti,dra7-atl

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

 On 17 March 2015 at 18:19 Mark Brown broo...@kernel.org wrote:


 On Tue, Mar 17, 2015 at 06:10:12PM +0100, Fabian Frederick wrote:

  Thanks Mark, I used a --cc-cmd script by Joe Perches with
  git send-email which uses --nom for cover-letter.

  This limits recipients to mailing lists: 37 instead of 123 in this case.
  I guess it's better to reduce the noise :)

 Well, another thing to do if there's no dependencies is to just send
 each patch separately - there's no real relationship between the
 patches.  This also avoids the issue.

Such trivial updates are generally applied by David or Greg
after receiving some ack. That's the reason for the patchset :)
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

 On 17 March 2015 at 13:11 Mark Brown broo...@kernel.org wrote:


 On Mon, Mar 16, 2015 at 08:17:08PM +0100, Fabian Frederick wrote:
  of_device_id is always used as const.
  (See driver.of_match_table and open firmware functions)

 Applied, thanks.  Please remember to always include people in the cover
 letter for patch serieses so they know what's going on with regard to
 dependencies and so on.

Thanks Mark, I used a --cc-cmd script by Joe Perches with
git send-email which uses --nom for cover-letter.

This limits recipients to mailing lists: 37 instead of 123 in this case.
I guess it's better to reduce the noise :)

Regards,
Fabian
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 21/35 linux-next] mfd: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/mfd/hi6421-pmic-core.c | 2 +-
 drivers/mfd/rk808.c| 2 +-
 drivers/mfd/twl4030-power.c| 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
index 7210ae2..95b2ff8 100644
--- a/drivers/mfd/hi6421-pmic-core.c
+++ b/drivers/mfd/hi6421-pmic-core.c
@@ -93,7 +93,7 @@ static int hi6421_pmic_remove(struct platform_device *pdev)
return 0;
 }
 
-static struct of_device_id of_hi6421_pmic_match_tbl[] = {
+static const struct of_device_id of_hi6421_pmic_match_tbl[] = {
{ .compatible = hisilicon,hi6421-pmic, },
{ },
 };
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index 7cf25c7..4b1e439 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -246,7 +246,7 @@ static int rk808_remove(struct i2c_client *client)
return 0;
 }
 
-static struct of_device_id rk808_of_match[] = {
+static const struct of_device_id rk808_of_match[] = {
{ .compatible = rockchip,rk808 },
{ },
 };
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 3935092..f440aed 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -829,7 +829,7 @@ static struct twl4030_power_data osc_off_idle = {
.board_config   = osc_off_rconfig,
 };
 
-static struct of_device_id twl4030_power_of_match[] = {
+static const struct of_device_id twl4030_power_of_match[] = {
{
.compatible = ti,twl4030-power,
},
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 00/35 linux-next] constify of_device_id array

[Fabian Frederick]

This small patchset adds const to of_device_id arrays in
drivers branch.

Fabian Frederick (35):
  ata: constify of_device_id array
  regulator: constify of_device_id array
  thermal: constify of_device_id array
  tty/hvc_opal: constify of_device_id array
  tty: constify of_device_id array
  power: constify of_device_id array
  char: constify of_device_id array
  dma: constify of_device_id array
  iio: constify of_device_id array
  misc: constify of_device_id array
  usb: gadget: constify of_device_id array
  mtd: constify of_device_id array
  w1: constify of_device_id array
  ide: pmac: constify of_device_id array
  spi: constify of_device_id array
  video: constify of_device_id array
  coresight-replicator: constify of_device_id array
  macintosh: constify of_device_id array
  virtio_mmio: constify of_device_id array
  swim3: constify of_device_id array
  mfd: constify of_device_id array
  soc: ti: constify of_device_id array
  [media]: constify of_device_id array
  Input: constify of_device_id array
  PCI: constify of_device_id array
  hwmon: constify of_device_id array
  reset: sti: constify of_device_id array
  uio: constify of_device_id array
  gpu: constify of_device_id array
  devfreq: constify of_device_id array
  EDAC: constify of_device_id array
  clk: constify of_device_id array
  mmc: constify of_device_id array
  Staging: octeon: constify of_device_id array
  pinctrl: constify of_device_id array

 drivers/ata/pata_macio.c | 2 +-
 drivers/ata/pata_mpc52xx.c   | 2 +-
 drivers/ata/pata_octeon_cf.c | 2 +-
 drivers/ata/pata_of_platform.c   | 2 +-
 drivers/ata/sata_fsl.c   | 2 +-
 drivers/ata/sata_mv.c| 2 +-
 drivers/ata/sata_rcar.c  | 2 +-
 drivers/block/swim3.c| 2 +-
 drivers/char/hw_random/pasemi-rng.c  | 2 +-
 drivers/char/hw_random/powernv-rng.c | 2 +-
 drivers/char/hw_random/ppc4xx-rng.c  | 2 +-
 drivers/char/ipmi/ipmi_si_intf.c | 4 ++--
 drivers/char/xillybus/xillybus_of.c  | 2 +-
 drivers/clk/clk-palmas.c | 2 +-
 drivers/clk/st/clkgen-fsyn.c | 2 +-
 drivers/clk/st/clkgen-mux.c  | 8 
 drivers/clk/st/clkgen-pll.c  | 4 ++--
 drivers/clk/ti/clk-dra7-atl.c| 2 +-
 drivers/clk/ti/clockdomain.c | 2 +-
 drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
 drivers/coresight/coresight-replicator.c | 2 +-
 drivers/devfreq/event/exynos-ppmu.c  | 2 +-
 drivers/devfreq/tegra-devfreq.c  | 2 +-
 drivers/dma/bestcomm/bestcomm.c  | 4 ++--
 drivers/dma/k3dma.c  | 2 +-
 drivers/dma/mmp_pdma.c   | 2 +-
 drivers/dma/mmp_tdma.c   | 2 +-
 drivers/dma/mpc512x_dma.c| 2 +-
 drivers/dma/mv_xor.c | 2 +-
 drivers/dma/sirf-dma.c   | 2 +-
 drivers/dma/sun6i-dma.c  | 2 +-
 drivers/edac/highbank_mc_edac.c  | 2 +-
 drivers/edac/mpc85xx_edac.c  | 4 ++--
 drivers/edac/ppc4xx_edac.c   | 2 +-
 drivers/edac/synopsys_edac.c | 2 +-
 drivers/gpio/gpio-mpc8xxx.c  | 2 +-
 drivers/gpio/gpio-octeon.c   | 2 +-
 drivers/gpio/gpio-tz1090-pdc.c   | 2 +-
 drivers/gpio/gpio-tz1090.c   | 2 +-
 drivers/gpio/gpio-zynq.c | 2 +-
 drivers/gpu/drm/armada/armada_crtc.c | 2 +-
 drivers/gpu/drm/exynos/exynos_drm_dsi.c  | 2 +-
 drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
 drivers/gpu/drm/exynos/exynos_mixer.c| 2 +-
 drivers/gpu/drm/panel/panel-ld9040.c | 2 +-
 drivers/gpu/drm/panel/panel-s6e8aa0.c| 2 +-
 drivers/gpu/drm/sti/sti_dvo.c| 2 +-
 drivers/gpu/drm/sti/sti_hqvdp.c  | 2 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c  | 4 ++--
 drivers/gpu/drm/tilcdc/tilcdc_panel.c| 2 +-
 drivers/gpu/drm/tilcdc/tilcdc_slave.c| 4 ++--
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c   | 4 ++--
 drivers/gpu/host1x/dev.c | 2 +-
 drivers/gpu/host1x/mipi.c| 2 +-
 drivers/hwmon/pwm-fan.c  | 2 +-
 drivers/hwmon/vexpress.c | 2 +-
 drivers/ide/pmac.c   | 2 +-
 drivers/iio/common/ssp_sensors/ssp_dev.c | 2 +-
 drivers/input/misc/palmas-pwrbutton.c| 2 +-
 drivers/input/misc/regulator-haptic.c| 2 +-
 drivers/input/misc/tps65218-pwrbutton.c  | 2 +-
 drivers/input/touchscreen/ar1021_i2c.c   | 2 +-
 drivers/macintosh/mediabay.c | 2 +-
 drivers/macintosh/rack-meter.c   | 2 +-
 drivers/media/i2c/adv7604.c  | 2 +-
 drivers/media/platform/fsl-viu.c | 2 +-
 drivers/media/platform/soc_camera/rcar_vin.c

[PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/regulator/palmas-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/palmas-regulator.c 
b/drivers/regulator/palmas-regulator.c
index 9205f43..eecce1e 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -1505,7 +1505,7 @@ static void palmas_dt_to_pdata(struct device *dev,
pdata-ldo6_vibrator = of_property_read_bool(node, ti,ldo6-vibrator);
 }
 
-static struct of_device_id of_palmas_match_tbl[] = {
+static const struct of_device_id of_palmas_match_tbl[] = {
{
.compatible = ti,palmas-pmic,
.data = palmas_ddata,
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/clk/clk-palmas.c | 2 +-
 drivers/clk/st/clkgen-fsyn.c | 2 +-
 drivers/clk/st/clkgen-mux.c  | 8 
 drivers/clk/st/clkgen-pll.c  | 4 ++--
 drivers/clk/ti/clk-dra7-atl.c| 2 +-
 drivers/clk/ti/clockdomain.c | 2 +-
 drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
index 8d45992..45a535a 100644
--- a/drivers/clk/clk-palmas.c
+++ b/drivers/clk/clk-palmas.c
@@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data 
palmas_of_clk32kgaudio = {
},
 };
 
-static struct of_device_id palmas_clks_of_match[] = {
+static const struct of_device_id palmas_clks_of_match[] = {
{
.compatible = ti,palmas-clk32kg,
.data = palmas_of_clk32kg,
diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
index af94ed8..a917c4c 100644
--- a/drivers/clk/st/clkgen-fsyn.c
+++ b/drivers/clk/st/clkgen-fsyn.c
@@ -1057,7 +1057,7 @@ static struct clk * __init st_clk_register_quadfs_fsynth(
return clk;
 }
 
-static struct of_device_id quadfs_of_match[] = {
+static const struct of_device_id quadfs_of_match[] = {
{
.compatible = st,stih416-quadfs216,
.data = st_fs216c65_416
diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
index 9a15ec3..fdcff10 100644
--- a/drivers/clk/st/clkgen-mux.c
+++ b/drivers/clk/st/clkgen-mux.c
@@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
.fb_start_bit_idx = 24,
 };
 
-static struct of_device_id clkgena_divmux_of_match[] = {
+static const struct of_device_id clkgena_divmux_of_match[] = {
{
.compatible = st,clkgena-divmux-c65-hs,
.data = st_divmux_c65hs,
@@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
.table = prediv_table16,
 };
 
-static struct of_device_id clkgena_prediv_of_match[] = {
+static const struct of_device_id clkgena_prediv_of_match[] = {
{ .compatible = st,clkgena-prediv-c65, .data = prediv_c65_data },
{ .compatible = st,clkgena-prediv-c32, .data = prediv_c32_data },
{}
@@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
.width = 2,
 };
 
-static struct of_device_id mux_of_match[] = {
+static const struct of_device_id mux_of_match[] = {
{
.compatible = st,stih416-clkgenc-vcc-hd,
.data = clkgen_mux_c_vcc_hd_416,
@@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
.lock = clkgenf_lock,
 };
 
-static struct of_device_id vcc_of_match[] = {
+static const struct of_device_id vcc_of_match[] = {
{ .compatible = st,stih416-clkgenc, .data = st_clkgenc_vcc_416 },
{ .compatible = st,stih416-clkgenf, .data = st_clkgenf_vcc_416 },
{}
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 29769d7..d204ba8 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const char 
*parent_name,
return clk;
 }
 
-static struct of_device_id c32_pll_of_match[] = {
+static const struct of_device_id c32_pll_of_match[] = {
{
.compatible = st,plls-c32-a1x-0,
.data = st_pll3200c32_a1x_0,
@@ -708,7 +708,7 @@ err:
 }
 CLK_OF_DECLARE(clkgen_c32_pll, st,clkgen-plls-c32, clkgen_c32_pll_setup);
 
-static struct of_device_id c32_gpu_pll_of_match[] = {
+static const struct of_device_id c32_gpu_pll_of_match[] = {
{
.compatible = st,stih415-gpu-pll-c32,
.data = st_pll1200c32_gpu_415,
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 59bb4b3..d86bc46 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device 
*pdev)
return 0;
 }
 
-static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
+static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
{ .compatible = ti,dra7-atl, },
{},
 };
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
index b4c5fac..35fe108 100644
--- a/drivers/clk/ti/clockdomain.c
+++ b/drivers/clk/ti/clockdomain.c
@@ -52,7 +52,7 @@ static void __init of_ti_clockdomain_setup(struct device_node 
*node)
}
 }
 
-static struct of_device_id ti_clkdm_match_table[] __initdata = {
+static const struct of_device_id ti_clkdm_match_table[] __initconst = {
{ .compatible = ti,clockdomain },
{ }
 };
diff --git a/drivers/clk/versatile/clk-vexpress-osc.c 
b/drivers/clk/versatile/clk-vexpress-osc.c
index 765f1e0..89c0609

[PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

[Fabian Frederick]

Small patchset addressing break redundancy on drivers/usb branch
(suggested by Joe Perches).

Fabian Frederick (10):
  USB: iowarrior: remove unnecessary break after goto
  USB: usblcd: remove unnecessary break after return
  usb: dcw3: remove unnecessary break after return
  usb: gadget: remove unnecessary break after return
  usb: gadget: remove unnecessary break after goto
  xhci: remove unnecessary break after return
  usb: storage: remove unnecessary break after return
  USB: serial: remove unnecessary break after return
  USB: ftdi_sio: remove unnecessary break after return
  USB: microtek: remove unnecessary break after goto

 drivers/usb/dwc3/ep0.c | 2 --
 drivers/usb/gadget/function/f_hid.c| 8 
 drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 --
 drivers/usb/host/xhci-mem.c| 1 -
 drivers/usb/image/microtek.c   | 1 -
 drivers/usb/misc/iowarrior.c   | 3 ---
 drivers/usb/misc/usblcd.c  | 1 -
 drivers/usb/serial/ftdi_sio.c  | 1 -
 drivers/usb/serial/iuu_phoenix.c   | 2 --
 drivers/usb/storage/freecom.c  | 1 -
 10 files changed, 22 deletions(-)

-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return

[Fabian Frederick]

Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/usb/dwc3/ep0.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 21a3520..927dad3 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -422,7 +422,6 @@ static int dwc3_ep0_handle_feature(struct dwc3 *dwc,
 
case USB_DEVICE_LTM_ENABLE:
return -EINVAL;
-   break;
 
case USB_DEVICE_TEST_MODE:
if ((wIndex  0xff) != 0)
@@ -530,7 +529,6 @@ static int dwc3_ep0_set_config(struct dwc3 *dwc, struct 
usb_ctrlrequest *ctrl)
switch (state) {
case USB_STATE_DEFAULT:
return -EINVAL;
-   break;
 
case USB_STATE_ADDRESS:
ret = dwc3_ep0_delegate_req(dwc, ctrl);
-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

[Fabian Frederick]

 On 24 July 2014 at 13:37 Oliver Neukum oneu...@suse.de wrote:


 On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
  Small patchset addressing break redundancy on drivers/usb branch
  (suggested by Joe Perches).

 Frankly, that is not a good idea. Somebody will remove a goto
 and forget to readd the break

No problem ; checkpatch would give a warning anyway. See Possible switch
case/default not preceeded by break or fallthrough comment

Regards,
Fabian

       Regards
               Oliver


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree

[Fabian Frederick]

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Peter Ujfalusi peter.ujfal...@ti.com
Cc: Jarkko Nikula jarkko.nik...@bitmer.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
 sound/soc/omap/mcbsp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 86c7538..68a1252 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
mcbsp-reg_cache = NULL;
spin_unlock(mcbsp-lock);
 
-   if (reg_cache)
-   kfree(reg_cache);
+   kfree(reg_cache);
 }
 
 /*
-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] drivers/video/fbdev/omap2/dss/dss.c: add __exit to dss_uninit_ports

[Fabian Frederick]

dss_uninit_ports is only called by __exit omap_dsshw_remove

Cc: Tomi Valkeinen tomi.valkei...@ti.com
Cc: linux-omap@vger.kernel.org
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
 drivers/video/fbdev/omap2/dss/dss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/dss/dss.c 
b/drivers/video/fbdev/omap2/dss/dss.c
index d55266c..a1c1cc2 100644
--- a/drivers/video/fbdev/omap2/dss/dss.c
+++ b/drivers/video/fbdev/omap2/dss/dss.c
@@ -813,7 +813,7 @@ static int __init dss_init_ports(struct platform_device 
*pdev)
return 0;
 }
 
-static void dss_uninit_ports(void)
+static void __exit dss_uninit_ports(void)
 {
 #ifdef CONFIG_OMAP2_DSS_DPI
dpi_uninit_port();
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html