Re: [PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot
On Thu, Aug 13, 2015 at 7:28 AM, Roger Quadros rog...@ti.com wrote: The gpio-desc migration done in v4.0 caused a regression with legacy boots due to reversed reset logic. e.g. omap3-beagle USB host breaks on legacy boot. Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that it matches the driver logic and pin behaviour. Fixes: e9f2cefb0cdc (usb: phy: generic: migrate to gpio_desc) Cc: sta...@vger.kernel.org # 4.0+ Signed-off-by: Roger Quadros rog...@ti.com The USB on my mx51-babbage board still works fine with this change: Tested-by: Fabio Estevam fabio.este...@freescale.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice
On Tue, Feb 3, 2015 at 6:52 PM, Felipe Balbi ba...@ti.com wrote:
it doesn't make a difference though, right ?
gpiod_direction_output(NULL, 1) won't do anything.
Yes, I will send a v3 without the NULL check.
gpiod_set_value returns immediately if desc is NULL:
void gpiod_set_value(struct gpio_desc *desc, int value)
{
if (!desc)
return;
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [next-20150119]regression (mm)?
On Tue, Jan 20, 2015 at 12:05 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Russell King - ARM Linux wrote: On Tue, Jan 20, 2015 at 02:16:43AM +0200, Kirill A. Shutemov wrote: Better option would be converting 2-lvl ARM configuration to asm-generic/pgtable-nopmd.h, but I'm not sure if it's possible. Well, IMHO the folded approach in asm-generic was done the wrong way which barred ARM from ever using it. Okay, I see. Regarding the topic bug. Completely untested patch is below. Could anybody check if it helps? Yes, it helps. Now I can boot mx6 running linux-next 20150120 with your patch applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings
On Tue, Oct 28, 2014 at 9:35 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Ok. I'd ask for one change. Please make all these messages start with L2C-310 OF not PL310 OF:. The device is described in ARM documentation as a L2C-310 not PL310. (Also note the : is dropped too - most of the other messages don't have the : either.) The: PL310 OF: cache setting yield illegal associativity PL310 OF: -1073346556 calculated, only 8 and 16 legal I have sent a patch to address this error message that happens when cache-size and cache-sets properties are not passed in DT: http://www.spinics.net/lists/arm-kernel/msg372094.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: OMAP baseline test results for v3.16-rc4
On Thu, Aug 7, 2014 at 7:21 PM, Paul Walmsley p...@pwsan.com wrote: It's commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75: Author: Ezequiel Garcia ezequiel.gar...@free-electrons.com Date: Wed Jul 23 16:47:31 2014 -0300 net: phy: Set the driver when registering an MDIO bus device mdiobus_register() registers a device which is already bound to a driver. Hence, the driver pointer should be set properly in order to track down the driver associated to the MDIO bus. This will be used to allow ethernet driver to pin down a MDIO bus driver, preventing it from being unloaded while the PHY device is running. Reviewed-by: Florian Fainelli f.faine...@gmail.com Tested-by: Florian Fainelli f.faine...@gmail.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Signed-off-by: David S. Miller da...@davemloft.net What's bad is that this went in late during v3.16-rc fixes. So now v3.16 itself is broken, and there's no way to fix it. I have sent a patch reverting this commit and it is in mainline now. It will reach 3.16.1: commit ce7991e8198b80eb6b4441b6f6114bea4a665d66 Author: Fabio Estevam fabio.este...@freescale.com Date: Tue Aug 5 08:13:42 2014 -0300 Revert net: phy: Set the driver when registering an MDIO bus device Commit a71e3c37960ce5f9 (net: phy: Set the driver when registering an MDIO bus device) caused the following regression on the fec driver: root@imx6qsabresd:~# echo mem /sys/power/state PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.003 seconds) done. Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done. Unable to handle kernel NULL pointer dereference at virtual address 002c pgd = bcd14000 [002c] *pgd=4d9e0831, *pte=, *ppte= Internal error: Oops: 17 [#1] SMP ARM Modules linked in: CPU: 0 PID: 617 Comm: sh Not tainted 3.16.0 #17 task: bc0c4e00 ti: bceb6000 task.ti: bceb6000 PC is at fec_suspend+0x10/0x70 LR is at dpm_run_callback.isra.7+0x34/0x6c pc : [803f8a98]lr : [80361f44]psr: 600f0013 sp : bceb7d70 ip : bceb7d88 fp : bceb7d84 r10: 8091523c r9 : r8 : bd88f478 r7 : 803f8a88 r6 : 81165988 r5 : r4 : r3 : r2 : r1 : bd88f478 r0 : bd88f478 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user Control: 10c5387d Table: 4cd1404a DAC: 0015 Process sh (pid: 617, stack limit = 0xbceb6240) Stack: (0xbceb7d70 to 0xbceb8000) The problem with the original commit is explained by Russell King: It has the effect (as can be seen from the oops) of attaching the MDIO bus device (itself is a bus-less device) to the platform driver, which means that if the platform driver supports power management, it will be called to power manage the MDIO bus device. Moreover, drivers do not expect to be called for power management operations for devices which they haven't probed, and certainly not for devices which aren't part of the same bus that the driver is registered against. This reverts commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75. Cc: sta...@vger.kernel.org #3.16 Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: David S. Miller da...@davemloft.net -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 08/13] tty: serial: omap: switch over to platform_get_resource
On Wed, Apr 23, 2014 at 11:58 AM, Felipe Balbi ba...@ti.com wrote:
@@ -1658,12 +1657,9 @@ static int serial_omap_probe(struct platform_device
*pdev)
omap_up_info = of_get_uart_port_info(pdev-dev);
pdev-dev.platform_data = omap_up_info;
} else {
- irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!irq) {
- dev_err(pdev-dev, no irq resource?\n);
- return -ENODEV;
- }
- uartirq = irq-start;
+ uartirq = platform_get_irq(pdev, 0);
+ if (uartirq 0)
+ return -EPROBE_DEFER;
Maybe you could just do a 'return uartirq' here instead.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used
On Fri, Aug 9, 2013 at 10:26 AM, Felipe Balbi ba...@ti.com wrote: looks good to me too, please send it as a real patch (if you already have, sorry about that, catching up with my inbox now). Yes, I have already sent it as a formal patch. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used
Hi Mark,
On Tue, Aug 6, 2013 at 12:49 PM, Mark Brown broo...@kernel.org wrote:
From: Andy Green andy.gr...@linaro.org
You might have CONFIG_PM, but you might not have CONFIG_SUSPEND, in which
case these are unused.
Signed-off-by: Andy Green andy.gr...@linaro.org
Signed-off-by: Mark Brown broo...@linaro.org
What about doing this instead?
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -191,7 +191,7 @@ static DEFINE_PCI_DEVICE_TABLE(dwc3_pci_id_table) = {
};
MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int dwc3_pci_suspend(struct device *dev)
{
struct pci_dev *pci = to_pci_dev(dev);
@@ -216,15 +216,10 @@ static int dwc3_pci_resume(struct device *dev)
return 0;
}
+#endif /* CONFIG_PM_SLEEP */
-static const struct dev_pm_ops dwc3_pci_dev_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(dwc3_pci_suspend, dwc3_pci_resume)
-};
-
-#define DEV_PM_OPS (dwc3_pci_dev_pm_ops)
-#else
-#define DEV_PM_OPS NULL
-#endif /* CONFIG_PM */
+static SIMPLE_DEV_PM_OPS(dwc3_pci_dev_pm_ops, dwc3_pci_suspend,
+dwc3_pci_resume);
static struct pci_driver dwc3_pci_driver = {
.name = dwc3-pci,
@@ -232,7 +227,7 @@ static struct pci_driver dwc3_pci_driver = {
.probe = dwc3_pci_probe,
.remove = dwc3_pci_remove,
.driver = {
- .pm = DEV_PM_OPS,
+ .pm = dwc3_pci_dev_pm_ops,
},
};
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: linux-3.11-rc1: Internal error: Oops - undefined instruction: 0 [#1] SMP ARM on OMAP3/AM335x
Hi Roger, On Mon, Jul 22, 2013 at 6:30 AM, Roger Quadros rog...@ti.com wrote: Hi, I observe the following problem on booting v3.11-rc1 on OMAP3 beagle board. [5.888946] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM [5.896057] Modules linked in: [5.899322] CPU: 0 PID: 9 Comm: rcu_sched Not tainted 3.11.0-rc2-1-g1ea701a #876 [5.907501] task: ce0720c0 ti: ce07a000 task.ti: ce07a000 [5.913208] PC is at check_and_switch_context+0x130/0x4dc [5.918914] LR is at check_and_switch_context+0xd8/0x4dc Got the same issue on a mx53 and prepared a fix. Will submit it shortly. Regards, Fabio Estevam -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 1/3] arm: introduce config HAS_BANDGAP
On Wed, May 15, 2013 at 11:58 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: Introduce HAS_BANDGAP config entry. This config is a boolean value so that arch code can flag is they feature a bandgap device. This config entry follows the same idea behind ARCH_HAS_CPUFREQ. It would be nice if you explain what BANDGAP means here, since you introduce this option in this patch. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Failure to boot...
On Thu, Jan 31, 2013 at 12:27 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: too. It also looks like Versatile Express support _can't_ be disabled in a multiplatform kernel, which is ludicrous. Should we go with this approach? https://patchwork.kernel.org/patch/1774521/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP: omap4-panda: add WiLink shared transport power functions
On Wed, Jan 16, 2013 at 6:34 PM, Luciano Coelho coe...@ti.com wrote:
+static int wilink_st_init(void)
+{
+ int status;
+
+ status = gpio_request(GPIO_BT_EN, kim);
+ if (status) {
+ pr_err(%s: failed to request gpio %d\n, __func__,
+ GPIO_BT_EN);
+ return status;
+ }
+
+ status = gpio_direction_output(GPIO_BT_EN, 0);
+ if (status)
+ pr_err(%s: unable to configure gpio %d, __func__,
+ GPIO_BT_EN);
+
You could use gpio_request_one() instead.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: implementing suspend to ram on cortex A8 based on linux 3.0.8
On Wed, Mar 7, 2012 at 12:05 PM, yang gqyang hustgqy...@gmail.com wrote: dear all: I am working on arm cortex a8 now, trying to implement suspend to ram based on linux 3.0.8. Which CPU exactly are you using? -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
