Re: [PATCH] arm: fix compilation warning during compilation
2010/11/8 Gadiyar, Anand : > 2010/11/8 Marco Stornelli : >> 2010/11/8 Uwe Kleine-König : >>> Hello, >>> >>> On Sat, Nov 06, 2010 at 10:06:35AM +0100, Marco Stornelli wrote: >>>> From: Marco Stornelli >>>> >>>> During compilation of 2.6.36 for Beagle board, there a are a couple of >>>> warnings. This patch fix them. >>> Please break lines for commit logs at around 76 chars and mention the >>> exact compiler warning being fixed. >>> >> >> My compiler version is gcc 4.4.1. Two warning: variable gpio_mux may >> be used not initialized (false positive, I agree); second: compiler >> fix the void lack in the inline function with an int. Obviously there >> is a lack of return type that it must be void. >> > > Marco, > > Both of these are fixed in 2.6.37-rc1. > > Commits afc28bc0ec and ca828760f9 respectively. > > - Anand > Very good. Thanks. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] arm: fix compilation warning during compilation
2010/11/8 Uwe Kleine-König : > Hello, > > On Sat, Nov 06, 2010 at 10:06:35AM +0100, Marco Stornelli wrote: >> From: Marco Stornelli >> >> During compilation of 2.6.36 for Beagle board, there a are a couple of >> warnings. This patch fix them. > Please break lines for commit logs at around 76 chars and mention the > exact compiler warning being fixed. > My compiler version is gcc 4.4.1. Two warning: variable gpio_mux may be used not initialized (false positive, I agree); second: compiler fix the void lack in the inline function with an int. Obviously there is a lack of return type that it must be void. Regards, Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] arm: fix compilation warning during compilation
From: Marco Stornelli
During compilation of 2.6.36 for Beagle board, there a are a couple of
warnings. This patch fix them.
Signed-off-by: Marco Stornelli
---
--- linux-2.6.36-orig/arch/arm/plat-omap/include/plat/usb.h 2010-10-20
22:30:22.0 +0200
+++ linux-2.6.36/arch/arm/plat-omap/include/plat/usb.h 2010-11-01
09:44:13.0 +0100
@@ -105,7 +105,7 @@ static inline void omap1_usb_init(struct
#if defined(CONFIG_ARCH_OMAP_OTG) || defined(CONFIG_ARCH_OMAP_OTG_MODULE)
void omap2_usbfs_init(struct omap_usb_config *pdata);
#else
-static inline omap2_usbfs_init(struct omap_usb_config *pdata)
+static inline void omap2_usbfs_init(struct omap_usb_config *pdata)
{
}
#endif
--- linux-2.6.36-orig/arch/arm/mach-omap2/mux.c 2010-10-20 22:30:22.0
+0200
+++ linux-2.6.36/arch/arm/mach-omap2/mux.c 2010-11-01 10:21:29.0
+0100
@@ -87,7 +87,7 @@ static char *omap_mux_options;
int __init omap_mux_init_gpio(int gpio, int val)
{
struct omap_mux_entry *e;
- struct omap_mux *gpio_mux;
+ struct omap_mux *gpio_mux = NULL;
u16 old_mode;
u16 mux_mode;
int found = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap udc driver problem with beagle board
2010/5/30 Felipe Balbi : > On Sun, May 30, 2010 at 11:53:49AM +0200, Marco Stornelli wrote: > beagle board uses musb. You shouldn't be relying on the udc controller. > Your Kconfig is just wrong. > > -- > balbi > Oops, my fault. I see the error in the configuration. Thank you very much for your response. I'll try again. Regards, Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: omap udc driver problem with beagle board
2010/5/30 Felipe Balbi : > On Sun, May 30, 2010 at 11:53:49AM +0200, Marco Stornelli wrote: > > beagle board uses musb. You shouldn't be relying on the udc controller. > Your Kconfig is just wrong. > > -- > balbi > Mmmdoes it mean that it's not possible to use g_ether driver? I read in several docs/wiki that it's possible. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
omap nand driver problem with beagle board
Hi, I'm using the kernel 2.6.34 with beagle board rev. c4. The omap nand driver fails the probe because the field phys_base in the omap_nand_platform_data struct is never set in the board specific code. Indeed, the driver fails because the read address is 0x0. Is it a regression? Has someone the same problem? What is phys address of nand in this board to fix the problem? Thanks. Regards, Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
omap udc driver problem with beagle board
Hi, I'm using the kernel 2.6.34 with the beagle board rev. c4. I have got some problems with the ethernet gadget to use nfs over usb. The problem is with the usb. When the g_ether driver register itself, the omap udc driver returns ENODEV because the kernel didn't call the probe for this driver. Looking at the code, it seems the problem is in board specific management of the usb. There isn't the registration of the platform device to match the omap udc platform driver. It should be done in the omap_usb_init() but in case of beagle board this function is never called, so omap udc driver cannot work. Is it a regression? Is there any workaround? Thanks. Regards, Marco -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
