[PATCH] Removes FIXME message in usb.c

[Nicholas Krause]

This patch removes a fixme message in this file for setting the usb 2
speed on the board to the correct level. We need to depend on the
bootloader for doing this as the wires may be shared for the other
things on the board with the usb chipset.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 arch/arm/mach-omap1/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
index 4118db5..172245a 100644
--- a/arch/arm/mach-omap1/usb.c
+++ b/arch/arm/mach-omap1/usb.c
@@ -505,7 +505,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned 
alt_pingroup)
omap_cfg_reg(W5_USB2_SE0);
if (nwires != 3)
omap_cfg_reg(Y5_USB2_RCV);
-   // FIXME omap_cfg_reg(USB2_SPEED);
+   /* Depend on boatloader for USB speed to be stated for board */
} else {
pr_debug(usb%d cpu unrecognized\n, 1);
return 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Removes FIXME message in usb.c

[Nicholas Krause]

This patch removes a fixme message in this file:wq for setting the usb 2
speed on the board to the correct level. We need to depend on the
bootloader for doing this as the wires may be shared for the other
things on the board with the usb chipset.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 arch/arm/mach-omap1/usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
index 4118db5..172245a 100644
--- a/arch/arm/mach-omap1/usb.c
+++ b/arch/arm/mach-omap1/usb.c
@@ -505,7 +505,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned 
alt_pingroup)
omap_cfg_reg(W5_USB2_SE0);
if (nwires != 3)
omap_cfg_reg(Y5_USB2_RCV);
-   // FIXME omap_cfg_reg(USB2_SPEED);
+   /* Depend on boatloader for USB speed to be stated for board */
} else {
pr_debug(usb%d cpu unrecognized\n, 1);
return 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mach-omap1: Fix call to omap_cfg_reg

[Nicholas Krause]

This patch fixes the call to ompa_cfg_reg(USB2_SPEED) in the case
that the cpu is a omap16xx and the nwires are not equal to 3.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 arch/arm/mach-omap1/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
index 4118db5..17e3139 100644
--- a/arch/arm/mach-omap1/usb.c
+++ b/arch/arm/mach-omap1/usb.c
@@ -504,8 +504,7 @@ static u32 __init omap1_usb2_init(unsigned nwires, unsigned 
alt_pingroup)
omap_cfg_reg(W9_USB2_TXEN);
omap_cfg_reg(W5_USB2_SE0);
if (nwires != 3)
-   omap_cfg_reg(Y5_USB2_RCV);
-   // FIXME omap_cfg_reg(USB2_SPEED);
+   omap_cfg_reg(USB2_SPEED)
} else {
pr_debug(usb%d cpu unrecognized\n, 1);
return 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable

[Nicholas Krause]

This patch changes this function to check for if v is returning value from the
called function. If not it does the else. Furthermore fixes the FIXME message 
above
if statement for holding INVERT_ENABLE bit when not needing to be checked for
in if statement by just checking for if v is not Null.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 arch/arm/mach-omap2/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 591581a..626363d 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -379,7 +379,7 @@ void omap2_dflt_clk_disable(struct clk_hw *hw)
}
 
v = omap2_clk_readl(clk, clk-enable_reg);
-   if (clk-flags  INVERT_ENABLE)
+   if (v)
v |= (1  clk-enable_bit);
else
v = ~(1  clk-enable_bit);
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()

[Nicholas Krause]

This removes the FIXME message above ocpi_enable being declared
for proper locking in this function. As of the current kernel
verisons there is no need for locking as only one driver uses
this function currently and therefore there is no need for real
locking requirements.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 arch/arm/mach-omap1/ocpi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
index 238170c..44a3d19 100644
--- a/arch/arm/mach-omap1/ocpi.c
+++ b/arch/arm/mach-omap1/ocpi.c
@@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
 
 /*
  * Enables device access to OMAP buses via the OCPI bridge
- * FIXME: Add locking
  */
 int ocpi_enable(void)
 {
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html